From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752720AbcEPBA2 (ORCPT <rfc822;w@1wt.eu>);
	Sun, 15 May 2016 21:00:28 -0400
Received: from mga11.intel.com ([192.55.52.93]:18547 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752262AbcEPBA0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 15 May 2016 21:00:26 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,625,1455004800"; 
   d="scan'208";a="981618194"
Subject: Re: [PATCH v8 1/7] regulator: fixed: add support for ACPI interface
To: Mark Brown <broonie@kernel.org>
References: <1462426383-3949-1-git-send-email-baolu.lu@linux.intel.com>
 <1462426383-3949-2-git-send-email-baolu.lu@linux.intel.com>
 <20160513111727.GD22038@sirena.org.uk>
Cc: felipe.balbi@linux.intel.com, Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Lee Jones <lee.jones@linaro.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Liam Girdwood <lgirdwood@gmail.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
From: Lu Baolu <baolu.lu@linux.intel.com>
Message-ID: <57391BA2.70503@linux.intel.com>
Date: Mon, 16 May 2016 09:00:18 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20160513111727.GD22038@sirena.org.uk>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 05/13/2016 07:17 PM, Mark Brown wrote:
> On Thu, May 05, 2016 at 01:32:57PM +0800, Lu Baolu wrote:
>
>> +	gpiod = gpiod_get(dev, "gpio", GPIOD_ASIS);
>> +	if (IS_ERR(gpiod))
>> +		return ERR_PTR(-ENODEV);
>> +	config->gpio = desc_to_gpio(gpiod);
>> +	config->enable_high = device_property_read_bool(dev,
>> +							"enable-active-high");
>> +	gpiod_put(gpiod);
> This isn't going to work at all if the GPIO is shared between multiple
> regulators but I can't immediately see a sensible way to fix that
> without some surgery on the GPIO APIs so let's leave it for now.

Okay. Thanks.

Best regards,
Lu Baolu