From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2Lpz-0006B8-Qi for qemu-devel@nongnu.org; Mon, 16 May 2016 12:57:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2Lpw-0000iH-0g for qemu-devel@nongnu.org; Mon, 16 May 2016 12:57:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2Lpv-0000iD-MH for qemu-devel@nongnu.org; Mon, 16 May 2016 12:57:43 -0400 References: <1463229957-14253-1-git-send-email-den@openvz.org> <1463229957-14253-6-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <5739FC05.9000705@redhat.com> Date: Mon, 16 May 2016 10:57:41 -0600 MIME-Version: 1.0 In-Reply-To: <1463229957-14253-6-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p5sqsRJ56XQq7ktRPvidlbCLPXnsQ3PQk" Subject: Re: [Qemu-devel] [PATCH 05/10] block: remove BlockDriver.bdrv_write_compressed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , qemu-devel@nongnu.org Cc: Pavel Butsykin , Jeff Cody , Markus Armbruster , John Snow , Stefan Hajnoczi , Kevin Wolf This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --p5sqsRJ56XQq7ktRPvidlbCLPXnsQ3PQk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/14/2016 06:45 AM, Denis V. Lunev wrote: > From: Pavel Butsykin >=20 > There are no block drivers left that implement the old > .bdrv_write_compressed interface, so it can be removed now. >=20 > Signed-off-by: Pavel Butsykin > Signed-off-by: Denis V. Lunev > CC: Jeff Cody > CC: Markus Armbruster > CC: Eric Blake > CC: John Snow > CC: Stefan Hajnoczi > CC: Kevin Wolf > --- > +++ b/block/io.c > @@ -1876,7 +1876,6 @@ static void bdrv_write_compressed_co_entry(void *= opaque) > int bdrv_write_compressed(BlockDriverState *bs, int64_t sector_num, > const uint8_t *buf, int nb_sectors) > { > - BlockDriver *drv =3D bs->drv; > BdrvWriteCompressedCo data =3D { > .bs =3D bs, > .sector_num =3D sector_num, > @@ -1885,19 +1884,6 @@ int bdrv_write_compressed(BlockDriverState *bs, = int64_t sector_num, > .ret =3D -EINPROGRESS, > }; > =20 > - if (!drv) { > - return -ENOMEDIUM; > - } Why are you deleting this check? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --p5sqsRJ56XQq7ktRPvidlbCLPXnsQ3PQk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXOfwFAAoJEKeha0olJ0NqvKsH/R1BLfc63PJz04WMmASYK/iW IPczmv57hw9HRKw7cSXjZHVLRDTIG1P7K4pbsTyzEykz6gp3IyfT2WBkFIN5ojsm AoVKUnNacDXbbT5qhJ7+T7+H/cBI/jUYqpFldAic+gwbwiCW8cZYYE59A2HSezZ2 LRcGVVhP7n/3PE0+EeNZeTwElYkEeA4hZAHBoKj/jYek7Nzan1fiRNHXbIfsntRa OkmNcO1Q06bYZiYtqw0991I/KjyuVRKCyLzIeMUyXrJKkpeDb7jHq3eo7n/AGRnq gLr/kjHTAutNL8JkfE8PuSoX0t/DAl/hGDhWOtGzXnqqBAygRrhhuggDQP1g+Zw= =Dd+V -----END PGP SIGNATURE----- --p5sqsRJ56XQq7ktRPvidlbCLPXnsQ3PQk--