From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dongdong Liu Subject: Re: [PATCH V7 07/11] pci, acpi: Handle ACPI companion assignment. Date: Tue, 17 May 2016 11:11:41 +0800 Message-ID: <573A8BED.7030908@huawei.com> References: <1462893601-8937-1-git-send-email-tn@semihalf.com> <1462893601-8937-8-git-send-email-tn@semihalf.com> Mime-Version: 1.0 Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1462893601-8937-8-git-send-email-tn@semihalf.com> Sender: linux-pci-owner@vger.kernel.org To: Tomasz Nowicki , helgaas@kernel.org, arnd@arndb.de, will.deacon@arm.com, catalin.marinas@arm.com, rafael@kernel.org, hanjun.guo@linaro.org, Lorenzo.Pieralisi@arm.com, okaya@codeaurora.org, jchandra@broadcom.com Cc: robert.richter@caviumnetworks.com, mw@semihalf.com, Liviu.Dudau@arm.com, ddaney@caviumnetworks.com, wangyijing@huawei.com, Suravee.Suthikulpanit@amd.com, msalter@redhat.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, jcm@redhat.com, andrea.gallo@linaro.org, dhdang@apm.com, jeremy.linton@arm.com, cov@codeaurora.org, Linuxarm List-Id: linux-acpi@vger.kernel.org Hi Tomasz I used the patchset and added "PATCH V6 11/13 specic quirks", tested on= HiSilicon D02 board but met the below problem. [ 2.614115] [] hisi_pcie_init+0x6c/0x1ec [ 2.619571] [] pci_ecam_create+0x130/0x1ec [ 2.625209] [] pci_acpi_scan_root+0x160/0x218 [ 2.631096] [] acpi_pci_root_add+0x36c/0x42c [ 2.636897] [] acpi_bus_attach+0xe4/0x1a8 [ 2.642438] [] acpi_bus_attach+0x150/0x1a8 [ 2.648066] [] acpi_bus_attach+0x150/0x1a8 [ 2.653693] [] acpi_bus_scan+0x64/0x74 [ 2.658975] [] acpi_scan_init+0x5c/0x19c [ 2.664429] [] acpi_init+0x280/0x2a4 [ 2.669538] [] do_one_initcall+0x8c/0x19c [ 2.675080] [] kernel_init_freeable+0x14c/0x1ec [ 2.681139] [] kernel_init+0x10/0xfc [ 2.686248] [] ret_from_fork+0x10/0x40 In hisi_pcie_init, I used "struct acpi_device *device =3D ACPI_COMPANIO= N(dev);". I found the reason is V7 lack the below code. I added the below code, i= t worked ok. [PATCH V6 01/13] pci, acpi, x86, ia64: Move ACPI host bridge device com= panion assignment to core code. --- a/drivers/acpi/pci_root.c +++ b/drivers/acpi/pci_root.c @@ -564,6 +564,11 @@ static int acpi_pci_root_add(struct acpi_device *d= evice, } } + /* + * pci_create_root_bus() needs to detect the parent device type, + * so initialize its companion data accordingly. + */ + ACPI_COMPANION_SET(&device->dev, device); This code will be upstreamed with the "PATCH V6 11/13 specic quirks" in= next time after the patchset is accepted. Right ? =D4=DA 2016/5/10 23:19, Tomasz Nowicki =D0=B4=B5=C0: > This patch provides a way to set the ACPI companion in PCI code. > We define acpi_pci_set_companion() to set the ACPI companion pointer = and > call it from PCI core code. The function is stub for now. > > Signed-off-by: Jayachandran C > Signed-off-by: Tomasz Nowicki > --- > drivers/pci/probe.c | 2 ++ > include/linux/pci-acpi.h | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 8004f67..fb0b752 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -2141,6 +2142,7 @@ struct pci_bus *pci_create_root_bus(struct devi= ce *parent, int bus, > bridge->dev.parent =3D parent; > bridge->dev.release =3D pci_release_host_bridge_dev; > dev_set_name(&bridge->dev, "pci%04x:%02x", pci_domain_nr(b), bus); > + acpi_pci_set_companion(bridge); > error =3D pcibios_root_bridge_prepare(bridge); > if (error) { > kfree(bridge); > diff --git a/include/linux/pci-acpi.h b/include/linux/pci-acpi.h > index 09f9f02..1baa515 100644 > --- a/include/linux/pci-acpi.h > +++ b/include/linux/pci-acpi.h > @@ -111,6 +111,10 @@ static inline void acpi_pci_add_bus(struct pci_b= us *bus) { } > static inline void acpi_pci_remove_bus(struct pci_bus *bus) { } > #endif /* CONFIG_ACPI */ > > +static inline void acpi_pci_set_companion(struct pci_host_bridge *br= idge) > +{ > +} > + > static inline int acpi_pci_bus_domain_nr(struct pci_bus *bus) > { > return 0; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755581AbcEQDOZ (ORCPT ); Mon, 16 May 2016 23:14:25 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:49568 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751763AbcEQDOL (ORCPT ); Mon, 16 May 2016 23:14:11 -0400 Subject: Re: [PATCH V7 07/11] pci, acpi: Handle ACPI companion assignment. To: Tomasz Nowicki , , , , , , , , , References: <1462893601-8937-1-git-send-email-tn@semihalf.com> <1462893601-8937-8-git-send-email-tn@semihalf.com> CC: , , , , , , , , , , , , , , , , , Linuxarm From: Dongdong Liu Message-ID: <573A8BED.7030908@huawei.com> Date: Tue, 17 May 2016 11:11:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1462893601-8937-8-git-send-email-tn@semihalf.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.61.21.156] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090201.573A8C0C.00B6,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 661e487e791578d941086aadde1fdac1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomasz I used the patchset and added "PATCH V6 11/13 specic quirks", tested on HiSilicon D02 board but met the below problem. [ 2.614115] [] hisi_pcie_init+0x6c/0x1ec [ 2.619571] [] pci_ecam_create+0x130/0x1ec [ 2.625209] [] pci_acpi_scan_root+0x160/0x218 [ 2.631096] [] acpi_pci_root_add+0x36c/0x42c [ 2.636897] [] acpi_bus_attach+0xe4/0x1a8 [ 2.642438] [] acpi_bus_attach+0x150/0x1a8 [ 2.648066] [] acpi_bus_attach+0x150/0x1a8 [ 2.653693] [] acpi_bus_scan+0x64/0x74 [ 2.658975] [] acpi_scan_init+0x5c/0x19c [ 2.664429] [] acpi_init+0x280/0x2a4 [ 2.669538] [] do_one_initcall+0x8c/0x19c [ 2.675080] [] kernel_init_freeable+0x14c/0x1ec [ 2.681139] [] kernel_init+0x10/0xfc [ 2.686248] [] ret_from_fork+0x10/0x40 In hisi_pcie_init, I used "struct acpi_device *device = ACPI_COMPANION(dev);". I found the reason is V7 lack the below code. I added the below code, it worked ok. [PATCH V6 01/13] pci, acpi, x86, ia64: Move ACPI host bridge device companion assignment to core code. --- a/drivers/acpi/pci_root.c +++ b/drivers/acpi/pci_root.c @@ -564,6 +564,11 @@ static int acpi_pci_root_add(struct acpi_device *device, } } + /* + * pci_create_root_bus() needs to detect the parent device type, + * so initialize its companion data accordingly. + */ + ACPI_COMPANION_SET(&device->dev, device); This code will be upstreamed with the "PATCH V6 11/13 specic quirks" in next time after the patchset is accepted. Right ? ÔÚ 2016/5/10 23:19, Tomasz Nowicki дµÀ: > This patch provides a way to set the ACPI companion in PCI code. > We define acpi_pci_set_companion() to set the ACPI companion pointer and > call it from PCI core code. The function is stub for now. > > Signed-off-by: Jayachandran C > Signed-off-by: Tomasz Nowicki > --- > drivers/pci/probe.c | 2 ++ > include/linux/pci-acpi.h | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 8004f67..fb0b752 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -2141,6 +2142,7 @@ struct pci_bus *pci_create_root_bus(struct device *parent, int bus, > bridge->dev.parent = parent; > bridge->dev.release = pci_release_host_bridge_dev; > dev_set_name(&bridge->dev, "pci%04x:%02x", pci_domain_nr(b), bus); > + acpi_pci_set_companion(bridge); > error = pcibios_root_bridge_prepare(bridge); > if (error) { > kfree(bridge); > diff --git a/include/linux/pci-acpi.h b/include/linux/pci-acpi.h > index 09f9f02..1baa515 100644 > --- a/include/linux/pci-acpi.h > +++ b/include/linux/pci-acpi.h > @@ -111,6 +111,10 @@ static inline void acpi_pci_add_bus(struct pci_bus *bus) { } > static inline void acpi_pci_remove_bus(struct pci_bus *bus) { } > #endif /* CONFIG_ACPI */ > > +static inline void acpi_pci_set_companion(struct pci_host_bridge *bridge) > +{ > +} > + > static inline int acpi_pci_bus_domain_nr(struct pci_bus *bus) > { > return 0; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: liudongdong3@huawei.com (Dongdong Liu) Date: Tue, 17 May 2016 11:11:41 +0800 Subject: [PATCH V7 07/11] pci, acpi: Handle ACPI companion assignment. In-Reply-To: <1462893601-8937-8-git-send-email-tn@semihalf.com> References: <1462893601-8937-1-git-send-email-tn@semihalf.com> <1462893601-8937-8-git-send-email-tn@semihalf.com> Message-ID: <573A8BED.7030908@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Tomasz I used the patchset and added "PATCH V6 11/13 specic quirks", tested on HiSilicon D02 board but met the below problem. [ 2.614115] [] hisi_pcie_init+0x6c/0x1ec [ 2.619571] [] pci_ecam_create+0x130/0x1ec [ 2.625209] [] pci_acpi_scan_root+0x160/0x218 [ 2.631096] [] acpi_pci_root_add+0x36c/0x42c [ 2.636897] [] acpi_bus_attach+0xe4/0x1a8 [ 2.642438] [] acpi_bus_attach+0x150/0x1a8 [ 2.648066] [] acpi_bus_attach+0x150/0x1a8 [ 2.653693] [] acpi_bus_scan+0x64/0x74 [ 2.658975] [] acpi_scan_init+0x5c/0x19c [ 2.664429] [] acpi_init+0x280/0x2a4 [ 2.669538] [] do_one_initcall+0x8c/0x19c [ 2.675080] [] kernel_init_freeable+0x14c/0x1ec [ 2.681139] [] kernel_init+0x10/0xfc [ 2.686248] [] ret_from_fork+0x10/0x40 In hisi_pcie_init, I used "struct acpi_device *device = ACPI_COMPANION(dev);". I found the reason is V7 lack the below code. I added the below code, it worked ok. [PATCH V6 01/13] pci, acpi, x86, ia64: Move ACPI host bridge device companion assignment to core code. --- a/drivers/acpi/pci_root.c +++ b/drivers/acpi/pci_root.c @@ -564,6 +564,11 @@ static int acpi_pci_root_add(struct acpi_device *device, } } + /* + * pci_create_root_bus() needs to detect the parent device type, + * so initialize its companion data accordingly. + */ + ACPI_COMPANION_SET(&device->dev, device); This code will be upstreamed with the "PATCH V6 11/13 specic quirks" in next time after the patchset is accepted. Right ? ? 2016/5/10 23:19, Tomasz Nowicki ??: > This patch provides a way to set the ACPI companion in PCI code. > We define acpi_pci_set_companion() to set the ACPI companion pointer and > call it from PCI core code. The function is stub for now. > > Signed-off-by: Jayachandran C > Signed-off-by: Tomasz Nowicki > --- > drivers/pci/probe.c | 2 ++ > include/linux/pci-acpi.h | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 8004f67..fb0b752 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -2141,6 +2142,7 @@ struct pci_bus *pci_create_root_bus(struct device *parent, int bus, > bridge->dev.parent = parent; > bridge->dev.release = pci_release_host_bridge_dev; > dev_set_name(&bridge->dev, "pci%04x:%02x", pci_domain_nr(b), bus); > + acpi_pci_set_companion(bridge); > error = pcibios_root_bridge_prepare(bridge); > if (error) { > kfree(bridge); > diff --git a/include/linux/pci-acpi.h b/include/linux/pci-acpi.h > index 09f9f02..1baa515 100644 > --- a/include/linux/pci-acpi.h > +++ b/include/linux/pci-acpi.h > @@ -111,6 +111,10 @@ static inline void acpi_pci_add_bus(struct pci_bus *bus) { } > static inline void acpi_pci_remove_bus(struct pci_bus *bus) { } > #endif /* CONFIG_ACPI */ > > +static inline void acpi_pci_set_companion(struct pci_host_bridge *bridge) > +{ > +} > + > static inline int acpi_pci_bus_domain_nr(struct pci_bus *bus) > { > return 0; >