From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH] ARM: tegra: beaver: allow SD card voltage to be changed Date: Thu, 19 May 2016 15:31:31 +0100 Message-ID: <573DCE43.70906@nvidia.com> References: <1456779678-20173-1-git-send-email-dev@lynxeye.de> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1456779678-20173-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lucas Stach , Stephen Warren , Thierry Reding , Alexandre Courbot Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 29/02/16 21:01, Lucas Stach wrote: > This allows to switch the card signal voltage level to 1.8V, > which is needed for any ultra high speed modes to work. > > Signed-off-by: Lucas Stach > --- > This needs the SDMMC memcomp pad calibration patches I just > sent out to be applied, otherwise the card voltage change will > fail with a message in the kernel log and a fall back to > high speed operation. > --- > arch/arm/boot/dts/tegra30-beaver.dts | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/tegra30-beaver.dts b/arch/arm/boot/dts/tegra30-beaver.dts > index 1daed40..6b237f2 100644 > --- a/arch/arm/boot/dts/tegra30-beaver.dts > +++ b/arch/arm/boot/dts/tegra30-beaver.dts > @@ -1848,7 +1848,7 @@ > > ldo5_reg: ldo5 { > regulator-name = "vddio_sdmmc,avdd_vdac"; Stephen, looking at the schematics, I don't see that this is connected to the avdd_vdac (which appears to be unconnected) and so I am wondering if this name should be just "vddio_sdmmc"? > - regulator-min-microvolt = <3300000>; > + regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <3300000>; > regulator-always-on; > }; > @@ -1919,6 +1919,7 @@ > > sdhci@78000000 { > status = "okay"; > + vqmmc-supply = <&ldo5_reg>; > cd-gpios = <&gpio TEGRA_GPIO(I, 5) GPIO_ACTIVE_LOW>; > wp-gpios = <&gpio TEGRA_GPIO(T, 3) GPIO_ACTIVE_HIGH>; > power-gpios = <&gpio TEGRA_GPIO(D, 7) GPIO_ACTIVE_HIGH>; > Otherwise ... Acked-by: Jon Hunter Cheers Jon -- nvpublic From mboxrd@z Thu Jan 1 00:00:00 1970 From: jonathanh@nvidia.com (Jon Hunter) Date: Thu, 19 May 2016 15:31:31 +0100 Subject: [PATCH] ARM: tegra: beaver: allow SD card voltage to be changed In-Reply-To: <1456779678-20173-1-git-send-email-dev@lynxeye.de> References: <1456779678-20173-1-git-send-email-dev@lynxeye.de> Message-ID: <573DCE43.70906@nvidia.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 29/02/16 21:01, Lucas Stach wrote: > This allows to switch the card signal voltage level to 1.8V, > which is needed for any ultra high speed modes to work. > > Signed-off-by: Lucas Stach > --- > This needs the SDMMC memcomp pad calibration patches I just > sent out to be applied, otherwise the card voltage change will > fail with a message in the kernel log and a fall back to > high speed operation. > --- > arch/arm/boot/dts/tegra30-beaver.dts | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/tegra30-beaver.dts b/arch/arm/boot/dts/tegra30-beaver.dts > index 1daed40..6b237f2 100644 > --- a/arch/arm/boot/dts/tegra30-beaver.dts > +++ b/arch/arm/boot/dts/tegra30-beaver.dts > @@ -1848,7 +1848,7 @@ > > ldo5_reg: ldo5 { > regulator-name = "vddio_sdmmc,avdd_vdac"; Stephen, looking at the schematics, I don't see that this is connected to the avdd_vdac (which appears to be unconnected) and so I am wondering if this name should be just "vddio_sdmmc"? > - regulator-min-microvolt = <3300000>; > + regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <3300000>; > regulator-always-on; > }; > @@ -1919,6 +1919,7 @@ > > sdhci at 78000000 { > status = "okay"; > + vqmmc-supply = <&ldo5_reg>; > cd-gpios = <&gpio TEGRA_GPIO(I, 5) GPIO_ACTIVE_LOW>; > wp-gpios = <&gpio TEGRA_GPIO(T, 3) GPIO_ACTIVE_HIGH>; > power-gpios = <&gpio TEGRA_GPIO(D, 7) GPIO_ACTIVE_HIGH>; > Otherwise ... Acked-by: Jon Hunter Cheers Jon -- nvpublic