Re: [PATCH 4/4] drm/omapdrm: Implement gamma_lut atomic crtc property

[Jyri Sarha <jsarha@ti.com>]

On 05/20/16 10:05, Daniel Vetter wrote:
> On Fri, May 20, 2016 at 09:35:56AM +0300, Jyri Sarha wrote:
>> > Implement gamma_lut atomic crtc property, set crtc gamma size to 256
>> > for all crtcs and use drm_atomic_helper_legacy_gamma_set() as
>> > gamma_set func. The tv-out crtc has 1024 element gamma table (with
>> > 10bit precision) in HW, but current Xorg server does not accept
>> > anything else but 256 elements so that is used for all CRTCs. The dss
>> > dispc API converts table of any length for HW and uses linear
>> > interpolation in the process.
>> > 
>> > Signed-off-by: Jyri Sarha <jsarha@ti.com>
> I think you also want to wire up drm_atomic_helper_legacy_gamma_set so
> that legacy clients using the gamma ioctl will work with this support.

But it is there couple of lines down, or am I missing something?

BR,
Jyri

> 
>> > ---
>> >  drivers/gpu/drm/omapdrm/omap_crtc.c | 20 ++++++++++++++++++++
>> >  1 file changed, 20 insertions(+)
...
>> > @@ -460,6 +469,7 @@ static const struct drm_crtc_funcs omap_crtc_funcs = {
>> >  	.set_config = drm_atomic_helper_set_config,
>> >  	.destroy = omap_crtc_destroy,
>> >  	.page_flip = drm_atomic_helper_page_flip,
>> > +	.gamma_set = drm_atomic_helper_legacy_gamma_set,
Here ^^^
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel