From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933074AbcETIWX (ORCPT ); Fri, 20 May 2016 04:22:23 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34076 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932808AbcETIWV (ORCPT ); Fri, 20 May 2016 04:22:21 -0400 Subject: Re: [PATCH] irqchip: nps: add 64BIT dependency To: Geert Uytterhoeven , Arnd Bergmann References: <1463087038-2522527-1-git-send-email-arnd@arndb.de> Cc: Jason Cooper , Noam Camus , arcml , Thomas Gleixner , Marc Zyngier , "linux-kernel@vger.kernel.org" From: Vineet Gupta Organization: Synopsys Message-ID: <573EC932.5060106@synopsys.com> Date: Fri, 20 May 2016 13:52:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 20 May 2016 01:04 PM, Geert Uytterhoeven wrote: > Hi Arnd, > > On Thu, May 12, 2016 at 11:03 PM, Arnd Bergmann wrote: >> The newly added nps irqchip driver causes build warnings on ARM64. >> >> include/soc/nps/common.h: In function 'nps_host_reg_non_cl': >> include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] >> >> As the driver is only used on ARC, we don't need to see it without >> COMPILE_TEST elsewhere, and we can avoid the warnings by only >> building on 32-bit architectures even with CONFIG_COMPILE_TEST. >> >> Signed-off-by: Arnd Bergmann >> --- >> drivers/irqchip/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig >> index 83775f148158..37289cf6b449 100644 >> --- a/drivers/irqchip/Kconfig >> +++ b/drivers/irqchip/Kconfig >> @@ -253,6 +253,7 @@ config MVEBU_ODMI >> >> config EZNPS_GIC >> bool "NPS400 Global Interrupt Manager (GIM)" >> + depends on ARC || (COMPILE_TEST && !64BIT) >> select IRQ_DOMAIN >> help >> Support the EZchip NPS400 global interrupt controller > > As ARC_PLAT_EZNPS already selects EZNPS_GIC, I'd like to suggest > the slight simpler (whitespace-damaged): I'm afraid you are late to party - this has been sent Linus' way earlier today ! But it does look prettier so we can do this after rc1 > > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -255,7 +255,8 @@ config PARTITION_PERCPU > bool > > config EZNPS_GIC > - bool "NPS400 Global Interrupt Manager (GIM)" > + bool "NPS400 Global Interrupt Manager (GIM)" if COMPILE_TEST > + depends on !64BIT > select IRQ_DOMAIN > help > Support the EZchip NPS400 global interrupt controller > > Gr{oetje,eeting}s, > > Geert > From mboxrd@z Thu Jan 1 00:00:00 1970 From: vgupta@synopsys.com (Vineet Gupta) Date: Fri, 20 May 2016 13:52:10 +0530 Subject: [PATCH] irqchip: nps: add 64BIT dependency In-Reply-To: References: <1463087038-2522527-1-git-send-email-arnd@arndb.de> List-ID: Message-ID: <573EC932.5060106@synopsys.com> To: linux-snps-arc@lists.infradead.org On Friday 20 May 2016 01:04 PM, Geert Uytterhoeven wrote: > Hi Arnd, > > On Thu, May 12, 2016@11:03 PM, Arnd Bergmann wrote: >> The newly added nps irqchip driver causes build warnings on ARM64. >> >> include/soc/nps/common.h: In function 'nps_host_reg_non_cl': >> include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] >> >> As the driver is only used on ARC, we don't need to see it without >> COMPILE_TEST elsewhere, and we can avoid the warnings by only >> building on 32-bit architectures even with CONFIG_COMPILE_TEST. >> >> Signed-off-by: Arnd Bergmann >> --- >> drivers/irqchip/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig >> index 83775f148158..37289cf6b449 100644 >> --- a/drivers/irqchip/Kconfig >> +++ b/drivers/irqchip/Kconfig >> @@ -253,6 +253,7 @@ config MVEBU_ODMI >> >> config EZNPS_GIC >> bool "NPS400 Global Interrupt Manager (GIM)" >> + depends on ARC || (COMPILE_TEST && !64BIT) >> select IRQ_DOMAIN >> help >> Support the EZchip NPS400 global interrupt controller > > As ARC_PLAT_EZNPS already selects EZNPS_GIC, I'd like to suggest > the slight simpler (whitespace-damaged): I'm afraid you are late to party - this has been sent Linus' way earlier today ! But it does look prettier so we can do this after rc1 > > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -255,7 +255,8 @@ config PARTITION_PERCPU > bool > > config EZNPS_GIC > - bool "NPS400 Global Interrupt Manager (GIM)" > + bool "NPS400 Global Interrupt Manager (GIM)" if COMPILE_TEST > + depends on !64BIT > select IRQ_DOMAIN > help > Support the EZchip NPS400 global interrupt controller > > Gr{oetje,eeting}s, > > Geert >