From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 1/4] drm/omapdrm: omap_modeset_init: Separate crtc id and plane id indexing Date: Fri, 20 May 2016 15:14:48 +0300 Message-ID: <573EFFB8.2000405@ti.com> References: <105395ebfaf613df0fccd236832f0fa72be2ee5f.1463726043.git.jsarha@ti.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0982620972==" Return-path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6AEFB6E34A for ; Fri, 20 May 2016 12:15:00 +0000 (UTC) In-Reply-To: <105395ebfaf613df0fccd236832f0fa72be2ee5f.1463726043.git.jsarha@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jyri Sarha , dri-devel@lists.freedesktop.org Cc: peter.ujfalusi@ti.com, laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org --===============0982620972== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xCBLUS4e3TTOGaHm5DThi9WHMGVjPLK8E" --xCBLUS4e3TTOGaHm5DThi9WHMGVjPLK8E Content-Type: multipart/mixed; boundary="PBh5H2E0SsXIa78vJkllwgNiUN8RwR94U" From: Tomi Valkeinen To: Jyri Sarha , dri-devel@lists.freedesktop.org Cc: airlied@linux.ie, daniel@ffwll.ch, peter.ujfalusi@ti.com, bparrot@ti.com, laurent.pinchart@ideasonboard.com Message-ID: <573EFFB8.2000405@ti.com> Subject: Re: [PATCH 1/4] drm/omapdrm: omap_modeset_init: Separate crtc id and plane id indexing References: <105395ebfaf613df0fccd236832f0fa72be2ee5f.1463726043.git.jsarha@ti.com> In-Reply-To: <105395ebfaf613df0fccd236832f0fa72be2ee5f.1463726043.git.jsarha@ti.com> --PBh5H2E0SsXIa78vJkllwgNiUN8RwR94U Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 20/05/16 09:35, Jyri Sarha wrote: > Separate crtc id and plane id indexing in omap_modeset_init(). The > coupling of crtc- and plane-id is hard to follow. The id stuff does need cleanup, but I don't think this patch does that well enough. A few quick ones: omap_crtc_init() doesn't use the id parameter, so it could just be droppe= d. "crtc_id" and "plane_id" are misleading. Usually those mean the id numbere of the DRM object. Here plane_id is really the 'enum omap_plane' from omapdss, if I'm not mistaken. Probably the first step with cleaning this up would be to rename that enum so that it can be used in omapdrm. Tomi --PBh5H2E0SsXIa78vJkllwgNiUN8RwR94U-- --xCBLUS4e3TTOGaHm5DThi9WHMGVjPLK8E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXPv+7AAoJEPo9qoy8lh71pb8P/20r2Hd/Z4Ocgnn9CCpyuYcT J8+WYBGJDvlAClxdoeO8SQaxgZrzQZU34yQkXqiubS7YKvjQEa/y7l+luUxVTBvU B2oU0CPHdY2PusiYoLuOfQWLoqF6aEzZ2sgV2FyYhTpZYt3F2JpZQ4woulMb+IcH Yhyk+DMgzF8Jxm5WSBhS8HUTm7LuXWs4TKNApxa+H9HmpTk5XovGZb6cFwT/oHpG wDNWCM0rtJ3AFL+fdEZRS8N+E3Zt7589VXbz9gFAoBJGkLbUOTNItJyqWfLJb0E6 f+vwuqyqR7tKSVRDH6r5QBcuhZ8hBP30ZP5r2XFz55dx+VWvKogdDrIdtvUoxAOO 4FBye7nRmmd6me26sWPiZCP2qnPaYjBfq9cNn2IITjwTGivYVsfVe5luyV4C8m3Y AWWOnv8P8tHZFDbkBYW0Wh9cVntLzC5q6Lnb4JFrBzmXxPjtL8NMn60YOlU+ltCa lXieXKn4/NL7ufXg1ayRBLLLOv/g1Xnp3Eg1gw6l9WfVQJLYRyincLBdcSB84GKv hHfQTonU+ono+xZ47zFmD0dP7LxRZ4YGRp8b2HeQWEpxQLQTY8zE44Or6VS52MUc V5PE1MPnQB8J6pfEuoc7HiqGyGeYiCSWawb9O1BPyz+7YLSQCnEsdgNJ4Poq6465 y1N0Z+RcTlP803MwOf2l =DTAc -----END PGP SIGNATURE----- --xCBLUS4e3TTOGaHm5DThi9WHMGVjPLK8E-- --===============0982620972== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0982620972==--