* [PATCH] erofs: remove a void EROFS_VERSION macro set in Makefile
@ 2020-10-30 12:28 Vladimir Zapolskiy
2020-10-30 12:34 ` Gao Xiang
2020-12-08 7:44 ` Chao Yu
0 siblings, 2 replies; 3+ messages in thread
From: Vladimir Zapolskiy @ 2020-10-30 12:28 UTC (permalink / raw)
To: Gao Xiang, Chao Yu; +Cc: linux-erofs
Since commit 4f761fa253b4 ("erofs: rename errln/infoln/debugln to
erofs_{err, info, dbg}") the defined macro EROFS_VERSION has no affect,
therefore removing it from the Makefile is a non-functional change.
Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>
---
fs/erofs/Makefile | 5 -----
1 file changed, 5 deletions(-)
diff --git a/fs/erofs/Makefile b/fs/erofs/Makefile
index 46f2aa4ba46c..af159539fc1b 100644
--- a/fs/erofs/Makefile
+++ b/fs/erofs/Makefile
@@ -1,11 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
-EROFS_VERSION = "1.0"
-
-ccflags-y += -DEROFS_VERSION=\"$(EROFS_VERSION)\"
-
obj-$(CONFIG_EROFS_FS) += erofs.o
erofs-objs := super.o inode.o data.o namei.o dir.o utils.o
erofs-$(CONFIG_EROFS_FS_XATTR) += xattr.o
erofs-$(CONFIG_EROFS_FS_ZIP) += decompressor.o zmap.o zdata.o
-
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] erofs: remove a void EROFS_VERSION macro set in Makefile
2020-10-30 12:28 [PATCH] erofs: remove a void EROFS_VERSION macro set in Makefile Vladimir Zapolskiy
@ 2020-10-30 12:34 ` Gao Xiang
2020-12-08 7:44 ` Chao Yu
1 sibling, 0 replies; 3+ messages in thread
From: Gao Xiang @ 2020-10-30 12:34 UTC (permalink / raw)
To: Vladimir Zapolskiy; +Cc: Gao Xiang, linux-erofs
On Fri, Oct 30, 2020 at 02:28:39PM +0200, Vladimir Zapolskiy wrote:
> Since commit 4f761fa253b4 ("erofs: rename errln/infoln/debugln to
> erofs_{err, info, dbg}") the defined macro EROFS_VERSION has no affect,
> therefore removing it from the Makefile is a non-functional change.
>
> Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>
> ---
Yeah, since we have feature bits now, and fs runtime version
isn't very important... Thanks for doing this!
Reviewed-by: Gao Xiang <hsiangkao@redhat.com>
Thanks,
Gao Xiang
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] erofs: remove a void EROFS_VERSION macro set in Makefile
2020-10-30 12:28 [PATCH] erofs: remove a void EROFS_VERSION macro set in Makefile Vladimir Zapolskiy
2020-10-30 12:34 ` Gao Xiang
@ 2020-12-08 7:44 ` Chao Yu
1 sibling, 0 replies; 3+ messages in thread
From: Chao Yu @ 2020-12-08 7:44 UTC (permalink / raw)
To: Vladimir Zapolskiy, Gao Xiang, Chao Yu; +Cc: linux-erofs
On 2020/10/30 20:28, Vladimir Zapolskiy wrote:
> Since commit 4f761fa253b4 ("erofs: rename errln/infoln/debugln to
> erofs_{err, info, dbg}") the defined macro EROFS_VERSION has no affect,
> therefore removing it from the Makefile is a non-functional change.
>
> Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-08 8:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-30 12:28 [PATCH] erofs: remove a void EROFS_VERSION macro set in Makefile Vladimir Zapolskiy
2020-10-30 12:34 ` Gao Xiang
2020-12-08 7:44 ` Chao Yu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.