From: John Garry <john.garry@huawei.com>
To: chenxiang <chenxiang66@hisilicon.com>, <robin.murphy@arm.com>,
<will@kernel.org>, <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org, linuxarm@openeuler.org,
linuxarm@huawei.com
Subject: Re: [PATCH v3] iommu/iova: put free_iova_mem() outside of spinlock iova_rbtree_lock
Date: Mon, 19 Apr 2021 08:35:20 +0100 [thread overview]
Message-ID: <573daaa0-047a-d117-3a2e-46d6d776f175@huawei.com> (raw)
In-Reply-To: <1618816415-95649-1-git-send-email-chenxiang66@hisilicon.com>
On 19/04/2021 08:13, chenxiang wrote:
> From: Xiang Chen<chenxiang66@hisilicon.com>
>
> It is not necessary to put free_iova_mem() inside of spinlock/unlock
> iova_rbtree_lock which only leads to more completion for the spinlock.
> It has a small promote on the performance after the change. And also
> rename private_free_iova() as remove_iova() because the function will not
> free iova after that change.
>
> Signed-off-by: Xiang Chen<chenxiang66@hisilicon.com>
I think that you will need to resend after v5.13-rc1 comes out, however:
Reviewed-by: John Garry <john.garry@huawei.com>
> ---
> drivers/iommu/
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-04-19 7:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 7:13 [PATCH v3] iommu/iova: put free_iova_mem() outside of spinlock iova_rbtree_lock chenxiang
2021-04-19 7:35 ` John Garry [this message]
2021-05-18 9:08 ` Joerg Roedel
2021-05-18 9:25 ` chenxiang (M)
2021-05-18 9:25 ` Robin Murphy
2021-05-18 9:26 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573daaa0-047a-d117-3a2e-46d6d776f175@huawei.com \
--to=john.garry@huawei.com \
--cc=chenxiang66@hisilicon.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linuxarm@huawei.com \
--cc=linuxarm@openeuler.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.