From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH] mbuf: new flag when Vlan is stripped
Date: Mon, 23 May 2016 11:12:49 +0200
Message-ID: <5742C991.7090808@6wind.com>
References: <1462897493-6567-1-git-send-email-olivier.matz@6wind.com>
 <1463993205-5623-1-git-send-email-olivier.matz@6wind.com>
 <2601191342CEEE43887BDE71AB97725836B5CA88@irsmsx105.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: "johndale@cisco.com" <johndale@cisco.com>,
 "Zhang, Helin" <helin.zhang@intel.com>,
 "adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>,
 "rahul.lakkireddy@chelsio.com" <rahul.lakkireddy@chelsio.com>,
 "alejandro.lucero@netronome.com" <alejandro.lucero@netronome.com>,
 "sony.chacko@qlogic.com" <sony.chacko@qlogic.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id C26705AB3
 for <dev@dpdk.org>; Mon, 23 May 2016 11:13:02 +0200 (CEST)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836B5CA88@irsmsx105.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Konstantin,

On 05/23/2016 10:59 AM, Ananyev, Konstantin wrote:
> Hi Olivier,
> 
>> -----Original Message-----
>> From: Olivier Matz [mailto:olivier.matz@6wind.com]
>> Sent: Monday, May 23, 2016 9:47 AM
>> To: dev@dpdk.org
>> Cc: johndale@cisco.com; Ananyev, Konstantin; Zhang, Helin; adrien.mazarguil@6wind.com; rahul.lakkireddy@chelsio.com;
>> alejandro.lucero@netronome.com; sony.chacko@qlogic.com
>> Subject: [PATCH] mbuf: new flag when Vlan is stripped
>>
>> The behavior of PKT_RX_VLAN_PKT was not very well defined, resulting in
>> PMDs not advertising the same flags in similar conditions.
>>
>> Following discussion in [1], introduce 2 new flags PKT_RX_VLAN_STRIPPED
>> and PKT_RX_QINQ_STRIPPED that are better defined:
>>
>>   PKT_RX_VLAN_STRIPPED: a vlan has been stripped by the hardware and its
>>   tci is saved in mbuf->vlan_tci. This can only happen if vlan stripping
>>   is enabled in the RX configuration of the PMD.
>>
>> For now, the old flag PKT_RX_VLAN_PKT is kept but marked as deprecated.
>> It should be removed from applications and PMDs in a future revision.
>>
>> This patch also updates the drivers. For PKT_RX_VLAN_PKT:
>>
>> - e1000, enic, i40e, mlx5, nfp, vmxnet3: done, PKT_RX_VLAN_PKT already
>>   had the same meaning than PKT_RX_VLAN_STRIPPED, minor update is
>>   required.
>> - fm10k: done, PKT_RX_VLAN_PKT already had the same meaning than
>>   PKT_RX_VLAN_STRIPPED, and vlan stripping is always enabled on fm10k.
>> - ixgbe: modification done for standard mode (vector does not support
>>   vlan stripping)
>> - the other drivers do not support vlan stripping.
>>
>> For PKT_RX_QINQ_PKT, it was only supported on i40e, and the meaning was
>> already correct, so we can reuse the same value for PKT_RX_QINQ_STRIPPED.
>>
> 
> I don't see ixgbe/i4oe_rxtx_vec.c updated.
> Would it be another patch for them?

The ixgbe vector and i40e vector do not support vlan stripping, so
from what I see there is nothing to do:
- The new flag PKT_RX_VLAN_STRIPPED is never returned
- We keep the old behavior for PKT_RX_VLAN_PKT.

Thanks,
Olivier