From: York Sun <york.sun@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] driver/ddr/fsl: Force enabling parity for A-009803
Date: Mon, 23 May 2016 08:33:11 -0700 [thread overview]
Message-ID: <574322B7.1030508@nxp.com> (raw)
In-Reply-To: <AMXPR04MB1845208D3759689DC448F8AF24E0@AMXPR04MB184.eurprd04.prod.outlook.com>
On 05/23/2016 02:18 AM, Shengzhou Liu wrote:
>> -----Original Message-----
>> From: York Sun [mailto:york.sun at nxp.com]
>> Sent: Friday, May 20, 2016 11:29 PM
>> To: Shengzhou Liu <shengzhou.liu@nxp.com>; u-boot at lists.denx.de
>> Subject: Re: [PATCH] driver/ddr/fsl: Force enabling parity for A-009803
>>>
>>
>> Shengzhou,
>>
>> It looks backward. You should detect if the condition is right before
>> applying the workaround, not by forcing the condition.
>>
>> York
>
> If ERRATUM_A009803 is defined, ap_en should always be enabled whatever user configures parity=on in hwconfig.
> As ERRATUM_A009803 is enabled only in arch-fsl-layerscape/config.h for LS2 SoC, I don't think we need to check anything other.
> What condition do you mean?
>
Shengzhou,
My point is you should force ap=1. Do you mean if ERRATUM_A009803 is enabled,
users are forced to use address parity? That doesn't sound right. We have been
running UDIMM without address parity for a long time.
York
next prev parent reply other threads:[~2016-05-23 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 8:05 [U-Boot] [PATCH] driver/ddr/fsl: Force enabling parity for A-009803 Shengzhou Liu
2016-05-20 15:29 ` York Sun
2016-05-23 9:18 ` Shengzhou Liu
2016-05-23 15:33 ` York Sun [this message]
2016-05-24 5:15 ` Shengzhou Liu
2016-05-24 16:13 ` York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574322B7.1030508@nxp.com \
--to=york.sun@nxp.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.