From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46161)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1b66o4-0002Ok-B6
	for qemu-devel@nongnu.org; Thu, 26 May 2016 21:43:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1b66o2-0003jJ-95
	for qemu-devel@nongnu.org; Thu, 26 May 2016 21:43:19 -0400
Message-ID: <5747A710.1000805@cn.fujitsu.com>
Date: Fri, 27 May 2016 09:46:56 +0800
From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
MIME-Version: 1.0
References: <1463729780-31982-1-git-send-email-xiecl.fnst@cn.fujitsu.com>
	<1463729780-31982-10-git-send-email-xiecl.fnst@cn.fujitsu.com>
In-Reply-To: <1463729780-31982-10-git-send-email-xiecl.fnst@cn.fujitsu.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v19 09/10] tests: add unit test case for
 replication
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <famz@redhat.com>, Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>
Cc: qemu block <qemu-block@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Dong Eddie <eddie.dong@intel.com>, Jiang Yunhong <yunhong.jiang@intel.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, Gonglei <arei.gonglei@huawei.com>, Wen Congyang <wency@cn.fujitsu.com>

On 05/20/2016 03:36 PM, Changlong Xie wrote:
> +static void io_write(BlockDriverState *bs, long pattern, int64_t pattern_count,
> +                     int64_t offset, int64_t count, bool expect_failed)
> +{
> +    void *pattern_buf;

Should initialize as NULL to avoid below warnning:

tests/test-replication.c:104:15: error: ‘pattern_buf’ may be used 
uninitialized in this function [-Werror=maybe-uninitialized]
          g_free(pattern_buf);

Will fix in next version.

> +    int ret;
> +
> +    /* 1. alloc pattern buffer */
> +    if (pattern) {
> +        pattern_buf = g_malloc(pattern_count);
> +        memset(pattern_buf, pattern, pattern_count);
> +    }
> +
> +    /* 2. do write */
> +    if (pattern) {
> +        ret = bdrv_write(bs, offset >> 9, (uint8_t *)pattern_buf, count >> 9);
> +    } else {
> +        ret = bdrv_write_zeroes(bs, offset >> 9, count >> 9, 0);
> +    }
> +
> +    /* 3. assert */
> +    if (expect_failed) {
> +        g_assert(ret < 0);
> +    } else {
> +        g_assert(ret >= 0);
> +        g_free(pattern_buf);
> +    }
> +}