All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFT] regulator: tps51632: Fix setting ramp delay
Date: Tue, 31 May 2016 16:47:36 +0530	[thread overview]
Message-ID: <574D72D0.7060303@nvidia.com> (raw)
In-Reply-To: <1464686760.11354.1.camel@ingics.com>


On Tuesday 31 May 2016 02:56 PM, Axel Lin wrote:
> According to the datasheet:
>
> SLEW Register(Address = 07h)
> b7      b6      b5      b4      b3      b2      b1      b0
> 48mV/us 42mV/us 36mV/us 30mV/us 24mV/us 18mV/us 12mV/us 6mV/us
>
> Current code does not set correct slew rate in some cases:
> e.g. Assume ramp_delay is 10000, current code sets slew register to 6mV/us.
> Fix the logic to set slew register.
>

Setting register to nearest faster ramp side, the change looks fine.

Acked-by: Laxman Dewangan <ldewangan@nvidia.com>

  reply	other threads:[~2016-05-31 11:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31  9:26 [PATCH RFT] regulator: tps51632: Fix setting ramp delay Axel Lin
2016-05-31 11:17 ` Laxman Dewangan [this message]
2016-05-31 17:46 ` Applied "regulator: tps51632: Fix setting ramp delay" to the regulator tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=574D72D0.7060303@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=axel.lin@ingics.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.