From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7nDa-0004P5-7E for qemu-devel@nongnu.org; Tue, 31 May 2016 13:12:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7nDW-0004hC-0z for qemu-devel@nongnu.org; Tue, 31 May 2016 13:12:37 -0400 References: <1464712565-14857-1-git-send-email-lvivier@redhat.com> <1464712565-14857-2-git-send-email-lvivier@redhat.com> From: Eric Blake Message-ID: <574DC600.8010904@redhat.com> Date: Tue, 31 May 2016 11:12:32 -0600 MIME-Version: 1.0 In-Reply-To: <1464712565-14857-2-git-send-email-lvivier@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PVxC2lgIvkUj5Q5tDtt7n8aR7hJ3KWgAD" Subject: Re: [Qemu-devel] [PATCH 01/16] coccinelle: use macro DIV_ROUND_UP instead of (((n) + (d) - 1) /(d)) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , qemu-trivial@nongnu.org, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PVxC2lgIvkUj5Q5tDtt7n8aR7hJ3KWgAD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/31/2016 10:35 AM, Laurent Vivier wrote: > sample from http://coccinellery.org/ >=20 > Signed-off-by: Laurent Vivier > --- > scripts/coccinelle/round.cocci | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 scripts/coccinelle/round.cocci >=20 > diff --git a/scripts/coccinelle/round.cocci b/scripts/coccinelle/round.= cocci > new file mode 100644 > index 0000000..ed06773 > --- /dev/null > +++ b/scripts/coccinelle/round.cocci > @@ -0,0 +1,19 @@ > +// Use macro DIV_ROUND_UP instead of (((n) + (d) - 1) /(d)) > +@@ > +expression e1; > +expression e2; > +@@ > +( > +- ((e1) + e2 - 1) / (e2) > ++ DIV_ROUND_UP(e1,e2) Should this also cover things like: ((e1) & e2) / (e2 + 1) or with bit-shifts in place of division? I don't know how much coccinelle can spot other issues (at least until I review the rest of your series), but at any rate your patch looks like a good first start. I also like the fact that we are committing the script into the repo, so that we can reuse it to catch future additions of the open-coded forms. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --PVxC2lgIvkUj5Q5tDtt7n8aR7hJ3KWgAD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXTcYAAAoJEKeha0olJ0NqwbsIAJ2eRqfJJ6ZNkA+RP1KI8OFa 4D7Qgh+g9DlRzDES+8tUTlQTyRrhWs6HH3aMzv87Cf8g6X7x9+OVnXrN0kwJ0TGT CZIFDo9FfBxfui1sjhv0uPC6aIaznrggi5vp2VTB4KujgrGj0Mt2kONocPho+VP3 kWUxyNJxTTnj9b0AwWib7mEPyV+RwhRZTVj3Op2XsCvK04uY5tMmrUVB9DOgelTf cAJPyTebTiC8O7j12aoMQQ9qDa0jfKksooPm1MpmPnwLyKiyNCnW5hGaPkGDGvrK 8yG9zNJ2JewUAdEtrCRlXAtAvV4ASBhWRqnfHQIWezB+0aTcGgW5Je6WwtALK7k= =t5+Q -----END PGP SIGNATURE----- --PVxC2lgIvkUj5Q5tDtt7n8aR7hJ3KWgAD--