From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756090AbcEaT1c (ORCPT <rfc822;w@1wt.eu>);
	Tue, 31 May 2016 15:27:32 -0400
Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:39398 "EHLO
	e06smtp10.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752045AbcEaT1b (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 31 May 2016 15:27:31 -0400
X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com
X-IBM-MailFrom: borntraeger@de.ibm.com
X-IBM-RcptTo: linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] sysctl: Panic on RCU stall and schedule while
 atomic
To: Daniel Bristot de Oliveira <bristot@redhat.com>,
        linux-kernel@vger.kernel.org
References: <cover.1464652607.git.bristot@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Josh Triplett <josh@joshtriplett.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        "Luis Claudio R. Goncalves" <lgoncalv@redhat.com>
From: Christian Borntraeger <borntraeger@de.ibm.com>
Message-ID: <574DE59C.1040904@de.ibm.com>
Date: Tue, 31 May 2016 21:27:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <cover.1464652607.git.bristot@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-TM-AS-MML: disable
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 16053119-0041-0000-0000-000020721661
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/31/2016 09:07 PM, Daniel Bristot de Oliveira wrote:
> This patch series implements two kernel.panic_on_* like sysctl:
> 
> kernel.panic_on_rcu_stall:
> 	panic() on RCU Stall detection.
> 
> kernel.panic_on_sched_in_atomic:
> 	panic() on schedule while atomic detection.
> 
> These sysctls are useful to capture a vmcore when is not possible
> to recompile the kernel to include the panic() call. For instance
> when supporting enterprise users.
> 
> Daniel Bristot de Oliveira (2):
>   rcu: sysctl: Panic on RCU Stall
>   sched: sysctl: Panic on scheduling while atomic
> 
>  Documentation/sysctl/kernel.txt | 25 +++++++++++++++++++++++++
>  include/linux/kernel.h          |  2 ++
>  kernel/rcu/tree.c               |  8 ++++++++
>  kernel/sched/core.c             |  7 +++++++
>  kernel/sysctl.c                 | 20 ++++++++++++++++++++
>  5 files changed, 62 insertions(+)

Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>

for both changes. I too often had to add manual panics in a test
kernel and reproduce an issue. This will allow to take a (k)dump at a point
in time where the data structures might still explain what happened.
As this is an opt-in nobody, this should not cause any trouble for
people that do not want to take dumps.

Christian