From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756910AbcFABZL (ORCPT ); Tue, 31 May 2016 21:25:11 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:54500 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751375AbcFABZI (ORCPT ); Tue, 31 May 2016 21:25:08 -0400 X-AuditID: cbfee690-f79056d000001327-9d-574e39712904 Message-id: <574E3971.30202@samsung.com> Date: Wed, 01 Jun 2016 10:25:05 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Chen-Yu Tsai , Ulf Hansson , Maxime Ripard Cc: Hans de Goede , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher References: <1464505484-3661-1-git-send-email-wens@csie.org> <1464505484-3661-2-git-send-email-wens@csie.org> In-reply-to: <1464505484-3661-2-git-send-email-wens@csie.org> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsWyRsSkSLfQ0i/c4N1qCYu/k46xW7w5Pp3J YtPja6wWl3fNYbM48r+f0WLrpr3MFsfXhlv8PHSeyYHD4/evSYweGx6tZvV4sukio8eda3vY PDYvqfd4v+8qm8fnTXIB7FFcNimpOZllqUX6dglcGcd+tLIUXOCpONXSy9jA+J+zi5GTQ0LA RGLSwx/MELaYxIV769m6GLk4hARWMErMO3aDEaboydv7jBCJWYwSv19tZYVwHjBK7F9ykA2k ildAQ+Lfjg52EJtFQFVi777HYGPZBHQktn87zgRiiwqESTxYt5cVol5Q4sfkeywgtohAlcT+ p7eZQIYyC6xklJi/6hdYQljAS2LV841Qqw8zSpx8PxVsA6eArcSvQxeAijiAOvQk7l/UAgkz C8hLbF7zlhmkXkLgLbvEr8WvGCEuEpD4NvkQWL2EgKzEpgNQP0tKHFxxg2UCo9gsJDfNQpg6 C8nUBYzMqxhFUwuSC4qT0otM9IoTc4tL89L1kvNzNzECY/L0v2cTdjDeO2B9iFGAg1GJhzfg t2+4EGtiWXFl7iFGU6AjJjJLiSbnAyM/ryTe0NjMyMLUxNTYyNzSTEmc97XUz2AhgfTEktTs 1NSC1KL4otKc1OJDjEwcnFINjD7zrsWVs6kWFXyYEf78XkGl3NFp5vr+stWshl3KNzXSPoh/ j7eosH3i55T/ZeUyv6AtVgmfqz2PTX5588qMP04pn5elqgXVsCjPX+1oO9fAoLA833aKiYTm b97smDgbro6Je9kOqucfj8u4f2BG1DTXsw9eZpbrc+bxHVS9GlJt6O01e/ZbJZbijERDLeai 4kQAfQszu8QCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHIsWRmVeSWpSXmKPExsVy+t9jQd1CS79wg0ufhSz+TjrGbvHm+HQm i02Pr7FaXN41h83iyP9+Routm/YyWxxfG27x89B5JgcOj9+/JjF6bHi0mtXjyaaLjB53ru1h 89i8pN7j/b6rbB6fN8kFsEc1MNpkpCampBYppOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynk Jeam2iq5+AToumXmAB2lpFCWmFMKFApILC5W0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsYcw4 9qOVpeACT8Wpll7GBsb/nF2MnBwSAiYST97eZ4SwxSQu3FvP1sXIxSEkMItR4verrawQzgNG if1LDrKBVPEKaEj829HBDmKzCKhK7N33mBnEZhPQkdj+7TgTiC0qECbxYN1eVoh6QYkfk++x gNgiAlUS+5/eZgIZyiywklFi/qpfYAlhAS+JVc83MkJsO8wocfL9VLANnAK2Er8OXQAq4gDq 0JO4f1ELJMwsIC+xec1b5gmMQHci7JiFUDULSdUCRuZVjBKpBckFxUnpuYZ5qeV6xYm5xaV5 6XrJ+bmbGMFx/0xqB+PBXe6HGAU4GJV4eDME/MKFWBPLiitzDzFKcDArifDamQGFeFMSK6tS i/Lji0pzUosPMZoCA2Eis5Rocj4wJeWVxBsam5gZWRqZG1oYGZsrifM+/r8uTEggPbEkNTs1 tSC1CKaPiYNTqoExJLTb8VW+2LXTFrfYf7QyF7oal/3L7psqvcn6ZH/m7mJjv8qtmZoztSK8 ddQyI+sn7X2/dF3a8S3Tzl6/Gt1lrWRXUveC/7t00sV7K6RO9mo6h1xVeWi4a+vCHNFpIin/ FnbMXlX/+9qnQ64Htv+5XhxXF6X0O1GsslfZO/j25YyAidye8j1KLMUZiYZazEXFiQB4AD2J EQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/29/2016 04:04 PM, Chen-Yu Tsai wrote: > When IS_ERR_VALUE was removed from the mmc core code, it was replaced > with a simple not-zero check. This does not work, as the value checked > is the return value for mmc_select_bus_width, which returns the set > bit width on success. This made eMMC modes higher than HS-DDR unusable. > > Fix this by checking for a positive return value instead. > > Fixes: 287980e49ffc ("remove lots of IS_ERR_VALUE abuses") > Cc: Arnd Bergmann > Signed-off-by: Chen-Yu Tsai Acked-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/mmc/core/mmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c > index c984321d1881..aafb73d080ca 100644 > --- a/drivers/mmc/core/mmc.c > +++ b/drivers/mmc/core/mmc.c > @@ -1276,7 +1276,7 @@ static int mmc_select_hs200(struct mmc_card *card) > * switch to HS200 mode if bus width is set successfully. > */ > err = mmc_select_bus_width(card); > - if (!err) { > + if (err > 0) { > val = EXT_CSD_TIMING_HS200 | > card->drive_strength << EXT_CSD_DRV_STR_SHIFT; > err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, > @@ -1583,7 +1583,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr, > } else if (mmc_card_hs(card)) { > /* Select the desired bus width optionally */ > err = mmc_select_bus_width(card); > - if (!err) { > + if (err > 0) { > err = mmc_select_hs_ddr(card); > if (err) > goto free_card; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: jh80.chung@samsung.com (Jaehoon Chung) Date: Wed, 01 Jun 2016 10:25:05 +0900 Subject: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher In-Reply-To: <1464505484-3661-2-git-send-email-wens@csie.org> References: <1464505484-3661-1-git-send-email-wens@csie.org> <1464505484-3661-2-git-send-email-wens@csie.org> Message-ID: <574E3971.30202@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/29/2016 04:04 PM, Chen-Yu Tsai wrote: > When IS_ERR_VALUE was removed from the mmc core code, it was replaced > with a simple not-zero check. This does not work, as the value checked > is the return value for mmc_select_bus_width, which returns the set > bit width on success. This made eMMC modes higher than HS-DDR unusable. > > Fix this by checking for a positive return value instead. > > Fixes: 287980e49ffc ("remove lots of IS_ERR_VALUE abuses") > Cc: Arnd Bergmann > Signed-off-by: Chen-Yu Tsai Acked-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/mmc/core/mmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c > index c984321d1881..aafb73d080ca 100644 > --- a/drivers/mmc/core/mmc.c > +++ b/drivers/mmc/core/mmc.c > @@ -1276,7 +1276,7 @@ static int mmc_select_hs200(struct mmc_card *card) > * switch to HS200 mode if bus width is set successfully. > */ > err = mmc_select_bus_width(card); > - if (!err) { > + if (err > 0) { > val = EXT_CSD_TIMING_HS200 | > card->drive_strength << EXT_CSD_DRV_STR_SHIFT; > err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, > @@ -1583,7 +1583,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr, > } else if (mmc_card_hs(card)) { > /* Select the desired bus width optionally */ > err = mmc_select_bus_width(card); > - if (!err) { > + if (err > 0) { > err = mmc_select_hs_ddr(card); > if (err) > goto free_card; >