From: Lars-Peter Clausen <lars@metafoo.de>
To: Alison Schofield <amsfield22@gmail.com>, jic23@kernel.org
Cc: Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/7] iio: adc: ad7791: claim direct mode when writing frequency
Date: Wed, 1 Jun 2016 21:10:28 +0200 [thread overview]
Message-ID: <574F3324.8020904@metafoo.de> (raw)
In-Reply-To: <20160601043541.GA9875@d830.WORKGROUP>
On 06/01/2016 06:35 AM, Alison Schofield wrote:
> Driver was checking for direct mode and trying to lock it, but
> left a gap where mode could change before the desired operation.
> Use iio_device_claim_direct_mode() to guarantee device stays in
> direct mode.
>
> Refactor function to clarify look-up followed by lock sequence.
>
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@gmail.com>
Looks good, thanks.
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
next prev parent reply other threads:[~2016-06-01 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 4:35 [PATCH v2 2/7] iio: adc: ad7791: claim direct mode when writing frequency Alison Schofield
2016-06-01 19:10 ` Lars-Peter Clausen [this message]
2016-06-03 12:13 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574F3324.8020904@metafoo.de \
--to=lars@metafoo.de \
--cc=Michael.Hennerich@analog.com \
--cc=amsfield22@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.