From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 2/2] drm/i915/psr: Add debugfs support to force toggling PSR1/2 mode. Date: Wed, 8 Aug 2018 11:01:53 +0200 Message-ID: <574acffa-2904-016c-3e6a-49afad8a6d2e@linux.intel.com> References: <1532755389.7639.59.camel@intel.com> <20180731133559.6892-1-maarten.lankhorst@linux.intel.com> <20180731133559.6892-2-maarten.lankhorst@linux.intel.com> <29f688e9b572e638431e73407c362a8103b8c4c1.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2ED396E005 for ; Wed, 8 Aug 2018 09:02:00 +0000 (UTC) In-Reply-To: <29f688e9b572e638431e73407c362a8103b8c4c1.camel@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: dhinakaran.pandiyan@intel.com, intel-gfx@lists.freedesktop.org Cc: Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T3AgMDgtMDgtMTggb20gMDM6MzUgc2NocmVlZiBEaGluYWthcmFuIFBhbmRpeWFuOgo+IE9uIFR1 ZSwgMjAxOC0wNy0zMSBhdCAxNTozNSArMDIwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4+ IFRoaXMgd2lsbCBtYWtlIGl0IGVhc2llciB0byB0ZXN0IFBTUjEgb24gUFNSMiBjYXBhYmxlIGVE UCBtYWNoaW5lcy4KPiBUaGFua3MgZm9yIHdyaXRpbmcgdGhpcyBwYXRjaCwgd2UgY2FuIG1ha2Ug dXNlIG9mIHRoaXMgdG8gZml4IGZhaWx1cmVzCj4gb24gUFNSMiBtYWNoaW5lcyBpbiBDSS4KPgo+ PiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGlu dXguaW50ZWwuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2Lmgg IHwgIDIgKysKPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jIHwgMjcgKysrKysr KysrKysrKysrKysrKysrKysrLS0tCj4+ICAyIGZpbGVzIGNoYW5nZWQsIDI2IGluc2VydGlvbnMo KyksIDMgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2Rydi5oCj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiBpbmRl eCBlZjA0YjZjZDc4NjMuLjA3NzgzYjllNzk2MCAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Ry di5oCj4+IEBAIC02MTcsNiArNjE3LDggQEAgc3RydWN0IGk5MTVfcHNyIHsKPj4gICNkZWZpbmUg STkxNV9QU1JfREVCVUdfREVGQVVMVAkoMCA8PCAxKQo+PiAgI2RlZmluZSBJOTE1X1BTUl9ERUJV R19ESVNBQkxFCSgxIDw8IDEpCj4+ICAjZGVmaW5lIEk5MTVfUFNSX0RFQlVHX0VOQUJMRQkoMiA8 PCAxKQo+PiArI2RlZmluZSBJOTE1X1BTUl9ERUJVR19GT1JDRV9QU1IxICgzIDw8IDEpCj4+ICsj ZGVmaW5lIEk5MTVfUFNSX0RFQlVHX0ZPUkNFX1BTUjIgKDQgPDwgMSkKPj4gIAo+PiAgCXUzMiBk ZWJ1ZzsKPj4gIAlib29sIHNpbmtfc3VwcG9ydDsKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3Bzci5jCj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNy LmMKPj4gaW5kZXggNzg0ODgyOTA5NGNhLi40Y2Y0YWM3MDY4ZDAgMTAwNjQ0Cj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3Bzci5jCj4+IEBAIC04MTMsMTkgKzgxMywzOCBAQCBzdGF0aWMgYm9vbCBfX3Bz cl93YWl0X2Zvcl9pZGxlX2xvY2tlZChzdHJ1Y3QKPj4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYpCj4+ICAJcmV0dXJuIGVyciA9PSAwICYmIGRldl9wcml2LT5wc3IuZW5hYmxlZDsKPj4gIH0K Pj4gIAo+PiArc3RhdGljIGJvb2wgc3dpdGNoaW5nX3BzcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsCj4+ICsJCQkgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRl LAo+PiArCQkJICB1MzIgbW9kZSkKPj4gK3sKPj4gKwkvKiBDYW4ndCBzd2l0Y2ggcHNyIHN0YXRl IGFueXdheSBpZiBQU1IyIGlzIG5vdCBzdXBwb3J0ZWQuCj4+ICovCj4+ICsJaWYgKCFjcnRjX3N0 YXRlIHx8ICFjcnRjX3N0YXRlLT5oYXNfcHNyMikKPj4gKwkJcmV0dXJuIGZhbHNlOwo+PiArCj4+ ICsJaWYgKGRldl9wcml2LT5wc3IucHNyMl9lbmFibGVkICYmIG1vZGUgPT0KPj4gSTkxNV9QU1Jf REVCVUdfRk9SQ0VfUFNSMSkKPj4gKwkJcmV0dXJuIHRydWU7Cj4+ICsKPj4gKwlpZiAoIWRldl9w cml2LT5wc3IucHNyMl9lbmFibGVkICYmIG1vZGUgIT0KPj4gSTkxNV9QU1JfREVCVUdfRk9SQ0Vf UFNSMSkKPj4gKwkJcmV0dXJuIHRydWU7Cj4+ICsKPj4gKwlyZXR1cm4gZmFsc2U7Cj4+ICt9Cj4+ ICsKPj4gIGludCBpbnRlbF9wc3Jfc2V0X2RlYnVnZnNfbW9kZShzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYsCj4+ICAJCQkgICAgICAgc3RydWN0IGRybV9tb2Rlc2V0X2FjcXVpcmVf Y3R4ICpjdHgsCj4+ICAJCQkgICAgICAgdTY0IHZhbCkKPj4gIHsKPj4gIAlzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2ID0gJmRldl9wcml2LT5kcm07Cj4+ICAJc3RydWN0IGRybV9jb25uZWN0b3Jfc3Rh dGUgKmNvbm5fc3RhdGU7Cj4+ICsJc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUg PSBOVUxMOwo+PiAgCXN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPj4gIAlzdHJ1Y3QgaW50ZWxfZHAg KmRwOwo+PiAgCWludCByZXQ7Cj4+ICAJYm9vbCBlbmFibGU7Cj4+ICsJdTMyIG1vZGUgPSB2YWwg JiBJOTE1X1BTUl9ERUJVR19NT0RFX01BU0s7Cj4+ICAKPj4gIAlpZiAodmFsICYgfihJOTE1X1BT Ul9ERUJVR19JUlEgfCBJOTE1X1BTUl9ERUJVR19NT0RFX01BU0spCj4+IHx8Cj4+IC0JICAgICh2 YWwgJiBJOTE1X1BTUl9ERUJVR19NT0RFX01BU0spID4KPj4gSTkxNV9QU1JfREVCVUdfRU5BQkxF KSB7Cj4+ICsJICAgIG1vZGUgPiBJOTE1X1BTUl9ERUJVR19GT1JDRV9QU1IyKSB7Cj4+ICAJCURS TV9ERUJVR19LTVMoIkludmFsaWQgZGVidWcgbWFzayAlbGx4XG4iLCB2YWwpOwo+PiAgCQlyZXR1 cm4gLUVJTlZBTDsKPj4gIAl9Cj4+IEBAIC04NDMsNyArODYyLDggQEAgaW50IGludGVsX3Bzcl9z ZXRfZGVidWdmc19tb2RlKHN0cnVjdAo+PiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4g IAkJaWYgKHJldCkKPj4gIAkJCXJldHVybiByZXQ7Cj4+ICAKPj4gLQkJcmV0ID0gd2FpdF9mb3Jf Y29tcGxldGlvbl9pbnRlcnJ1cHRpYmxlKCZjcnRjLQo+Pj4gc3RhdGUtPmNvbW1pdC0+aHdfZG9u ZSk7Cj4+ICsJCWNydGNfc3RhdGUgPSB0b19pbnRlbF9jcnRjX3N0YXRlKGNydGMtPnN0YXRlKTsK Pj4gKwkJcmV0ID0gd2FpdF9mb3JfY29tcGxldGlvbl9pbnRlcnJ1cHRpYmxlKCZjcnRjX3N0YXRl LQo+Pj4gYmFzZS5jb21taXQtPmh3X2RvbmUpOwo+PiAgCX0gZWxzZQo+PiAgCQlyZXQgPSB3YWl0 X2Zvcl9jb21wbGV0aW9uX2ludGVycnVwdGlibGUoJmNvbm5fc3RhdGUtCj4+PiBjb21taXQtPmh3 X2RvbmUpOwo+PiAgCj4+IEBAIC04NTYsMTAgKzg3NiwxMSBAQCBpbnQgaW50ZWxfcHNyX3NldF9k ZWJ1Z2ZzX21vZGUoc3RydWN0Cj4+IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiAgCj4+ ICAJZW5hYmxlID0gcHNyX2dsb2JhbF9lbmFibGVkKHZhbCk7Cj4+ICAKPj4gLQlpZiAoIWVuYWJs ZSkKPj4gKwlpZiAoIWVuYWJsZSB8fCBzd2l0Y2hpbmdfcHNyKGRldl9wcml2LCBjcnRjX3N0YXRl LCBtb2RlKSkKPj4gIAkJaW50ZWxfcHNyX2Rpc2FibGVfbG9ja2VkKGRldl9wcml2LT5wc3IuZHAp Owo+PiAgCj4+ICAJZGV2X3ByaXYtPnBzci5kZWJ1ZyA9IHZhbDsKPj4gKwlkZXZfcHJpdi0+cHNy LnBzcjJfZW5hYmxlZCA9IG1vZGUgIT0KPj4gSTkxNV9QU1JfREVCVUdfRk9SQ0VfUFNSMSAmJiBj cnRjX3N0YXRlLT5oYXNfcHNyMjsKPiBjcnRjX3N0YXRlIGNhbiBiZSBOVUxMLgpSaWdodCwgd2ls bCBmaXguCj4KPj4gIAlpbnRlbF9wc3JfaXJxX2NvbnRyb2woZGV2X3ByaXYsIGRldl9wcml2LT5w c3IuZGVidWcgJgo+PiBJOTE1X1BTUl9ERUJVR19JUlEpOwo+PiAgCj4+ICAJaWYgKGRldl9wcml2 LT5wc3IucHJlcGFyZWQgJiYgZW5hYmxlKQo+Cj4gSWYgYSBtb2Rlc2V0IHdhcyBkb25lIGFmdGVy IHdyaXRpbmcgSTkxNV9QU1JfREVCVUdfRk9SQ0VfUFNSMSwgd2UnbGwKPiBzdGlsbCBlbmQgdXAg ZW5hYmxpbmcgUFNSMi4gQ2hlY2sgZm9yIGRlYnVnIGZsYWdzIGluIGludGVsX3Bzcl9lbmFibGUo KQo+ID8KSG1tLi4gZ29vZCBwb2ludCwgd2lsbCBhZGQgdGhlIHNhbWUgY2hlY2sgdGhlcmUuCgp+ TWFhcnRlbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK