From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11FFCC2D0A3 for ; Mon, 9 Nov 2020 09:22:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AED6E20731 for ; Mon, 9 Nov 2020 09:22:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="Vz0Quq7q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728947AbgKIJWZ (ORCPT ); Mon, 9 Nov 2020 04:22:25 -0500 Received: from mx2.suse.de ([195.135.220.15]:46834 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727645AbgKIJWZ (ORCPT ); Mon, 9 Nov 2020 04:22:25 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1604913744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/LbvQ6EGRcjc+nWt0Yl43V5fnXQ1+qx1LE+fiYxqpRo=; b=Vz0Quq7qpPRoVcynQQslyihvuJgkS6c4ZNbpycKoARnm0YxeYKLVRzRkrgsXJEECMUS13D pS4aez44X7rYd1xY+8bq3Iezvnbf7KC9T1JeNGzzZ+DFvyBlzYYml80dE1w+9jO2XhjR2S e5sdk5MhJv8EkZqs1CB5IpLdkiWslic= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F26A5AC1F; Mon, 9 Nov 2020 09:22:23 +0000 (UTC) Message-ID: <574f338f6f0b81fe1e4109f74c6dfcb45aca0d53.camel@suse.com> Subject: Re: [PATCH] usb/mos7720: process deferred urbs in a workqueue From: Oliver Neukum To: Davidlohr Bueso , Johan Hovold Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Davidlohr Bueso Date: Mon, 09 Nov 2020 10:22:16 +0100 In-Reply-To: <20201106061713.lgghl4xnvdmkvges@linux-p48b.lan> References: <20201102211450.5722-1-dave@stgolabs.net> <20201103204014.3ue37owcras6cx7p@linux-p48b.lan> <20201104110657.GW4085@localhost> <20201104162534.GY4085@localhost> <20201105001307.lelve65nif344cfs@linux-p48b.lan> <20201105082540.GA4085@localhost> <20201106061713.lgghl4xnvdmkvges@linux-p48b.lan> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, den 05.11.2020, 22:17 -0800 schrieb Davidlohr Bueso: > @@ -1888,16 +1732,8 @@ static void mos7720_release(struct usb_serial *serial) > usb_set_serial_data(serial, NULL); > mos_parport->serial = NULL; > > - /* if tasklet currently scheduled, wait for it to complete */ > - tasklet_kill(&mos_parport->urb_tasklet); > - > - /* unlink any urbs sent by the tasklet */ > - spin_lock_irqsave(&mos_parport->listlock, flags); > - list_for_each_entry(urbtrack, > - &mos_parport->active_urbs, > - urblist_entry) > - usb_unlink_urb(urbtrack->urb); > - spin_unlock_irqrestore(&mos_parport->listlock, flags); > + /* if work is currently scheduled, wait for it to complete */ > + cancel_work_sync(&mos_parport->work); > parport_del_port(mos_parport->pp); > > kref_put(&mos_parport->ref_count, destroy_mos_parport); Hi, do you really want to cancel as opposed to wait for work in release()? Regards Oliver