From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kulkarni, Vandita" Subject: Re: [RFC 1/3] drm/i915/icl: Restructure ICL DPLL enable functionality Date: Wed, 19 Sep 2018 17:31:37 +0000 Message-ID: <57510F3E2013164E925CD03ED7512A3B7F3F78FD@BGSMSX107.gar.corp.intel.com> References: <1536908054-2176-1-git-send-email-vandita.kulkarni@intel.com> <1536908054-2176-2-git-send-email-vandita.kulkarni@intel.com> <20180914160655.GJ5565@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 432D589F5B for ; Wed, 19 Sep 2018 17:32:00 +0000 (UTC) In-Reply-To: <20180914160655.GJ5565@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?iso-8859-1?Q?Ville_Syrj=E4l=E4?= Cc: "Nikula, Jani" , "intel-gfx@lists.freedesktop.org" , "Zanoni, Paulo R" List-Id: intel-gfx@lists.freedesktop.org Cgo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2 aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBTZW50OiBGcmlkYXksIFNlcHRlbWJlciAx NCwgMjAxOCA5OjM3IFBNCj4gVG86IEt1bGthcm5pLCBWYW5kaXRhIDx2YW5kaXRhLmt1bGthcm5p QGludGVsLmNvbT4KPiBDYzogaW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZzsgTmlrdWxh LCBKYW5pIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Owo+IFphbm9uaSwgUGF1bG8gUiA8cGF1bG8u ci56YW5vbmlAaW50ZWwuY29tPgo+IFN1YmplY3Q6IFJlOiBbSW50ZWwtZ2Z4XSBbUkZDIDEvM10g ZHJtL2k5MTUvaWNsOiBSZXN0cnVjdHVyZSBJQ0wgRFBMTCBlbmFibGUKPiBmdW5jdGlvbmFsaXR5 Cj4gCj4gT24gRnJpLCBTZXAgMTQsIDIwMTggYXQgMTI6MjQ6MTJQTSArMDUzMCwgVmFuZGl0YSBL dWxrYXJuaSB3cm90ZToKPiA+IEZyb206IE1hZGhhdiBDaGF1aGFuIDxtYWRoYXYuY2hhdWhhbkBp bnRlbC5jb20+Cj4gPgo+ID4gSW4gR2VuMTEsIERQTEwgMCBhbmQgMSBhcmUgc2hhcmVkIGJldHdl ZW4gRERJIGFuZCBEU0kuCj4gPiBNb3N0IG9mIHRoZSBzdGVwcyBmb3IgZW5hYmxpbmcgRFBMTCBh cmUgY29tbW9uIGFjcm9zcyBEREkgYW5kIERTSS4KPiA+IFRoaXMgcGF0Y2ggbWFrZXMgaWNsX2Rw bGxfZW5hYmxlKCkgZ2VuZXJpYyB3aGljaCB3aWxsIGJlIHVzZWQgYnkgYWxsCj4gPiB0aGUgZW5j b2RlcnMuCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogTWFkaGF2IENoYXVoYW4gPG1hZGhhdi5jaGF1 aGFuQGludGVsLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IFZhbmRpdGEgS3Vsa2FybmkgPHZhbmRp dGEua3Vsa2FybmlAaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGRpLmMgICAgICB8IDEyICsrKysrKysrKysrKwo+ID4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RwbGxfbWdyLmMgfCAxOSArKy0tLS0tLS0tLS0tLS0tLS0tCj4gPiBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5oIHwgIDIgKy0KPiA+ICAzIGZpbGVzIGNoYW5n ZWQsIDE1IGluc2VydGlvbnMoKyksIDE4IGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kZGkuYwo+ID4gaW5kZXggY2QwMWEwOS4uMjk0MmEyNCAxMDA2NDQKPiA+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gQEAgLTI4MTAsNiArMjgxMCwxOCBAQCBzdGF0aWMg dm9pZCBpbnRlbF9kZGlfY2xrX3NlbGVjdChzdHJ1Y3QKPiBpbnRlbF9lbmNvZGVyICplbmNvZGVy LAo+ID4gIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+ZHBsbF9sb2NrKTsKPiA+Cj4gPiAgCWlmIChJ U19JQ0VMQUtFKGRldl9wcml2KSkgewo+ID4gKwkJZW51bSBpbnRlbF9kcGxsX2lkIGlkID0gcGxs LT5pbmZvLT5pZDsKPiA+ICsJCWk5MTVfcmVnX3QgZW5hYmxlX3JlZyA9IGljbF9wbGxfaWRfdG9f ZW5hYmxlX3JlZyhpZCk7Cj4gPiArCj4gPiArCQl2YWwgPSBJOTE1X1JFQUQoZW5hYmxlX3JlZyk7 Cj4gPiArCQl2YWwgfD0gUExMX0VOQUJMRTsKPiA+ICsJCUk5MTVfV1JJVEUoZW5hYmxlX3JlZywg dmFsKTsKPiA+ICsKPiA+ICsJCS8qIFRPRE86IHdhaXQgdGltZXMgbWlzc2luZyBmcm9tIHRoZSBz cGVjLiAqLwo+ID4gKwkJaWYgKGludGVsX3dhaXRfZm9yX3JlZ2lzdGVyKGRldl9wcml2LCBlbmFi bGVfcmVnLCBQTExfTE9DSywKPiA+ICsJCQkJCSAgICBQTExfTE9DSywgNSkpCj4gPiArCQkJRFJN X0VSUk9SKCJQTEwgJWQgbm90IGxvY2tlZFxuIiwgaWQpOwo+ID4gKwo+IAo+IEkgZG9uJ3QgcmVh bGx5IHNlZSB3aHkgdGhpcyBjYW4ndCBzdGF5IGluIHRoZSBkcGxsIG1nci4KVGhpcyB3YXMgcGFy dCBvZiBpY2xfcGxsX2VuYWJsZSwgd2hpY2ggZ2V0cyBjYWxsZWQgZm9yIGFsbCBoZG1pLCBkcCBh bmQgbWlwaSBkc2kuCkJ1dCBmb3IgbWlwaSBkc2kgd2UgaGF2ZSBjb3VwbGUgb2YgbW9yZSB0aGlu Z3MgdG8gZG8gYmVmb3JlIHdlIGVuYWJsZSBwbGwuCgpJbiBvcmRlciB0byBrZWVwIGl0IHVuY2hh bmdlZCBmb3Igb3RoZXIgZW5jb2RlcnMgLCBwbGwgZW5hYmxlIHdhcyBtb3ZlZCBoZXJlLgpBbm90 aGVyIHdheSBjb3VsZCBiZSBoYXZlIGFuIGVuY29kZXIgY2hlY2sgaW4gaWNsX3BsbF9lbmFibGUg ZnVuY3Rpb24gYW5kIGRvIHRob3NlIGV4dHJhIHN0ZXBzIGZvciBtaXBpIGRzaSBhbmQgdGhlbiBl bmFibGUgdGhlIHBsbC4KUGxlYXNlIGxldCBtZSBrbm93IHdoYXQgeW91IHRoaW5rIHdvdWxkIGJl IGEgYmV0dGVyIHdheSB0byBkby4KClRoYW5rcywKVmFuZGl0YSAKPiAKPiA+ICAJCWlmIChwb3J0 ID49IFBPUlRfQykKPiA+ICAJCQlJOTE1X1dSSVRFKERESV9DTEtfU0VMKHBvcnQpLAo+ID4gIAkJ CQkgICBpY2xfcGxsX3RvX2RkaV9wbGxfc2VsKGVuY29kZXIsIHBsbCkpOyBkaWZmIC0tZ2l0Cj4g PiBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMKPiA+IGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYwo+ID4gaW5kZXggZTZjYWM5Mi4uMzZlZDE1NSAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMKPiA+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMKPiA+IEBAIC0yOTMw LDcgKzI5MzAsNyBAQCBzdGF0aWMgYm9vbCBpY2xfY2FsY19tZ19wbGxfc3RhdGUoc3RydWN0Cj4g aW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiA+ICAJcmV0dXJuIHBsbDsKPiA+ICB9Cj4g Pgo+ID4gLXN0YXRpYyBpOTE1X3JlZ190IGljbF9wbGxfaWRfdG9fZW5hYmxlX3JlZyhlbnVtIGlu dGVsX2RwbGxfaWQgaWQpCj4gPiAraTkxNV9yZWdfdCBpY2xfcGxsX2lkX3RvX2VuYWJsZV9yZWco ZW51bSBpbnRlbF9kcGxsX2lkIGlkKQo+ID4gIHsKPiA+ICAJc3dpdGNoIChpZCkgewo+ID4gIAlk ZWZhdWx0Ogo+ID4gQEAgLTMxMTksMjIgKzMxMTksNyBAQCBzdGF0aWMgdm9pZCBpY2xfcGxsX2Vu YWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZQo+ICpkZXZfcHJpdiwKPiA+ICAJZGVmYXVsdDoK PiA+ICAJCU1JU1NJTkdfQ0FTRShpZCk7Cj4gPiAgCX0KPiA+IC0KPiA+IC0JLyoKPiA+IC0JICog RFZGUyBwcmUgc2VxdWVuY2Ugd291bGQgYmUgaGVyZSwgYnV0IGluIG91ciBkcml2ZXIgdGhlIGNk Y2xrIGNvZGUKPiA+IC0JICogcGF0aHMgc2hvdWxkIGFscmVhZHkgYmUgc2V0dGluZyB0aGUgYXBw cm9wcmlhdGUgdm9sdGFnZSwgaGVuY2Ugd2UgZG8KPiA+IC0JICogbm90aGlnbiBoZXJlLgo+ID4g LQkgKi8KPiA+IC0KPiA+IC0JdmFsID0gSTkxNV9SRUFEKGVuYWJsZV9yZWcpOwo+ID4gLQl2YWwg fD0gUExMX0VOQUJMRTsKPiA+IC0JSTkxNV9XUklURShlbmFibGVfcmVnLCB2YWwpOwo+ID4gLQo+ ID4gLQlpZiAoaW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsIGVuYWJsZV9yZWcsIFBM TF9MT0NLLCBQTExfTE9DSywKPiA+IC0JCQkJICAgIDEpKSAvKiA2MDB1cyBhY3R1YWxseS4gKi8K PiA+IC0JCURSTV9FUlJPUigiUExMICVkIG5vdCBsb2NrZWRcbiIsIGlkKTsKPiA+IC0KPiA+IC0J LyogRFZGUyBwb3N0IHNlcXVlbmNlIHdvdWxkIGJlIGhlcmUuIFNlZSB0aGUgY29tbWVudCBhYm92 ZS4gKi8KPiA+ICsJLyogRW5jb2RlciBzcGVjaWZpYyBQTEwgZW5hYmxlIHN0ZXBzIGFyZSBhZGRl ZCBpbiBlbmNvZGVyIGZpbGUgKi8KPiA+ICB9Cj4gPgo+ID4gIHN0YXRpYyB2b2lkIGljbF9wbGxf ZGlzYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGRpZmYKPiA+IC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaAo+ID4gYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5oCj4gPiBpbmRleCBiZjBkZThhLi45ZTg5MjY1IDEw MDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaAo+ID4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaAo+ID4gQEAgLTM0NSw1 ICszNDUsNSBAQCB2b2lkIGludGVsX2RwbGxfZHVtcF9od19zdGF0ZShzdHJ1Y3QKPiA+IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LCAgaW50IGljbF9jYWxjX2RwX2NvbWJvX3BsbF9saW5rKHN0 cnVjdAo+IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gIAkJCSAgICAgICB1aW50MzJf dCBwbGxfaWQpOwo+ID4gIGludCBjbmxfaGRtaV9wbGxfcmVmX2Nsb2NrKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdik7Cj4gPiAtCj4gPiAraTkxNV9yZWdfdCBpY2xfcGxsX2lkX3Rv X2VuYWJsZV9yZWcoZW51bSBpbnRlbF9kcGxsX2lkIGlkKTsKPiA+ICAjZW5kaWYgLyogX0lOVEVM X0RQTExfTUdSX0hfICovCj4gPiAtLQo+ID4gMS45LjEKPiA+Cj4gPiBfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPiAKPiAtLQo+IFZpbGxl IFN5cmrDpGzDpAo+IEludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=