From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6425CC2D0EA for ; Wed, 8 Apr 2020 10:01:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37FF220747 for ; Wed, 8 Apr 2020 10:01:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37FF220747 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 83F506E0A6; Wed, 8 Apr 2020 10:01:07 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id B14D66E0A6; Wed, 8 Apr 2020 10:01:06 +0000 (UTC) IronPort-SDR: kGeLy4cCEx12NwoeKxpQe4CR9qH4lIadup5+a3RV7hwRUDjnKHJEYQXxfH3izZ+4j+l4Crj7c8 fy5thOhpGj1w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2020 03:01:06 -0700 IronPort-SDR: zwKDfBW1VAICxh+o1tjJvU7Fh5RuaFLQUkCDECE1qZ+tgXdxH5TGr2xEYkbvW6MHF1DbzIqDFT j5+H/1h56BpQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,357,1580803200"; d="scan'208";a="240252790" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga007.jf.intel.com with ESMTP; 08 Apr 2020 03:01:05 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 8 Apr 2020 03:01:05 -0700 Received: from BGSMSX107.gar.corp.intel.com (10.223.4.191) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 8 Apr 2020 03:01:05 -0700 Received: from BGSMSX108.gar.corp.intel.com ([169.254.8.65]) by BGSMSX107.gar.corp.intel.com ([169.254.9.81]) with mapi id 14.03.0439.000; Wed, 8 Apr 2020 15:30:58 +0530 From: "Kulkarni, Vandita" To: "Nikula, Jani" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" Subject: RE: [PATCH RESEND 4/7] drm/i915/dsc: configure hardware using specified rc_model_size Thread-Topic: [PATCH RESEND 4/7] drm/i915/dsc: configure hardware using specified rc_model_size Thread-Index: AQHWBDVBFWkODEQ6uk+gUxz/liIO16hvEDHw Date: Wed, 8 Apr 2020 10:00:58 +0000 Message-ID: <57510F3E2013164E925CD03ED7512A3B80A8841F@BGSMSX108.gar.corp.intel.com> References: <20200327124229.26461-1-jani.nikula@intel.com> <20200327124229.26461-4-jani.nikula@intel.com> In-Reply-To: <20200327124229.26461-4-jani.nikula@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.223.10.10] MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Nikula, Jani" , "Navare, Manasi D" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > -----Original Message----- > From: Jani Nikula > Sent: Friday, March 27, 2020 6:12 PM > To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Nikula, Jani ; Navare, Manasi D > ; Kulkarni, Vandita > Subject: [PATCH RESEND 4/7] drm/i915/dsc: configure hardware using > specified rc_model_size > > The rc_model_size is specified in the DSC config, and the hardware > programming should respect that instead of hard coding a value of 8192. > > Regardless, the rc_model_size in DSC config is currently hard coded to the > same value, so this should have no impact, other than allowing the use of other > sizes as needed. > > Cc: Manasi Navare > Cc: Vandita Kulkarni > Signed-off-by: Jani Nikula Looks good to me. Reviewed-by: Vandita Kulkarni > --- > drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c > b/drivers/gpu/drm/i915/display/intel_vdsc.c > index 95ad87d4ccb3..1f74b0174b1a 100644 > --- a/drivers/gpu/drm/i915/display/intel_vdsc.c > +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c > @@ -740,7 +740,7 @@ static void intel_dsc_pps_configure(struct > intel_encoder *encoder, > > /* Populate PICTURE_PARAMETER_SET_9 registers */ > pps_val = 0; > - pps_val |= DSC_RC_MODEL_SIZE(DSC_RC_MODEL_SIZE_CONST) | > + pps_val |= DSC_RC_MODEL_SIZE(vdsc_cfg->rc_model_size) | > DSC_RC_EDGE_FACTOR(DSC_RC_EDGE_FACTOR_CONST); > drm_info(&dev_priv->drm, "PPS9 = 0x%08x\n", pps_val); > if (!is_pipe_dsc(crtc_state)) { > -- > 2.20.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85717C2BA1A for ; Wed, 8 Apr 2020 10:01:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63ED620747 for ; Wed, 8 Apr 2020 10:01:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63ED620747 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CD1036EA05; Wed, 8 Apr 2020 10:01:07 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id B14D66E0A6; Wed, 8 Apr 2020 10:01:06 +0000 (UTC) IronPort-SDR: kGeLy4cCEx12NwoeKxpQe4CR9qH4lIadup5+a3RV7hwRUDjnKHJEYQXxfH3izZ+4j+l4Crj7c8 fy5thOhpGj1w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2020 03:01:06 -0700 IronPort-SDR: zwKDfBW1VAICxh+o1tjJvU7Fh5RuaFLQUkCDECE1qZ+tgXdxH5TGr2xEYkbvW6MHF1DbzIqDFT j5+H/1h56BpQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,357,1580803200"; d="scan'208";a="240252790" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga007.jf.intel.com with ESMTP; 08 Apr 2020 03:01:05 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 8 Apr 2020 03:01:05 -0700 Received: from BGSMSX107.gar.corp.intel.com (10.223.4.191) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 8 Apr 2020 03:01:05 -0700 Received: from BGSMSX108.gar.corp.intel.com ([169.254.8.65]) by BGSMSX107.gar.corp.intel.com ([169.254.9.81]) with mapi id 14.03.0439.000; Wed, 8 Apr 2020 15:30:58 +0530 From: "Kulkarni, Vandita" To: "Nikula, Jani" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" Thread-Topic: [PATCH RESEND 4/7] drm/i915/dsc: configure hardware using specified rc_model_size Thread-Index: AQHWBDVBFWkODEQ6uk+gUxz/liIO16hvEDHw Date: Wed, 8 Apr 2020 10:00:58 +0000 Message-ID: <57510F3E2013164E925CD03ED7512A3B80A8841F@BGSMSX108.gar.corp.intel.com> References: <20200327124229.26461-1-jani.nikula@intel.com> <20200327124229.26461-4-jani.nikula@intel.com> In-Reply-To: <20200327124229.26461-4-jani.nikula@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.223.10.10] MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH RESEND 4/7] drm/i915/dsc: configure hardware using specified rc_model_size X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Nikula, Jani" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" > -----Original Message----- > From: Jani Nikula > Sent: Friday, March 27, 2020 6:12 PM > To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Nikula, Jani ; Navare, Manasi D > ; Kulkarni, Vandita > Subject: [PATCH RESEND 4/7] drm/i915/dsc: configure hardware using > specified rc_model_size > > The rc_model_size is specified in the DSC config, and the hardware > programming should respect that instead of hard coding a value of 8192. > > Regardless, the rc_model_size in DSC config is currently hard coded to the > same value, so this should have no impact, other than allowing the use of other > sizes as needed. > > Cc: Manasi Navare > Cc: Vandita Kulkarni > Signed-off-by: Jani Nikula Looks good to me. Reviewed-by: Vandita Kulkarni > --- > drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c > b/drivers/gpu/drm/i915/display/intel_vdsc.c > index 95ad87d4ccb3..1f74b0174b1a 100644 > --- a/drivers/gpu/drm/i915/display/intel_vdsc.c > +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c > @@ -740,7 +740,7 @@ static void intel_dsc_pps_configure(struct > intel_encoder *encoder, > > /* Populate PICTURE_PARAMETER_SET_9 registers */ > pps_val = 0; > - pps_val |= DSC_RC_MODEL_SIZE(DSC_RC_MODEL_SIZE_CONST) | > + pps_val |= DSC_RC_MODEL_SIZE(vdsc_cfg->rc_model_size) | > DSC_RC_EDGE_FACTOR(DSC_RC_EDGE_FACTOR_CONST); > drm_info(&dev_priv->drm, "PPS9 = 0x%08x\n", pps_val); > if (!is_pipe_dsc(crtc_state)) { > -- > 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx