From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752000AbcFFBZn (ORCPT ); Sun, 5 Jun 2016 21:25:43 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:63167 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751733AbcFFBZl (ORCPT ); Sun, 5 Jun 2016 21:25:41 -0400 Subject: Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one memory block To: Will Deacon References: <1464427377-12712-1-git-send-email-thunder.leizhen@huawei.com> <1464427377-12712-3-git-send-email-thunder.leizhen@huawei.com> <574F8DA8.4040503@huawei.com> <20160603094520.GF9915@arm.com> CC: Rob Herring , devicetree , David Daney , Catalin Marinas , Xinwei Hu , Hanjun Guo , linux-kernel , "Robert Richter" , Zefan Li , Tianhong Ding , Grant Likely , "Ganapatrao Kulkarni" , Frank Rowand , linux-arm-kernel From: "Leizhen (ThunderTown)" Message-ID: <5754D0E8.8070009@huawei.com> Date: Mon, 6 Jun 2016 09:24:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160603094520.GF9915@arm.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.23.164] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090204.5754D104.002B,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 362c90a543f2e5509651969985d60e60 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/6/3 17:45, Will Deacon wrote: > On Thu, Jun 02, 2016 at 09:36:40AM +0800, Leizhen (ThunderTown) wrote: >> On 2016/6/2 4:13, Rob Herring wrote: >>> I believe you still need this and not the one above. You only need it >>> within the loop if you return. Otherwise, the last node always need to >>> be put. >> >> OK. Thanks. >> >> Addition with Matthias's suggestion, I will move "return" into this patch, >> so that this of_node_put(np) can be safely removed. > > Do you want to include Kefeng's [1] patches in your series too? We don't > need two sets of related NUMA cleanups :) Yes, It's originally suggested by Joe Perches. > > Will > > [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-June/432715.html > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 From: thunder.leizhen@huawei.com (Leizhen (ThunderTown)) Date: Mon, 6 Jun 2016 09:24:56 +0800 Subject: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one memory block In-Reply-To: <20160603094520.GF9915@arm.com> References: <1464427377-12712-1-git-send-email-thunder.leizhen@huawei.com> <1464427377-12712-3-git-send-email-thunder.leizhen@huawei.com> <574F8DA8.4040503@huawei.com> <20160603094520.GF9915@arm.com> Message-ID: <5754D0E8.8070009@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016/6/3 17:45, Will Deacon wrote: > On Thu, Jun 02, 2016 at 09:36:40AM +0800, Leizhen (ThunderTown) wrote: >> On 2016/6/2 4:13, Rob Herring wrote: >>> I believe you still need this and not the one above. You only need it >>> within the loop if you return. Otherwise, the last node always need to >>> be put. >> >> OK. Thanks. >> >> Addition with Matthias's suggestion, I will move "return" into this patch, >> so that this of_node_put(np) can be safely removed. > > Do you want to include Kefeng's [1] patches in your series too? We don't > need two sets of related NUMA cleanups :) Yes, It's originally suggested by Joe Perches. > > Will > > [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-June/432715.html > > . >