From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751791AbcFFSdz (ORCPT ); Mon, 6 Jun 2016 14:33:55 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:36445 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750914AbcFFSdx (ORCPT ); Mon, 6 Jun 2016 14:33:53 -0400 Subject: Re: [PATCH v4 1/7] mdio: mux: Enhanced MDIO mux framework for integrated multiplexers To: Pramod Kumar , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Catalin Marinas , Will Deacon , Kishon Vijay Abraham I , "David S. Miller" References: <1465216900-11755-1-git-send-email-pramod.kumar@broadcom.com> <1465216900-11755-2-git-send-email-pramod.kumar@broadcom.com> Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org From: Florian Fainelli Message-ID: <5755C20E.5040308@gmail.com> Date: Mon, 6 Jun 2016 11:33:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1465216900-11755-2-git-send-email-pramod.kumar@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/2016 05:41 AM, Pramod Kumar wrote: > An integrated multiplexer uses same address space for > "muxed bus selection" and "generation of mdio transaction" > hence its good to register parent bus from mux driver. > > Hence added a mechanism where mux driver could register a > parent bus and pass it down to framework via mdio_mux_init api. > > Signed-off-by: Pramod Kumar Reviewed-by: Florian Fainelli > diff --git a/include/linux/mdio-mux.h b/include/linux/mdio-mux.h > index a243dbb..61f5b21 100644 > --- a/include/linux/mdio-mux.h > +++ b/include/linux/mdio-mux.h > @@ -10,11 +10,13 @@ > #ifndef __LINUX_MDIO_MUX_H > #define __LINUX_MDIO_MUX_H > #include > +#include You could have added just a forward declaration, this is a pointer to the structure so you don't need the compiler to have full knowledge of the storage type. Not a biggie. -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: f.fainelli@gmail.com (Florian Fainelli) Date: Mon, 6 Jun 2016 11:33:50 -0700 Subject: [PATCH v4 1/7] mdio: mux: Enhanced MDIO mux framework for integrated multiplexers In-Reply-To: <1465216900-11755-2-git-send-email-pramod.kumar@broadcom.com> References: <1465216900-11755-1-git-send-email-pramod.kumar@broadcom.com> <1465216900-11755-2-git-send-email-pramod.kumar@broadcom.com> Message-ID: <5755C20E.5040308@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/06/2016 05:41 AM, Pramod Kumar wrote: > An integrated multiplexer uses same address space for > "muxed bus selection" and "generation of mdio transaction" > hence its good to register parent bus from mux driver. > > Hence added a mechanism where mux driver could register a > parent bus and pass it down to framework via mdio_mux_init api. > > Signed-off-by: Pramod Kumar Reviewed-by: Florian Fainelli > diff --git a/include/linux/mdio-mux.h b/include/linux/mdio-mux.h > index a243dbb..61f5b21 100644 > --- a/include/linux/mdio-mux.h > +++ b/include/linux/mdio-mux.h > @@ -10,11 +10,13 @@ > #ifndef __LINUX_MDIO_MUX_H > #define __LINUX_MDIO_MUX_H > #include > +#include You could have added just a forward declaration, this is a pointer to the structure so you don't need the compiler to have full knowledge of the storage type. Not a biggie. -- Florian