From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752553AbcFFShz (ORCPT ); Mon, 6 Jun 2016 14:37:55 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:36751 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752030AbcFFShx (ORCPT ); Mon, 6 Jun 2016 14:37:53 -0400 Subject: Re: [PATCH v4 4/7] dt: mdio-mux: Add mdio multiplexer driver node To: Pramod Kumar , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Catalin Marinas , Will Deacon , Kishon Vijay Abraham I , "David S. Miller" References: <1465216900-11755-1-git-send-email-pramod.kumar@broadcom.com> <1465216900-11755-5-git-send-email-pramod.kumar@broadcom.com> Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org From: Florian Fainelli Message-ID: <5755C2FE.1090303@gmail.com> Date: Mon, 6 Jun 2016 11:37:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1465216900-11755-5-git-send-email-pramod.kumar@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/2016 05:41 AM, Pramod Kumar wrote: > Add integrated MDIO multiplexer driver node which contains > two mux PCIe bus and one ethernet bus along with phys > lying on these bus. > > Signed-off-by: Pramod Kumar > --- > + mdio_mux_iproc: mdio-mux@6602023c { > + compatible = "brcm,mdio-mux-iproc"; > + reg = <0x6602023c 0x14>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + mdio@0 { > + reg = <0x0>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + pci_phy0: pci-phy@0 { > + compatible = "brcm,ns2-pcie-phy"; > + reg = <0x0>; > + #phy-cells = <0>; > + }; > + }; > + > + mdio@7 { > + reg = <0x7>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + pci_phy1: pci-phy@0 { > + compatible = "brcm,ns2-pcie-phy"; > + reg = <0x0>; > + #phy-cells = <0>; > + }; Are these two PHYs always available in the NS2 SoC, or does that depend on interfaces exposed at the board level? Should not they be flagged with a disabled status property by default and enabled in their respective board files? -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: f.fainelli@gmail.com (Florian Fainelli) Date: Mon, 6 Jun 2016 11:37:50 -0700 Subject: [PATCH v4 4/7] dt: mdio-mux: Add mdio multiplexer driver node In-Reply-To: <1465216900-11755-5-git-send-email-pramod.kumar@broadcom.com> References: <1465216900-11755-1-git-send-email-pramod.kumar@broadcom.com> <1465216900-11755-5-git-send-email-pramod.kumar@broadcom.com> Message-ID: <5755C2FE.1090303@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/06/2016 05:41 AM, Pramod Kumar wrote: > Add integrated MDIO multiplexer driver node which contains > two mux PCIe bus and one ethernet bus along with phys > lying on these bus. > > Signed-off-by: Pramod Kumar > --- > + mdio_mux_iproc: mdio-mux at 6602023c { > + compatible = "brcm,mdio-mux-iproc"; > + reg = <0x6602023c 0x14>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + mdio at 0 { > + reg = <0x0>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + pci_phy0: pci-phy at 0 { > + compatible = "brcm,ns2-pcie-phy"; > + reg = <0x0>; > + #phy-cells = <0>; > + }; > + }; > + > + mdio at 7 { > + reg = <0x7>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + pci_phy1: pci-phy at 0 { > + compatible = "brcm,ns2-pcie-phy"; > + reg = <0x0>; > + #phy-cells = <0>; > + }; Are these two PHYs always available in the NS2 SoC, or does that depend on interfaces exposed at the board level? Should not they be flagged with a disabled status property by default and enabled in their respective board files? -- Florian