From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752139AbcFFSmX (ORCPT ); Mon, 6 Jun 2016 14:42:23 -0400 Received: from mail-pa0-f65.google.com ([209.85.220.65]:36826 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751953AbcFFSmU (ORCPT ); Mon, 6 Jun 2016 14:42:20 -0400 Subject: Re: [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support To: Pramod Kumar , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Catalin Marinas , Will Deacon , Kishon Vijay Abraham I , "David S. Miller" References: <1465216900-11755-1-git-send-email-pramod.kumar@broadcom.com> <1465216900-11755-8-git-send-email-pramod.kumar@broadcom.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Jon Mason From: Florian Fainelli Message-ID: <5755C404.3080502@gmail.com> Date: Mon, 6 Jun 2016 11:42:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1465216900-11755-8-git-send-email-pramod.kumar@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/2016 05:41 AM, Pramod Kumar wrote: > Add PCI Phy support for Broadcom Northstar2 SoCs. This driver uses the > interface from the iproc mdio mux driver to enable the devices > respective phys. > > Reviewed-by: Andrew Lunn > Signed-off-by: Jon Mason > Signed-off-by: Pramod Kumar > --- > drivers/phy/Kconfig | 8 +++ > drivers/phy/Makefile | 2 +- > drivers/phy/phy-bcm-ns2-pcie.c | 115 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 124 insertions(+), 1 deletion(-) > create mode 100644 drivers/phy/phy-bcm-ns2-pcie.c > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index b869b98..01fb93b 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -434,4 +434,12 @@ config PHY_CYGNUS_PCIE > > source "drivers/phy/tegra/Kconfig" > > +config PHY_NS2_PCIE > + tristate "Broadcom Northstar2 PCIe PHY driver" > + depends on OF && MDIO_BUS_MUX_BCM_IPROC > + select GENERIC_PHY > + default ARCH_BCM_IPROC Are not you missing a dependency on PHYLIB too to provide mdio_module_register() etc. (at least make it build)? -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support Date: Mon, 6 Jun 2016 11:42:12 -0700 Message-ID: <5755C404.3080502@gmail.com> References: <1465216900-11755-1-git-send-email-pramod.kumar@broadcom.com> <1465216900-11755-8-git-send-email-pramod.kumar@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jon Mason To: Pramod Kumar , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Catalin Marinas , Will Deacon , Kishon Vijay Abraham I , "David S. Miller" Return-path: In-Reply-To: <1465216900-11755-8-git-send-email-pramod.kumar-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On 06/06/2016 05:41 AM, Pramod Kumar wrote: > Add PCI Phy support for Broadcom Northstar2 SoCs. This driver uses the > interface from the iproc mdio mux driver to enable the devices > respective phys. > > Reviewed-by: Andrew Lunn > Signed-off-by: Jon Mason > Signed-off-by: Pramod Kumar > --- > drivers/phy/Kconfig | 8 +++ > drivers/phy/Makefile | 2 +- > drivers/phy/phy-bcm-ns2-pcie.c | 115 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 124 insertions(+), 1 deletion(-) > create mode 100644 drivers/phy/phy-bcm-ns2-pcie.c > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index b869b98..01fb93b 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -434,4 +434,12 @@ config PHY_CYGNUS_PCIE > > source "drivers/phy/tegra/Kconfig" > > +config PHY_NS2_PCIE > + tristate "Broadcom Northstar2 PCIe PHY driver" > + depends on OF && MDIO_BUS_MUX_BCM_IPROC > + select GENERIC_PHY > + default ARCH_BCM_IPROC Are not you missing a dependency on PHYLIB too to provide mdio_module_register() etc. (at least make it build)? -- Florian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: f.fainelli@gmail.com (Florian Fainelli) Date: Mon, 6 Jun 2016 11:42:12 -0700 Subject: [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support In-Reply-To: <1465216900-11755-8-git-send-email-pramod.kumar@broadcom.com> References: <1465216900-11755-1-git-send-email-pramod.kumar@broadcom.com> <1465216900-11755-8-git-send-email-pramod.kumar@broadcom.com> Message-ID: <5755C404.3080502@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/06/2016 05:41 AM, Pramod Kumar wrote: > Add PCI Phy support for Broadcom Northstar2 SoCs. This driver uses the > interface from the iproc mdio mux driver to enable the devices > respective phys. > > Reviewed-by: Andrew Lunn > Signed-off-by: Jon Mason > Signed-off-by: Pramod Kumar > --- > drivers/phy/Kconfig | 8 +++ > drivers/phy/Makefile | 2 +- > drivers/phy/phy-bcm-ns2-pcie.c | 115 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 124 insertions(+), 1 deletion(-) > create mode 100644 drivers/phy/phy-bcm-ns2-pcie.c > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index b869b98..01fb93b 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -434,4 +434,12 @@ config PHY_CYGNUS_PCIE > > source "drivers/phy/tegra/Kconfig" > > +config PHY_NS2_PCIE > + tristate "Broadcom Northstar2 PCIe PHY driver" > + depends on OF && MDIO_BUS_MUX_BCM_IPROC > + select GENERIC_PHY > + default ARCH_BCM_IPROC Are not you missing a dependency on PHYLIB too to provide mdio_module_register() etc. (at least make it build)? -- Florian