From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAODv-000245-9E for qemu-devel@nongnu.org; Tue, 07 Jun 2016 17:07:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAODt-0007XF-46 for qemu-devel@nongnu.org; Tue, 07 Jun 2016 17:07:42 -0400 References: <1465226212-254093-1-git-send-email-imammedo@redhat.com> <1465226212-254093-3-git-send-email-imammedo@redhat.com> <20160607202544.GF18662@thinpad.lan.raisama.net> From: Eric Blake Message-ID: <57573795.9050600@redhat.com> Date: Tue, 7 Jun 2016 15:07:33 -0600 MIME-Version: 1.0 In-Reply-To: <20160607202544.GF18662@thinpad.lan.raisama.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QSq3gMFkg7AVMWV65C7oPvdi0RIEra2tm" Subject: Re: [Qemu-devel] [PATCH 02/10] target-i386: cpu: move features logic that requires CPUState to realize time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , Igor Mammedov Cc: peter.maydell@linaro.org, mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org, blauwirbel@gmail.com, qemu-arm@nongnu.org, pbonzini@redhat.com, rth@twiddle.net This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QSq3gMFkg7AVMWV65C7oPvdi0RIEra2tm Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/07/2016 02:25 PM, Eduardo Habkost wrote: > [...] >> + /* TODO: convert plus_features & minus_features static vars >> + * to global properties, once broken host_features is fixed >> + */ >=20 > I will rewrite this to: >=20 > /*TODO: cpu->host_features inclurrectly overwrites features Was that supposed to be "incorrectly" or "currently"? > * set using "feat=3Don|off". Once we fix this, we can convert > * plus_features & minus_features to global properties > * inside x86_cpu_parse_featurestr() too. > */ --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QSq3gMFkg7AVMWV65C7oPvdi0RIEra2tm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXVzeVAAoJEKeha0olJ0NqfEkH/07+lRfdyROeDi1vySVM0tLS d4i8UwNlEKOuRWGFlL2+clc+vVhTtt2+A8NMT2hl1y67cq7oMoQYJfVUS5avjZ7C w/L/vFRWbU6/aQhLvYo0n6jxFZh9LZFWM2/IAZ51Cq4m1GJmElVScwj4DjogF4Jm CkBryo9oB4hgKsF+AWb5/ywBei4qeZYSWWYaMmZ8/LRfLFwgYyHAPae8tNavQ1UT R+ltLeWam8KGHRklcpu9Jw60MEJqAgSendLGvLObExI7PD/swrad+y0uwQXusV+U W+/Lyayf3G0Q+Weuofq5nNdbtj5uiecb9eU5ArpIv2XFho4ZRnerHlh5LGA5eZQ= =s2zD -----END PGP SIGNATURE----- --QSq3gMFkg7AVMWV65C7oPvdi0RIEra2tm--