From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757176AbdJPTUo (ORCPT ); Mon, 16 Oct 2017 15:20:44 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:49349 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755395AbdJPTUm (ORCPT ); Mon, 16 Oct 2017 15:20:42 -0400 X-Google-Smtp-Source: ABhQp+TJkdVQ/onIu8b02GC5frn82Eqtho2rVhHH7KvcZ+B+dAIAcsGbu/6V//KAvdEygp09+NaWuQ== Subject: Re: [PATCH v2 1/3] udf: Fix 64-bit sign extension issues affecting blocks > 0x7FFFFFFF To: Jan Kara Cc: Jan Kara , linux-kernel@vger.kernel.org, "Steven J . Magnani" References: <1507816122-19405-1-git-send-email-steve@digidescorp.com> <1507816122-19405-2-git-send-email-steve@digidescorp.com> <20171016141728.GF9762@quack2.suse.cz> From: Steve Magnani Message-ID: <57583a28-5683-a650-7a63-01be73c973df@digidescorp.com> Date: Mon, 16 Oct 2017 14:20:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171016141728.GF9762@quack2.suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jan - On 10/16/2017 09:17 AM, Jan Kara wrote: > ... > If you agree with these changes, I'll update your patch and merge it to my > tree (along with the other two changes which look good to me). > > I think your suggestions are OK. In an ideal world we could work to reduce the many signed/unsigned conversions, which make me dizzy. I think the ones that really cause problems are large unsigned int values which are converted to int and then either to sector_t (except on 32-bit systems without LBDAF) or to unsigned long on 64-bit systems. ------------------------------------------------------------------------  Steven J. Magnani               "I claim this network for MARS!  www.digidescorp.com              Earthling, return my space modulator!"  #include