From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Kaya Subject: Re: [PATCH V6 5/8] vfio: platform: call _RST method when using ACPI Date: Wed, 8 Jun 2016 22:33:57 -0400 Message-ID: <5758D595.5090006@codeaurora.org> References: <1464472878-27176-1-git-send-email-okaya@codeaurora.org> <1464472878-27176-6-git-send-email-okaya@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: kvm@vger.kernel.org, Timur Tabi , Christopher Covington , Jon Masters , eric.auger@linaro.org, ACPI Devel Maling List , Andy Gross , linux-arm-msm@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , Baptiste Reynal , Alex Williamson , Linux Kernel Mailing List List-Id: linux-arm-msm@vger.kernel.org On 6/8/2016 6:31 PM, Rafael J. Wysocki wrote: > On Sun, May 29, 2016 at 12:01 AM, Sinan Kaya wrote: >> The device tree code checks for the presence of a reset driver and calls >> the of_reset function pointer by looking up the reset driver as a module. >> >> ACPI defines _RST method to perform device level reset. After the _RST >> method is executed, the OS can resume using the device. _RST method is >> expected to stop DMA transfers and IRQs. >> >> This patch checks the presence of _RST method and calls the _RST >> method when reset is requested. > > You could check if _RST is present at probe time and store the ACPI > handle of it instead of the HID pointer. > > This way you wouldn't need to repeat that check every time reset is used. > Makes sense. I'll give it a shot. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425086AbcFICeE (ORCPT ); Wed, 8 Jun 2016 22:34:04 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51351 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161396AbcFICeB (ORCPT ); Wed, 8 Jun 2016 22:34:01 -0400 Subject: Re: [PATCH V6 5/8] vfio: platform: call _RST method when using ACPI To: "Rafael J. Wysocki" References: <1464472878-27176-1-git-send-email-okaya@codeaurora.org> <1464472878-27176-6-git-send-email-okaya@codeaurora.org> Cc: kvm@vger.kernel.org, Timur Tabi , Christopher Covington , Jon Masters , eric.auger@linaro.org, ACPI Devel Maling List , Andy Gross , linux-arm-msm@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , Baptiste Reynal , Alex Williamson , Linux Kernel Mailing List From: Sinan Kaya Message-ID: <5758D595.5090006@codeaurora.org> Date: Wed, 8 Jun 2016 22:33:57 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/8/2016 6:31 PM, Rafael J. Wysocki wrote: > On Sun, May 29, 2016 at 12:01 AM, Sinan Kaya wrote: >> The device tree code checks for the presence of a reset driver and calls >> the of_reset function pointer by looking up the reset driver as a module. >> >> ACPI defines _RST method to perform device level reset. After the _RST >> method is executed, the OS can resume using the device. _RST method is >> expected to stop DMA transfers and IRQs. >> >> This patch checks the presence of _RST method and calls the _RST >> method when reset is requested. > > You could check if _RST is present at probe time and store the ACPI > handle of it instead of the HID pointer. > > This way you wouldn't need to repeat that check every time reset is used. > Makes sense. I'll give it a shot. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: okaya@codeaurora.org (Sinan Kaya) Date: Wed, 8 Jun 2016 22:33:57 -0400 Subject: [PATCH V6 5/8] vfio: platform: call _RST method when using ACPI In-Reply-To: References: <1464472878-27176-1-git-send-email-okaya@codeaurora.org> <1464472878-27176-6-git-send-email-okaya@codeaurora.org> Message-ID: <5758D595.5090006@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 6/8/2016 6:31 PM, Rafael J. Wysocki wrote: > On Sun, May 29, 2016 at 12:01 AM, Sinan Kaya wrote: >> The device tree code checks for the presence of a reset driver and calls >> the of_reset function pointer by looking up the reset driver as a module. >> >> ACPI defines _RST method to perform device level reset. After the _RST >> method is executed, the OS can resume using the device. _RST method is >> expected to stop DMA transfers and IRQs. >> >> This patch checks the presence of _RST method and calls the _RST >> method when reset is requested. > > You could check if _RST is present at probe time and store the ACPI > handle of it instead of the HID pointer. > > This way you wouldn't need to repeat that check every time reset is used. > Makes sense. I'll give it a shot. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project