From: Eric Blake <eblake@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
kwolf@redhat.com, cornelia.huck@de.ibm.com, mreitz@redhat.com,
qemu-block@nongnu.org, borntraeger@de.ibm.com
Subject: Re: [Qemu-devel] [PATCH] error: Avoid redudant error_propagate() usage
Date: Thu, 9 Jun 2016 14:54:51 -0600 [thread overview]
Message-ID: <5759D79B.9040509@redhat.com> (raw)
In-Reply-To: <20160609204740.GA18662@thinpad.lan.raisama.net>
[-- Attachment #1: Type: text/plain, Size: 685 bytes --]
On 06/09/2016 02:47 PM, Eduardo Habkost wrote:
> On Thu, Jun 09, 2016 at 05:21:34PM -0300, Eduardo Habkost wrote:
>> This patch simplifies code that uses a local_err variable just to immediately
>> use it for an error_propagate() call.
>
> Please ignore this one. I found a better way to tell Coccinelle
> to do that. Updated Coccinelle patch is below, but I will send
> the actual patch tomorrow.
Cool. Worth sticking these in scripts/coccinelle/ as part of your
commit so that we can rerun them later (and refer to them for ideas when
writing new scripts)?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-06-09 20:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 17:40 [Qemu-devel] [PATCH] error: Remove NULL checks on error_propagate() calls Eduardo Habkost
2016-06-09 19:37 ` Eric Blake
2016-06-09 19:50 ` Eduardo Habkost
2016-06-09 20:11 ` Eric Blake
2016-06-09 20:21 ` Eduardo Habkost
2016-06-09 20:21 ` [Qemu-devel] [PATCH] error: Avoid redudant error_propagate() usage Eduardo Habkost
2016-06-09 20:47 ` Eduardo Habkost
2016-06-09 20:54 ` Eric Blake [this message]
2016-06-09 21:57 ` Eduardo Habkost
2016-06-09 20:57 ` Eric Blake
2016-06-09 21:59 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5759D79B.9040509@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.