From: Jens Axboe <axboe@kernel.dk>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Jens Axboe <axboe@fb.com>, linux-block@vger.kernel.org
Subject: Re: [PATCH] cfq: priority boost on meta/prio marked IO
Date: Thu, 9 Jun 2016 16:05:20 -0600 [thread overview]
Message-ID: <5759E820.1010609@kernel.dk> (raw)
In-Reply-To: <x49mvmuvx2n.fsf@segfault.boston.devel.redhat.com>
On 06/09/2016 04:04 PM, Jeff Moyer wrote:
> Jens Axboe <axboe@kernel.dk> writes:
>
>>> I went and checked, but I don't see it. Where is this?
>>
>> Ah now I see, you're looking at current -git. The patch is against
>> for-4.8/core.
>
> Ah, right, Mike's patches went in.
>
>> Updated version below, dropping REQ_META and changing the naming
>> s/meta/prio.
>>
>> diff --git a/block/blk-core.c b/block/blk-core.c
>> index 32a283eb7274..3cfd67d006fb 100644
>> --- a/block/blk-core.c
>> +++ b/block/blk-core.c
>> @@ -1781,6 +1781,11 @@ get_rq:
>> rw_flags |= REQ_SYNC;
>>
>> /*
>> + * Add in META/PRIO flags, if set, before we get to the IO scheduler
>> + */
>> + rw_flags |= (bio->bi_rw & (REQ_META | REQ_PRIO));
>> +
>> + /*
>
> Do we still need to pass in META here?
We don't have to, but it doesn't really hurt. Frankly, we should pass in
the whole damn thing.
--
Jens Axboe
next prev parent reply other threads:[~2016-06-09 22:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 20:43 [PATCH] cfq: priority boost on meta/prio marked IO Jens Axboe
2016-06-09 15:55 ` Jeff Moyer
2016-06-09 16:00 ` Christoph Hellwig
2016-06-09 16:05 ` Jeff Moyer
2016-06-09 16:20 ` Jens Axboe
2016-06-09 18:31 ` Jeff Moyer
2016-06-09 20:14 ` Jens Axboe
2016-06-09 21:08 ` Jeff Moyer
2016-06-09 21:28 ` Jeff Moyer
2016-06-09 21:36 ` Jens Axboe
2016-06-09 21:41 ` Jens Axboe
2016-06-09 22:04 ` Jeff Moyer
2016-06-09 22:05 ` Jens Axboe [this message]
2016-06-09 22:08 ` Jeff Moyer
2016-06-09 22:15 ` Jens Axboe
2016-06-09 21:47 ` Jeff Moyer
2016-06-09 21:51 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5759E820.1010609@kernel.dk \
--to=axboe@kernel.dk \
--cc=axboe@fb.com \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.