From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932317AbcFJOIP (ORCPT ); Fri, 10 Jun 2016 10:08:15 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:60113 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751698AbcFJOIO (ORCPT ); Fri, 10 Jun 2016 10:08:14 -0400 X-AuditID: cbfec7f5-f792a6d000001302-2a-575ac9cbfef0 Subject: Re: [PATCH v2 4/4] max8903: remove unnecessary malloc failed message print out. To: Chris Lapa References: <1464849897-21527-3-git-send-email-chris@lapa.com.au> <1465561970-18377-1-git-send-email-chris@lapa.com.au> <1465561970-18377-5-git-send-email-chris@lapa.com.au> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org From: Krzysztof Kozlowski Message-id: <575AC9C9.60607@samsung.com> Date: Fri, 10 Jun 2016 16:08:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1465561970-18377-5-git-send-email-chris@lapa.com.au> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCLMWRmVeSWpSXmKPExsVy+t/xa7qnT0aFG8x5zGHx8IyZxfwj51gt Xr8wtLi8aw6bxefeI4wOrB7L5m5m9OjbsorR4/MmuQDmKC6blNSczLLUIn27BK6MyZvWsRac 56zY0tDK1MD4hr2LkZNDQsBE4tOqn4wQtpjEhXvr2boYuTiEBJYySiw53ccE4TxjlHhwbiZY lbBAlMTLTy1MILaIgJJEx+2FLCC2kMBGRon2HRIgNrNAhETng0NgG9gEjCU2L1/CBmLzCmhI 9J14CtbLIqAqMWXWL7BeUaD6Wdt/MEHUCEr8mHwPLM4p4CTxdeFnoDgH0Ew9ifsXtSDGy0ts XvOWeQKjwCwkHbMQqmYhqVrAyLyKUTS1NLmgOCk910ivODG3uDQvXS85P3cTIyRsv+5gXHrM 6hCjAAejEg9vxK7IcCHWxLLiytxDjBIczEoivEuORYUL8aYkVlalFuXHF5XmpBYfYpTmYFES 5525632IkEB6YklqdmpqQWoRTJaJg1OqgbHs1FZu4Yr5L0xO7G3xa4rVZg532a02z2lLWZ40 856tPwWmSp6d0Ts5ZdPMvdOUXh6I+N7zfU/XVe+nB18Ju23lkhC0Tb5ozpnJMP+PSOMBsXdz PP/kPo8RnC7wduve6o+Zu/q1Nm7UEVK3YIhat3+l5uK4aa5BGlLZDXOd9nrN5544+3aFuI0S S3FGoqEWc1FxIgCH8++WVwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/10/2016 02:32 PM, Chris Lapa wrote: > From: Chris Lapa Here and in all other patches (like #1) you need to write something. The commit title could be very short (even non-sentence) and here a little bit longer. E.g.: Title: power: max8903: Remove pointless 'out of memory' error message Body: Remove the error message of memory allocation failure because it is printed by core. Best regards, Krzysztof > Signed-off-by: Chris Lapa > --- > drivers/power/max8903_charger.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/power/max8903_charger.c b/drivers/power/max8903_charger.c > index 20d4b55..d60f9b2 100644 > --- a/drivers/power/max8903_charger.c > +++ b/drivers/power/max8903_charger.c > @@ -246,10 +246,8 @@ static int max8903_probe(struct platform_device *pdev) > int usb_in = 0; > > charger = devm_kzalloc(dev, sizeof(struct max8903_data), GFP_KERNEL); > - if (charger == NULL) { > - dev_err(dev, "Cannot allocate memory.\n"); > + if (!charger) > return -ENOMEM; > - } > > charger->pdata = pdev->dev.platform_data; > if (IS_ENABLED(CONFIG_OF) && !charger->pdata && dev->of_node) { >