From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBV7G-0005df-Uv for qemu-devel@nongnu.org; Fri, 10 Jun 2016 18:41:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBV7E-00037G-TQ for qemu-devel@nongnu.org; Fri, 10 Jun 2016 18:41:25 -0400 References: <1465574722-27656-1-git-send-email-kwolf@redhat.com> <1465574722-27656-7-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <575B420C.70607@redhat.com> Date: Fri, 10 Jun 2016 16:41:16 -0600 MIME-Version: 1.0 In-Reply-To: <1465574722-27656-7-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CMCi2fuvWEXENTVfbUM6OmH8HJb5vr7sS" Subject: Re: [Qemu-devel] [PATCH 6/6] block: Remove bs->zero_beyond_eof List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, qemu-devel@nongnu.org, famz@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CMCi2fuvWEXENTVfbUM6OmH8HJb5vr7sS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/10/2016 10:05 AM, Kevin Wolf wrote: > It is always true for open images now. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 2 -- > block/io.c | 51 +++++++++++++++++++++------------------= -------- > include/block/block_int.h | 3 --- > 3 files changed, 23 insertions(+), 33 deletions(-) >=20 > +++ b/block/io.c > @@ -1000,40 +1000,35 @@ static int coroutine_fn bdrv_aligned_preadv(Blo= ckDriverState *bs, > } > =20 > /* Forward the request to the BlockDriver */ > - if (!bs->zero_beyond_eof) { > - ret =3D bdrv_driver_preadv(bs, offset, bytes, qiov, 0); > - } else { > - /* Read zeros after EOF */ > - int64_t total_bytes, max_bytes; > + int64_t total_bytes, max_bytes; This declaration is now in the middle of the function. Shouldn't you hoist it to the beginning? That's minor enough to fix on pull request, so: Reviewed-by: Eric Blake I'll rebase my pending byte-based BlockLimits series on top of this. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CMCi2fuvWEXENTVfbUM6OmH8HJb5vr7sS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXW0IMAAoJEKeha0olJ0NqWpIIAJN/fpaPzHbiWg18yKpfu5IE AqGWq00My5tCKJLJQmEmTyVx0f7X7DPPU309KE24FTaqhRMoNsXCDqWVjwjfaZUd XPnC5E20EDhCOo0clMj1ep0/P5JeSs4yN6B6F5LG5Jl0rL9Z7qLmYUYk5auxVxqU E3d69Of6QFeXuL+PSGc1qXhq7yULJAUgUH0aG4PU1dEd2Qj0AqMpi8J1A/n5nYxG ASVF4WCaDfgnmTZgT2lX/ak1LhZG+vq0MOTCEyjpDaLultK48wPoU4Mea1f2oA70 +znPURh6JimxGP23FILji3KT818vFOqTi8ghJtpr6LbTK3+LLW9NVyxRVuk4mDQ= =FVb5 -----END PGP SIGNATURE----- --CMCi2fuvWEXENTVfbUM6OmH8HJb5vr7sS--