From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <axboe@kernel.dk>
Subject: Re: fio signal 11
References: <BN3PR0401MB1457415455A5B0CEFB84447DF75F0@BN3PR0401MB1457.namprd04.prod.outlook.com>
 <CALjAwxhv8pCLJe0uT6PX1r7g4Mu=d8gA19VUFu0pUE9LkHTkrw@mail.gmail.com>
 <BN3PR0401MB145737C5D3670374BE0D29E5F7500@BN3PR0401MB1457.namprd04.prod.outlook.com>
 <575CCF51.8020704@kernel.dk> <575CD738.1050505@kernel.dk>
 <BN3PR0401MB1457AD48DF8406D550343DC6F7530@BN3PR0401MB1457.namprd04.prod.outlook.com>
 <575EF50D.5010005@kernel.dk>
 <BN3PR0401MB14579231CA6ACFBD645161A1F7530@BN3PR0401MB1457.namprd04.prod.outlook.com>
 <BN3PR0401MB1457DFB9C81F6B6594A0F71CF7530@BN3PR0401MB1457.namprd04.prod.outlook.com>
 <575F0824.2050304@kernel.dk>
From: Jens Axboe <axboe@kernel.dk>
Message-ID: <575F0AB9.4090801@kernel.dk>
Date: Mon, 13 Jun 2016 13:34:17 -0600
MIME-Version: 1.0
In-Reply-To: <575F0824.2050304@kernel.dk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Jeff Furlong <jeff.furlong@hgst.com>, Sitsofe Wheeler <sitsofe@gmail.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>, Jan Kara <jack@suse.cz>
List-ID: <fio@vger.kernel.org>

On 06/13/2016 01:23 PM, Jens Axboe wrote:
> On 06/13/2016 01:21 PM, Jeff Furlong wrote:
>> I took the fio 2.11 release and applied patch
>> 356014ff351c6eb69339652650af5f6af72e5c22 but it only created a
>> different error:
>>
>> [New LWP 131047]
>> [New LWP 131030]
>> [Thread debugging using libthread_db enabled]
>> Using host libthread_db library "/lib64/libthread_db.so.1".
>> Core was generated by `fio --name=test_job --ioengine=libaio
>> --direct=1 --rw=write --io'.
>> Program terminated with signal 11, Segmentation fault.
>> #0  __flist_del (next=0x0, prev=0x0) at flist.h:86
>> 86        next->prev = prev;
>> (gdb) bt
>> #0  __flist_del (next=0x0, prev=0x0) at flist.h:86
>> #1  flist_del_init (entry=0xd609c0) at flist.h:109
>> #2  flush_log (log=<optimized out>, do_append=<optimized out>) at
>> iolog.c:989
>> #3  0x0000000000457a08 in finish_log (td=td@entry=0x7f4f0fb1f000,
>> log=0x7f4f23e04ad0, trylock=1) at iolog.c:1011
>> #4  0x0000000000457be5 in __write_log (try=<optimized out>,
>> log=<optimized out>, td=0x7f4f0fb1f000) at iolog.c:1309
>> #5  write_bandw_log (td=0x7f4f0fb1f000, try=<optimized out>,
>> unit_log=<optimized out>) at iolog.c:1377
>> #6  0x0000000000457efc in td_writeout_logs (unit_logs=false,
>> td=0x7f4f0fb1f000) at iolog.c:1440
>> #7  fio_writeout_logs (unit_logs=unit_logs@entry=false) at iolog.c:1461
>> #8  0x0000000000466a67 in helper_thread_main (data=0x7f4f23e04d90) at
>> helper_thread.c:135
>> #9  0x00007f4f25a5edf5 in start_thread () from /lib64/libpthread.so.0
>> #10 0x00007f4f255881ad in clone () from /lib64/libc.so.6
>
> Hang on, I think I know what the issue is. Just now running a test to
> prove that the fix is correct, then I'll commit it and reply.

Try current -git, I committed this:

http://git.kernel.dk/cgit/fio/commit/?id=1eb467fb0d2fc2ab41f12d9537184fc6ae95b48a

Hopefully that'll be the last logging bug, after it got rewritten...

-- 
Jens Axboe