From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCYHM-0001sU-BS for qemu-devel@nongnu.org; Mon, 13 Jun 2016 16:16:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCYHL-00051f-BN for qemu-devel@nongnu.org; Mon, 13 Jun 2016 16:16:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCYHL-00051b-2j for qemu-devel@nongnu.org; Mon, 13 Jun 2016 16:16:11 -0400 References: <1464686130-12265-1-git-send-email-den@openvz.org> <1464686130-12265-8-git-send-email-den@openvz.org> <20160613131133.GG27781@stefanha-x1.localdomain> From: Eric Blake Message-ID: <575F1488.2020406@redhat.com> Date: Mon, 13 Jun 2016 14:16:08 -0600 MIME-Version: 1.0 In-Reply-To: <20160613131133.GG27781@stefanha-x1.localdomain> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jt26Gs5entFxcLOa4hMOS0Tp7SFTrgLhN" Subject: Re: [Qemu-devel] [PATCH 07/11] block: optimization blk_pwrite_compressed() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , "Denis V. Lunev" Cc: qemu-devel@nongnu.org, Pavel Butsykin , Jeff Cody , Markus Armbruster , John Snow , Kevin Wolf This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jt26Gs5entFxcLOa4hMOS0Tp7SFTrgLhN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/13/2016 07:11 AM, Stefan Hajnoczi wrote: > On Tue, May 31, 2016 at 12:15:26PM +0300, Denis V. Lunev wrote: >> diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-bac= kend.h >> index 57df069..3d7b446 100644 >> --- a/include/sysemu/block-backend.h >> +++ b/include/sysemu/block-backend.h >> @@ -205,6 +205,9 @@ int coroutine_fn blk_co_pwrite_zeroes(BlockBackend= *blk, int64_t offset, >> int count, BdrvRequestFlags fla= gs); >> int blk_pwrite_compressed(BlockBackend *blk, int64_t offset, const vo= id *buf, >> int count); >> +int coroutine_fn blk_co_pwritev_compressed(BlockBackend *blk, int64_t= offset, >> + unsigned int bytes, >> + QEMUIOVector *qiov); >=20 > Perhaps blk_co_pwritev_compressed() isn't necessary at all since > blk_co_pwritev() already exists and has the flags argument: >=20 > int coroutine_fn blk_co_pwritev(BlockBackend *blk, int64_t offset, > unsigned int bytes, QEMUIOVector *qiov, > BdrvRequestFlags flags); Are you arguing that we should have a new BDRV_REQ_COMPRESSED flag that can be set in .supported_write_flags for drivers that know how to do a compressed write? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jt26Gs5entFxcLOa4hMOS0Tp7SFTrgLhN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXXxSJAAoJEKeha0olJ0NqJl4H/igR2sM1kw/9LEvR/tFtFYaR SnlOJf1dpvZtNqh2OAtfLymiOwHxAx1OzZ1zBW1Nl95vubtDA4lTkCONHNUg12Q/ qYBA2n4C0P2GTrzNlXstc9GruOf7rpxVU0IQ7MbyIxfysZ9Tyz7SJ4T+wFKUF/74 KkD59NIXQX/qBWSLFKls9MMsOqNAFbmKbjDE1+U4ki1vAKMvai23SRfLcm1wk3Qz CM1YLRmESnL6PVv59Sn+nMm7gHWChXLR2Jo+N1zvgWPU626u6lDg2thxxoVTVCKR dd8Xge/G3cgUn13DmqBlaaKZXCuCwryJJRmkM7jZRBfFd+DKuxoOYjT44UZ3ifI= =3blo -----END PGP SIGNATURE----- --jt26Gs5entFxcLOa4hMOS0Tp7SFTrgLhN--