From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161392AbcFMUiH (ORCPT ); Mon, 13 Jun 2016 16:38:07 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:18300 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161183AbcFMUiF (ORCPT ); Mon, 13 Jun 2016 16:38:05 -0400 Subject: Re: [PATCH 1/2] liblockdep: Fix compile errors To: Vishal Thanki References: <1465479275-32468-1-git-send-email-vishalthanki@gmail.com> <1465479275-32468-2-git-send-email-vishalthanki@gmail.com> <575B8B20.3060301@oracle.com> Cc: linux-kernel@vger.kernel.org From: Sasha Levin Message-ID: <575F19A9.4070304@oracle.com> Date: Mon, 13 Jun 2016 16:38:01 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/11/2016 04:36 AM, Vishal Thanki wrote: > On Sat, Jun 11, 2016 at 5:53 AM, Sasha Levin wrote: >> On 06/09/2016 09:34 AM, Vishal Thanki wrote: >>> dfaaf3fa0: (Use __jhash_mix() for iterate_chain_key()) >>> Fixed by adding jhash.h with minimal stuff required >> >> Can we, instead of copying it over, include jhash.h directly >> (just like we do for hash.h)? >> >> > That was the first thing I tried, but then it caused more compilation > errors due to nested header dependencies and I ended up taking the > only required stuff. Better ideas are welcome. I just gave it a quick go and didn't see anything beyond needing to take in linux/unaligned/packed_struct.h as well. What sort of errors did you hit? Thanks, Sasha