From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9CBBC433E0 for ; Thu, 16 Jul 2020 10:47:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8428D20760 for ; Thu, 16 Jul 2020 10:47:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="amNvL2EY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8428D20760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jw1Qj-0004Dz-So for qemu-devel@archiver.kernel.org; Thu, 16 Jul 2020 06:47:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jw1Q6-0003or-Ha for qemu-devel@nongnu.org; Thu, 16 Jul 2020 06:47:18 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:34055 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jw1Q4-0005zN-Uh for qemu-devel@nongnu.org; Thu, 16 Jul 2020 06:47:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594896436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=SevTmDn9UpndQEDEs9BpxfH768jRRfjFntodyL7LXKs=; b=amNvL2EYXBcYDnyQIk1NrbGeiPO/NrujuJ1Z6EELn2toKxNLoY12MsIXCRqyQD5K/30fbG ICEJ8hYyorAn5/22hmSXKH1UANXqq8UOSMP+BsVSx1/y/TUSCtyzojp+JfH2emZHsKVc3a dRyrT+Mndl59BF3L4gL2STlAo5FEo3s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-415-eHDL7hbSNPWb2oWnsZ1iDg-1; Thu, 16 Jul 2020 06:47:14 -0400 X-MC-Unique: eHDL7hbSNPWb2oWnsZ1iDg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 49779106B248; Thu, 16 Jul 2020 10:47:13 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-234.ams2.redhat.com [10.36.112.234]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5965460C47; Thu, 16 Jul 2020 10:47:08 +0000 (UTC) Subject: Re: [PATCH v2] tests: qmp-cmd-test: fix memory leak To: Li Qiang , Markus Armbruster References: <20200715154117.15456-1-liq3ea@163.com> <874kq8roev.fsf@dusky.pond.sub.org> <87blkfpz20.fsf@dusky.pond.sub.org> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: <575a07c6-a7fd-c2c8-fcf5-5a34b0b657c9@redhat.com> Date: Thu, 16 Jul 2020 12:47:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=thuth@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/16 04:25:38 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Auger Eric , Li Qiang , Qemu Developers , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 16/07/2020 12.33, Li Qiang wrote: > Markus Armbruster 于2020年7月16日周四 下午5:52写道： >> >> Li Qiang writes: >> >>> Markus Armbruster 于2020年7月16日周四 下午1:59写道： >>>> >>>> Li Qiang writes: >>>> >>>>> Properly free each test response to avoid memory leak and separate >>>>> qtest_qmp() calls with spare lines, in a consistent manner. >>>>> >>>>> Fixes: 5b88849e7b9("tests/qmp-cmd-test: Add >>>>> qmp/object-add-failure-modes" >>>> >>>> The patch also fixes leaks introduced in 442b09b83d and 9fc719b869, >>>> actually. At least it should, but the patch appears to be incomplete. >> >> 442b09b83d was fine, actually. >> >> 9fc719b869 wasn't, and your second patch hunk fixes it. Please add a >> "Fixes: 9fc719b869' line to the commit message. > > Hi Thomas, > > Could you do this minor adjustment? > Add also add Markus's r-b tag. Sure, I'll add it! Thomas