[meta-oe][PATCH] libeigen: allow empty packages

[meta-oe][PATCH] libeigen: allow empty packages

[Vyacheslav Yurkov]

When libeigen is used as a dependency (e.g. in ceres library),
the build is broken because empty packages are not constructed be default

Signed-off-by: Vyacheslav Yurkov <uvv.mail@gmail.com>
---
 meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
index 31a42a9d6..a59320655 100644
--- a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
+++ b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
@@ -18,3 +18,4 @@ FILES_${PN}-dev = "${includedir} ${datadir}/eigen3/cmake ${datadir}/cmake/Module
 # ${PN} is empty so we need to tweak -dev and -dbg package dependencies
 RDEPENDS_${PN}-dev = ""
 RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"
+ALLOW_EMPTY_${PN} = "1"
-- 
2.19.0

Re: [meta-oe][PATCH] libeigen: allow empty packages

[Khem Raj]

Hi Vyacheslav

On Tue, Oct 2, 2018 at 1:33 AM Vyacheslav Yurkov <uvv.mail@gmail.com> wrote:
>
> When libeigen is used as a dependency (e.g. in ceres library),
> the build is broken because empty packages are not constructed be default
>

can you explain a bit more on whats going on? it is a runtime failure
or build time failure.

> Signed-off-by: Vyacheslav Yurkov <uvv.mail@gmail.com>
> ---
>  meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
> index 31a42a9d6..a59320655 100644
> --- a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
> +++ b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
> @@ -18,3 +18,4 @@ FILES_${PN}-dev = "${includedir} ${datadir}/eigen3/cmake ${datadir}/cmake/Module
>  # ${PN} is empty so we need to tweak -dev and -dbg package dependencies
>  RDEPENDS_${PN}-dev = ""
>  RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"
> +ALLOW_EMPTY_${PN} = "1"
> --
> 2.19.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-oe][PATCH] libeigen: allow empty packages

[Vyacheslav Yurkov]

Hi Khem,
It's a build time failure. libeigen is header-only library.
All headers go into dev package, therefore the main package is empty. 
Dependency on the dev package doesn't work, AFAIK, so you have to allow 
empty package for build to succeed. Otherwise I get an error that empty 
packages are not allowed. I reproduced it when I built ceres-solver 
recipe (although I don't use the latest poky). Perhaps I'm missing 
something and it has been solved in the latest poky?

Vyacheslav

On 02/10/2018 17:14, Khem Raj wrote:
> Hi Vyacheslav
>
> On Tue, Oct 2, 2018 at 1:33 AM Vyacheslav Yurkov <uvv.mail@gmail.com> wrote:
>> When libeigen is used as a dependency (e.g. in ceres library),
>> the build is broken because empty packages are not constructed be default
>>
> can you explain a bit more on whats going on? it is a runtime failure
> or build time failure.
>
>> Signed-off-by: Vyacheslav Yurkov <uvv.mail@gmail.com>
>> ---
>>   meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
>> index 31a42a9d6..a59320655 100644
>> --- a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
>> +++ b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
>> @@ -18,3 +18,4 @@ FILES_${PN}-dev = "${includedir} ${datadir}/eigen3/cmake ${datadir}/cmake/Module
>>   # ${PN} is empty so we need to tweak -dev and -dbg package dependencies
>>   RDEPENDS_${PN}-dev = ""
>>   RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"
>> +ALLOW_EMPTY_${PN} = "1"
>> --
>> 2.19.0
>>
>> --
>> _______________________________________________

Re: [meta-oe][PATCH] libeigen: allow empty packages

[Khem Raj]

On Tue, Oct 2, 2018 at 10:52 AM Vyacheslav Yurkov <uvv.mail@gmail.com> wrote:
>
> Hi Khem,
> It's a build time failure. libeigen is header-only library.
> All headers go into dev package, therefore the main package is empty.
> Dependency on the dev package doesn't work, AFAIK, so you have to allow
> empty package for build to succeed. Otherwise I get an error that empty
> packages are not allowed. I reproduced it when I built ceres-solver
> recipe (although I don't use the latest poky). Perhaps I'm missing
> something and it has been solved in the latest poky?
>

that helps. So lets add this to commit message and send v2, we could then move
ahead with this patch.

> Vyacheslav
>
> On 02/10/2018 17:14, Khem Raj wrote:
> > Hi Vyacheslav
> >
> > On Tue, Oct 2, 2018 at 1:33 AM Vyacheslav Yurkov <uvv.mail@gmail.com> wrote:
> >> When libeigen is used as a dependency (e.g. in ceres library),
> >> the build is broken because empty packages are not constructed be default
> >>
> > can you explain a bit more on whats going on? it is a runtime failure
> > or build time failure.
> >
> >> Signed-off-by: Vyacheslav Yurkov <uvv.mail@gmail.com>
> >> ---
> >>   meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb | 1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
> >> index 31a42a9d6..a59320655 100644
> >> --- a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
> >> +++ b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
> >> @@ -18,3 +18,4 @@ FILES_${PN}-dev = "${includedir} ${datadir}/eigen3/cmake ${datadir}/cmake/Module
> >>   # ${PN} is empty so we need to tweak -dev and -dbg package dependencies
> >>   RDEPENDS_${PN}-dev = ""
> >>   RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"
> >> +ALLOW_EMPTY_${PN} = "1"
> >> --
> >> 2.19.0
> >>
> >> --
> >> _______________________________________________
>