From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCp3Y-0000LO-7W for qemu-devel@nongnu.org; Tue, 14 Jun 2016 10:11:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCp3S-00071X-7v for qemu-devel@nongnu.org; Tue, 14 Jun 2016 10:11:03 -0400 References: <1465911155-19002-1-git-send-email-kwolf@redhat.com> <1465911155-19002-5-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <57601065.30205@redhat.com> Date: Tue, 14 Jun 2016 08:10:45 -0600 MIME-Version: 1.0 In-Reply-To: <1465911155-19002-5-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h1hCG8wB9CEDkgL8tVXKNQP78BRkbbA3s" Subject: Re: [Qemu-devel] [PATCH v2 4/6] raw-posix: Switch to bdrv_co_* interfaces List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: stefanha@redhat.com, famz@redhat.com, mreitz@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --h1hCG8wB9CEDkgL8tVXKNQP78BRkbbA3s Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/14/2016 07:32 AM, Kevin Wolf wrote: > In order to use the modern byte-based .bdrv_co_preadv/pwritev() > interface, this patch switches raw-posix to coroutine-based interfaces > as a first step. In terms of semantics and performance, it doesn't make= > a difference with the existing code whether we go from a coroutine to a= > callback-based interface already in block/io.c or only in linux-aio.c >=20 > As there have been concerns in the past that this change may be a step > in the wrong direction with respect to a possible AIO fast path, the > old callback-based interface for linux-aio is left around and can be > reactivated when a fast path (e.g. directly from virtio-blk dataplane, > bypassing the whole block layer) is implemented. >=20 > Signed-off-by: Kevin Wolf > --- > block/linux-aio.c | 87 +++++++++++++++++++++++++++++++++++++++++------= -------- > block/raw-aio.h | 4 +++ > block/raw-posix.c | 59 +++++++++++++++++-------------------- > 3 files changed, 96 insertions(+), 54 deletions(-) Reviewed-by: Eric Blake > @@ -1957,8 +1952,8 @@ BlockDriver bdrv_file =3D { > .bdrv_co_get_block_status =3D raw_co_get_block_status, > .bdrv_co_pwrite_zeroes =3D raw_co_pwrite_zeroes, > =20 > - .bdrv_aio_readv =3D raw_aio_readv, > - .bdrv_aio_writev =3D raw_aio_writev, > + .bdrv_co_readv =3D raw_co_readv, > + .bdrv_co_writev =3D raw_co_writev, > .bdrv_aio_flush =3D raw_aio_flush, > .bdrv_aio_discard =3D raw_aio_discard, The rest of this chunk doesn't try to align '=3D'. Not worth a respin, bu= t something you may want to clean up on pull request. > .bdrv_refresh_limits =3D raw_refresh_limits, > @@ -2405,8 +2400,8 @@ static BlockDriver bdrv_host_device =3D { > .create_opts =3D &raw_create_opts, > .bdrv_co_pwrite_zeroes =3D hdev_co_pwrite_zeroes, > =20 > - .bdrv_aio_readv =3D raw_aio_readv, > - .bdrv_aio_writev =3D raw_aio_writev, > + .bdrv_co_readv =3D raw_co_readv, > + .bdrv_co_writev =3D raw_co_writev, > .bdrv_aio_flush =3D raw_aio_flush, > .bdrv_aio_discard =3D hdev_aio_discard, > .bdrv_refresh_limits =3D raw_refresh_limits, and this hunk is also inconsistent, but in a different way. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --h1hCG8wB9CEDkgL8tVXKNQP78BRkbbA3s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXYBBlAAoJEKeha0olJ0NqVTQH/ja7eGwIdb0qPYvZP1IE751d pSYwjE0tEUxjet7UsmP5xqKDFX79p1mKdJeD9SOmZPaLUFbeHA+CZnzTMZQxwEya yd66MoKZ4YH2RSfMT5cwOTcAwtLTaRZeeF9tWPHchyTZZflcc9OqChcEmhZfV/yp GMnAMmeZlWGZcfCNLyjSuEYqIyU0HcY0E4W4AMsxm4UE0D1rRPPpmlLXwmM+T7B/ cOZ55hrIo/t0utkVeBNNs5SSWtWM6IvhG+SyQ+vDHmuAw7sLYx51QfOsHJ+DXyNV /zjgR+0FuEqKb6e9VjT1f7TjPbLR4GPGGfHu9/R3QUKsu1kXbLQKlxo126Nf2Ys= =69Wm -----END PGP SIGNATURE----- --h1hCG8wB9CEDkgL8tVXKNQP78BRkbbA3s--