All of lore.kernel.org
 help / color / mirror / Atom feed
From: Logan Gunthorpe <logang@deltatee.com>
To: Allen Hubbe <Allen.Hubbe@emc.com>, 'Allen Hubbe' <allenbh@gmail.com>
Cc: 'Jon Mason' <jdmason@kudzu.us>,
	'Dave Jiang' <dave.jiang@intel.com>,
	'Shuah Khan' <shuahkh@osg.samsung.com>,
	'Sudip Mukherjee' <sudipm.mukherjee@gmail.com>,
	'Arnd Bergmann' <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 6/8] ntb_tool: Add link status file to debugfs
Date: Tue, 14 Jun 2016 09:48:06 -0600	[thread overview]
Message-ID: <57602736.7090709@deltatee.com> (raw)
In-Reply-To: <000101d1c653$bc673280$35359780$@emc.com>



On 14/06/16 09:45 AM, Allen Hubbe wrote:
> 
> Feel free to disregard my suggestion above.  I hope my comment has not cost you too much time.
> 
> The way you have written it already, and used it in the self-test script is much more concise.
> 
>>> + * root@self# echo > $DBG_DIR/link
> 
> Acked-by: Allen.Hubbe@emc.com
> 
> 
> 
> Eventually, I think it would be useful to let ntb_tool enable and disable the link.  In that case, it might also be useful in a test script to wait for link down, not just link up.
> 
> What about this:
> 
> # Wait for the link to be up or down
> root@self# echo 1 > $DBG_DIR/link
> root@self# echo 0 > $DBG_DIR/link
> 
> It need not be a part of this patch, but eventually:
> 
> # Enable or disable the link
> root@self# echo 1 > $DBG_DIR/link_ctrl
> root@self# echo 0 > $DBG_DIR/link_ctrl
> 
> # Reading the link_ctrl file can also give the link status
> root@self# cat $DBG_DIR/link_ctrl
> 
> Finally, I wonder if the file called "link" in this patch should be called "link_wait" or similar, so its purpose is obviously not for enabling and disabling the link.
> 

Actually I've already implemented something similar to your original
suggestion. I'll be submitting a v2 of this set shortly.

Logan

  reply	other threads:[~2016-06-14 15:48 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-10 22:54 [PATCH 0/8] NTB Selftest Script Logan Gunthorpe
2016-06-10 22:54 ` [PATCH 1/8] ntb_perf: Schedule based on time not on performance Logan Gunthorpe
2016-06-13 18:05   ` Jiang, Dave
2016-06-10 22:54 ` [PATCH 2/8] ntb_perf: Improve thread handling to increase robustness Logan Gunthorpe
2016-06-13 18:16   ` Jiang, Dave
2016-06-10 22:54 ` [PATCH 3/8] ntb_perf: Return results by reading the run file Logan Gunthorpe
2016-06-13 20:09   ` Jiang, Dave
2016-06-10 22:54 ` [PATCH 4/8] ntb_perf: Wait for link before running test Logan Gunthorpe
2016-06-13 20:14   ` Jiang, Dave
2016-06-10 22:54 ` [PATCH 5/8] ntb_tool: BUG: Ensure the buffer size is large enough to return all spads Logan Gunthorpe
2016-06-11  2:35   ` Allen Hubbe
2016-06-11 15:29     ` Logan Gunthorpe
2016-06-10 22:54 ` [PATCH 6/8] ntb_tool: Add link status file to debugfs Logan Gunthorpe
2016-06-11  2:27   ` Allen Hubbe
2016-06-11 15:28     ` Logan Gunthorpe
2016-06-12  1:28       ` Allen Hubbe
2016-06-14 15:45         ` Allen Hubbe
2016-06-14 15:45           ` Allen Hubbe
2016-06-14 15:48           ` Logan Gunthorpe [this message]
2016-06-14 15:54             ` Allen Hubbe
2016-06-14 15:54               ` Allen Hubbe
2016-06-10 22:54 ` [PATCH 7/8] ntb_pingpong: Add a debugfs file to get the ping count Logan Gunthorpe
2016-06-11  2:46   ` Allen Hubbe
2016-06-11 15:30     ` Logan Gunthorpe
2016-06-10 22:54 ` [PATCH 8/8] ntb_test: Add a selftest script for the NTB subsystem Logan Gunthorpe
2016-06-14 14:06   ` Jon Mason
2016-06-14 14:16     ` Shuah Khan
2016-06-14 15:45       ` Logan Gunthorpe
2016-06-14 15:47   ` Allen Hubbe
2016-06-14 15:47     ` Allen Hubbe
2016-06-14 15:49     ` Logan Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57602736.7090709@deltatee.com \
    --to=logang@deltatee.com \
    --cc=Allen.Hubbe@emc.com \
    --cc=allenbh@gmail.com \
    --cc=arnd@arndb.de \
    --cc=dave.jiang@intel.com \
    --cc=jdmason@kudzu.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-ntb@googlegroups.com \
    --cc=shuahkh@osg.samsung.com \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.