From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDGIW-0000kl-L2 for qemu-devel@nongnu.org; Wed, 15 Jun 2016 15:16:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDGIS-0002wX-Uq for qemu-devel@nongnu.org; Wed, 15 Jun 2016 15:16:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDGIS-0002wN-OR for qemu-devel@nongnu.org; Wed, 15 Jun 2016 15:16:16 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5AB476438E for ; Wed, 15 Jun 2016 19:16:16 +0000 (UTC) References: <1466013391-16028-1-git-send-email-armbru@redhat.com> <1466013391-16028-2-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <5761A97F.9090000@redhat.com> Date: Wed, 15 Jun 2016 13:16:15 -0600 MIME-Version: 1.0 In-Reply-To: <1466013391-16028-2-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qxUKCIdxpSSbSt1tvwko8jm2sdL6NdtEx" Subject: Re: [Qemu-devel] [PATCH 1/2] piix: Set I440FXState member pci_info.w32 in one place List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: marcel@redhat.com, imammedo@redhat.com, ehabkost@redhat.com, mst@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qxUKCIdxpSSbSt1tvwko8jm2sdL6NdtEx Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/15/2016 11:56 AM, Markus Armbruster wrote: > Range pci_info.w32 records the location of the PCI hole. >=20 > It's initialized to empty when QOM zeroes I440FXState. That's a fine > value for a still unknown PCI hole. >=20 > i440fx_init() sets pci_info.w32.begin =3D below_4g_mem_size. Changes > the PCI hole from empty to [below_4g_mem_size, UINT64_MAX]. That's a > bogus value. >=20 > i440fx_pcihost_initfn() sets pci_info.end =3D IO_APIC_DEFAULT_ADDRESS. > Since i440fx_init() ran already, this changes the PCI hole to > [below_4g_mem_size, IO_APIC_DEFAULT_ADDRESS-1]. That's the correct > value. >=20 > Setting the bounds of the PCI hole in two separate places is > confusing, and begs the question whether the bogus intermediate value > could be used by something, or what would happen if we somehow managed > to realize an i440FX device without having run the board init function > i440fx_init() first. >=20 > Avoid the confusion by setting the (constant) upper bound along with > the lower bound in i440fx_init(). >=20 > Signed-off-by: Markus Armbruster > --- > hw/pci-host/piix.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qxUKCIdxpSSbSt1tvwko8jm2sdL6NdtEx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXYal/AAoJEKeha0olJ0NqbeMH/36AwRn9ey1JmdopHSPHyue5 YxXu1UPdw5sqPIsHR4n/Jbi5UfvAMVdFgeWVlPjGXWhfMX9OEki6R6Rl0xlJ9yYW TcBRMN2cBBRm/WZsJ0MgxI5/212t/sZmYP30jYSxsogoMCymoqbZ6gjQxPyq/np5 Zb0nVob4fOIUPRg4wqabmskr23Cukow/bzfvltqf/EFEkWYHaCPSohz81eOX4jo+ GiCPkHxdv5z2aIURk5HH03Kv87i+Na3KUl4YTel5SMoAK5Zz/Ix4nWw4RW0mti45 OguB1uIDY/ktH5KVUNaawIwEGooX1hG513810Yxy7jzWdJsuUf4wQzCtbCa7AP4= =48Kz -----END PGP SIGNATURE----- --qxUKCIdxpSSbSt1tvwko8jm2sdL6NdtEx--