From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDGOS-00056i-Vr for qemu-devel@nongnu.org; Wed, 15 Jun 2016 15:22:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDGOO-0003yo-Py for qemu-devel@nongnu.org; Wed, 15 Jun 2016 15:22:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDGOO-0003yI-HU for qemu-devel@nongnu.org; Wed, 15 Jun 2016 15:22:24 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4617F3B728 for ; Wed, 15 Jun 2016 19:22:23 +0000 (UTC) References: <1466013391-16028-1-git-send-email-armbru@redhat.com> <1466013391-16028-3-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <5761AAEE.80407@redhat.com> Date: Wed, 15 Jun 2016 13:22:22 -0600 MIME-Version: 1.0 In-Reply-To: <1466013391-16028-3-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wp61JaFpDntlX6bcvBNucAcDtD6oxVD2h" Subject: Re: [Qemu-devel] [PATCH 2/2] pc: Eliminate PcPciInfo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: marcel@redhat.com, imammedo@redhat.com, ehabkost@redhat.com, mst@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wp61JaFpDntlX6bcvBNucAcDtD6oxVD2h Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/15/2016 11:56 AM, Markus Armbruster wrote: > PcPciInfo has two (ill-named) members: Range w32 is the PCI hole, and > w64 is the PCI64 hole. >=20 > Three users: >=20 > * I440FXState and MCHPCIState have a member PcPciInfo pci_info, but > only pci_info.w32 is actually used. This is confusing. Replace by > Range pci_hole. >=20 > * acpi_build() uses auto PcPciInfo pci_info to forward both PCI holes > from acpi_get_pci_info() to build_dsdt(). Replace by two variables > Range pci_hole, pci_hole64. Rename acpi_get_pci_info() to > acpi_get_pci_holes(). >=20 > PcPciInfo is now unused; drop it. >=20 > Signed-off-by: Markus Armbruster > --- > hw/i386/acpi-build.c | 43 ++++++++++++++++++++++-----------------= ---- > hw/pci-host/piix.c | 10 +++++----- > hw/pci-host/q35.c | 12 ++++++------ > include/hw/i386/pc.h | 5 ----- > include/hw/pci-host/q35.h | 2 +- > 5 files changed, 34 insertions(+), 38 deletions(-) >=20 > +++ b/include/hw/i386/pc.h > @@ -148,11 +148,6 @@ struct PCMachineClass { > =20 > /* PC-style peripherals (also used by other machines). */ > =20 > -typedef struct PcPciInfo { > - Range w32; > - Range w64; > -} PcPciInfo; Confusing indeed. Good riddance. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --wp61JaFpDntlX6bcvBNucAcDtD6oxVD2h Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXYaruAAoJEKeha0olJ0NqJDIH/iVVFt+cNNyGCoQ1vhmencbe 7evlIa8b3QR0hQFefg7YqBkyDWJtr3/dcB3L332tdH1feN9OCIs1sj18tuNA5TYQ fM3tkCrHQ8NorD0nU6KqEznkLQqBqLGGAjPIu7JLbsUhb3sNSnrk8C59EjgDWucq H6GoANvHtDB8ndcc6NUjQKASxiY0J7nXoGpqU0YdIASDYstkN+PZeFQ2ON4yKJBL o//MEjh89c8xVrpCJi9re/Jelv+aadR8gL7X/UPpM1rObX6f9bJf1WlolyIpb+4E RkReHPglRM8cFywdRC4x/PB+grtJ6+DzH+mlGYk0OwzfKTmSDn3DNXyHTuiug9s= =+OfQ -----END PGP SIGNATURE----- --wp61JaFpDntlX6bcvBNucAcDtD6oxVD2h--