From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754734AbcFPNvw (ORCPT ); Thu, 16 Jun 2016 09:51:52 -0400 Received: from foss.arm.com ([217.140.101.70]:43951 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754060AbcFPNvu (ORCPT ); Thu, 16 Jun 2016 09:51:50 -0400 Subject: Re: [PATCH RESEND 1/3] dt-bindings: add bindings documentation for PDC driver. To: Rob Rice References: <1465912965-35500-1-git-send-email-rob.rice@broadcom.com> <1465912965-35500-2-git-send-email-rob.rice@broadcom.com> <576017C7.50609@arm.com> Cc: Sudeep Holla , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Jassi Brar , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, BCM Kernel Feedback , linux-kernel@vger.kernel.org, Ray Jui , Scott Branden , Jon Mason , Florian Fainelli , Anup Patel , Catalin Marinas , Will Deacon , Rob Rice From: Sudeep Holla Organization: ARM Message-ID: <5762AEF0.9030203@arm.com> Date: Thu, 16 Jun 2016 14:51:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/06/16 14:50, Rob Rice wrote: > > > On Tue, Jun 14, 2016 at 10:42 AM, Sudeep Holla > wrote: > > > > On 14/06/16 15:02, Rob Rice wrote: > > From: Rob Rice > > > Add the device tree binding documentation for the PDC hardware > in Broadcom iProc SoCs. > > Signed-off-by: Rob Rice > > Acked-by: Rob Herring > > Reviewed-by: Ray Jui > > Reviewed-by: Anup Patel > > Reviewed-by: Scott Branden > > --- > .../bindings/mailbox/brcm,iproc-pdc-mbox.txt | 23 > ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt > > diff --git > a/Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt > b/Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt > new file mode 100644 > index 0000000..411ccf4 > --- /dev/null > +++ > b/Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt > @@ -0,0 +1,23 @@ > +The PDC driver manages data transfer to and from various > offload engines > +on some Broadcom SoCs. An SoC may have multiple PDC hardware > blocks. There is > +one device tree entry per block. > + > +Required properties: > +- compatible : Should be "brcm,iproc-pdc-mbox". > +- reg: Should contain PDC registers location and length. > +- interrupts: Should contain the IRQ line for the PDC. > +- #mbox-cells: 1 > +- brcm,rx-status-len: Length of metadata preceding received > frames, in bytes. > + > > > Ideally the metadata is more associated with the software protocol built > on top of the mailbox controller. > > Is this metadata added by the hardware ? > > Otherwise it's better to make it part of the protocol rather than the > associating with the controller. > > > Yes, in fact this metadata is added by the PDC hardware itself. So it > seems correct for the DT property to be on the controller. In that case, it's fine. -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 From: sudeep.holla@arm.com (Sudeep Holla) Date: Thu, 16 Jun 2016 14:51:44 +0100 Subject: [PATCH RESEND 1/3] dt-bindings: add bindings documentation for PDC driver. In-Reply-To: References: <1465912965-35500-1-git-send-email-rob.rice@broadcom.com> <1465912965-35500-2-git-send-email-rob.rice@broadcom.com> <576017C7.50609@arm.com> Message-ID: <5762AEF0.9030203@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 16/06/16 14:50, Rob Rice wrote: > > > On Tue, Jun 14, 2016 at 10:42 AM, Sudeep Holla > wrote: > > > > On 14/06/16 15:02, Rob Rice wrote: > > From: Rob Rice > > > Add the device tree binding documentation for the PDC hardware > in Broadcom iProc SoCs. > > Signed-off-by: Rob Rice > > Acked-by: Rob Herring > > Reviewed-by: Ray Jui > > Reviewed-by: Anup Patel > > Reviewed-by: Scott Branden > > --- > .../bindings/mailbox/brcm,iproc-pdc-mbox.txt | 23 > ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt > > diff --git > a/Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt > b/Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt > new file mode 100644 > index 0000000..411ccf4 > --- /dev/null > +++ > b/Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt > @@ -0,0 +1,23 @@ > +The PDC driver manages data transfer to and from various > offload engines > +on some Broadcom SoCs. An SoC may have multiple PDC hardware > blocks. There is > +one device tree entry per block. > + > +Required properties: > +- compatible : Should be "brcm,iproc-pdc-mbox". > +- reg: Should contain PDC registers location and length. > +- interrupts: Should contain the IRQ line for the PDC. > +- #mbox-cells: 1 > +- brcm,rx-status-len: Length of metadata preceding received > frames, in bytes. > + > > > Ideally the metadata is more associated with the software protocol built > on top of the mailbox controller. > > Is this metadata added by the hardware ? > > Otherwise it's better to make it part of the protocol rather than the > associating with the controller. > > > Yes, in fact this metadata is added by the PDC hardware itself. So it > seems correct for the DT property to be on the controller. In that case, it's fine. -- Regards, Sudeep