From: "Jan Beulich" <JBeulich@suse.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH RFC 2/2] xen: make available hvm_fep to non-debug build as well
Date: Thu, 16 Jun 2016 06:31:01 -0600 [thread overview]
Message-ID: <5762B82502000078000F5AD5@prv-mh.provo.novell.com> (raw)
In-Reply-To: <20160616115209.GP28116@citrix.com>
>>> On 16.06.16 at 13:52, <wei.liu2@citrix.com> wrote:
> On Thu, Jun 16, 2016 at 05:37:03AM -0600, Jan Beulich wrote:
>> >>> On 15.06.16 at 16:31, <wei.liu2@citrix.com> wrote:
>> > + printk("**********************************************\n");
>> > + printk("******* WARNING: HVM FORCED EMULATION PREFIX IS PERMITTED\n");
>> > + printk("******* This option is *ONLY* intended to aid debugging "
>> > + "and testing of Xen\n");
>> > + printk("******* that HVM guest can enter instruction emulator "
>> > + "with UD instruction.\n");
>> > + printk("******* It has implication on the security of the system.\n");
>> > + printk("******* Please *DO NOT* use this in production.\n");
>> > + printk("**********************************************\n");
>> > + add_taint(TAINT_HVM_FEP);
>>
>> Should we perhaps taint the system only the first time a guest
>> makes use of this?
>>
>
> Doesn't that add overhead to a potential hot path? Arguably it is only
> setting a bit in a flag, but still...
How can that be a hot path, if it's not even usable without the
option set?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-06-16 12:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 14:31 [PATCH RFC 0/2] Make hvm_fep available to non-debug builds Wei Liu
2016-06-15 14:31 ` [PATCH RFC 1/2] xen/kernel: document 'C' in print_tainted Wei Liu
2016-06-15 14:53 ` Jan Beulich
2016-06-15 14:31 ` [PATCH RFC 2/2] xen: make available hvm_fep to non-debug build as well Wei Liu
2016-06-15 14:39 ` Doug Goldstein
2016-06-15 14:47 ` Wei Liu
2016-06-15 16:12 ` Doug Goldstein
2016-06-15 16:14 ` Wei Liu
2016-06-16 11:37 ` Jan Beulich
2016-06-16 11:52 ` Wei Liu
2016-06-16 12:12 ` Andrew Cooper
2016-06-16 12:20 ` Wei Liu
2016-06-16 12:31 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5762B82502000078000F5AD5@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.