From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755183AbcFPR7U (ORCPT ); Thu, 16 Jun 2016 13:59:20 -0400 Received: from foss.arm.com ([217.140.101.70]:45495 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753903AbcFPR7S (ORCPT ); Thu, 16 Jun 2016 13:59:18 -0400 Subject: Re: [PATCH v2 3/3] firmware: scpi: add device power domain support using genpd To: "Jon Medhurst (Tixy)" References: <1466073481-697-1-git-send-email-sudeep.holla@arm.com> <1466073481-697-4-git-send-email-sudeep.holla@arm.com> <1466099274.20208.65.camel@linaro.org> Cc: Sudeep Holla , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ulf Hansson , Mathieu Poirier , Suzuki K Poulose , "Rafael J. Wysocki" , Kevin Hilman From: Sudeep Holla Organization: ARM Message-ID: <5762E8F1.1040401@arm.com> Date: Thu, 16 Jun 2016 18:59:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1466099274.20208.65.camel@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/06/16 18:47, Jon Medhurst (Tixy) wrote: > On Thu, 2016-06-16 at 11:38 +0100, Sudeep Holla wrote: > [...] >> +enum scpi_power_domain_state { >> + SCPI_PD_STATE_ON = 0, >> + SCPI_PD_STATE_OFF = 3, >> +}; > > The SCPI doc defines the meaning of these numbers (0 and 3) in the 'Juno > specifics' chapter. So does these values need to come from device-tree > to allow for other hardware or SCP implementations? > Ah unfortunately true :(. I had not noticed that. But I would like to check if this can be made as part of the standard protocol. Adding such details to DT seems overkill and defeat of the whole purpose of the standard protocol. -- Regards, Sudeep