* [Xen-devel] [PATCH] xen/arm: domain_build: Print the correct domain in initrd_load()
@ 2019-08-15 17:32 Julien Grall
2019-08-16 16:32 ` Volodymyr Babchuk
2019-10-02 1:18 ` Stefano Stabellini
0 siblings, 2 replies; 4+ messages in thread
From: Julien Grall @ 2019-08-15 17:32 UTC (permalink / raw)
To: xen-devel; +Cc: Julien Grall, Stefano Stabellini, Volodymyr Babchuk
initrd_load() can be called by other domain than dom0. To avoid
confusion in the log, print the correct domain.
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
xen/arch/arm/domain_build.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 126374f603..33171081ea 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -1818,8 +1818,8 @@ static void __init initrd_load(struct kernel_info *kinfo)
paddr = mod->start;
len = mod->size;
- printk("Loading dom0 initrd from %"PRIpaddr" to 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
- paddr, load_addr, load_addr + len);
+ printk("Loading %pd initrd from %"PRIpaddr" to 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
+ kinfo->d, paddr, load_addr, load_addr + len);
/* Fix up linux,initrd-start and linux,initrd-end in /chosen */
node = fdt_path_offset(kinfo->fdt, "/chosen");
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH] xen/arm: domain_build: Print the correct domain in initrd_load()
2019-08-15 17:32 [Xen-devel] [PATCH] xen/arm: domain_build: Print the correct domain in initrd_load() Julien Grall
@ 2019-08-16 16:32 ` Volodymyr Babchuk
2019-08-16 16:34 ` Julien Grall
2019-10-02 1:18 ` Stefano Stabellini
1 sibling, 1 reply; 4+ messages in thread
From: Volodymyr Babchuk @ 2019-08-16 16:32 UTC (permalink / raw)
To: Julien Grall; +Cc: xen-devel, Stefano Stabellini, Volodymyr Babchuk
Julien Grall writes:
> initrd_load() can be called by other domain than dom0. To avoid
> confusion in the log, print the correct domain.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
But why didn't you gathered all those patches into one patch series?
> ---
> xen/arch/arm/domain_build.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 126374f603..33171081ea 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1818,8 +1818,8 @@ static void __init initrd_load(struct kernel_info *kinfo)
> paddr = mod->start;
> len = mod->size;
>
> - printk("Loading dom0 initrd from %"PRIpaddr" to 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
> - paddr, load_addr, load_addr + len);
> + printk("Loading %pd initrd from %"PRIpaddr" to 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
> + kinfo->d, paddr, load_addr, load_addr + len);
>
> /* Fix up linux,initrd-start and linux,initrd-end in /chosen */
> node = fdt_path_offset(kinfo->fdt, "/chosen");
--
Volodymyr Babchuk at EPAM
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH] xen/arm: domain_build: Print the correct domain in initrd_load()
2019-08-16 16:32 ` Volodymyr Babchuk
@ 2019-08-16 16:34 ` Julien Grall
0 siblings, 0 replies; 4+ messages in thread
From: Julien Grall @ 2019-08-16 16:34 UTC (permalink / raw)
To: Volodymyr Babchuk; +Cc: xen-devel, Stefano Stabellini
On 16/08/2019 17:32, Volodymyr Babchuk wrote:
>
> Julien Grall writes:
>
>> initrd_load() can be called by other domain than dom0. To avoid
>> confusion in the log, print the correct domain.
>>
>> Signed-off-by: Julien Grall <julien.grall@arm.com>
> Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
>
> But why didn't you gathered all those patches into one patch series?
Because I couldn't be bothered to write a cover letter for it and
they don't depend on each other...
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH] xen/arm: domain_build: Print the correct domain in initrd_load()
2019-08-15 17:32 [Xen-devel] [PATCH] xen/arm: domain_build: Print the correct domain in initrd_load() Julien Grall
2019-08-16 16:32 ` Volodymyr Babchuk
@ 2019-10-02 1:18 ` Stefano Stabellini
1 sibling, 0 replies; 4+ messages in thread
From: Stefano Stabellini @ 2019-10-02 1:18 UTC (permalink / raw)
To: Julien Grall; +Cc: xen-devel, Stefano Stabellini, Volodymyr Babchuk
On Thu, 15 Aug 2019, Julien Grall wrote:
> initrd_load() can be called by other domain than dom0. To avoid
> confusion in the log, print the correct domain.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Thanks the bug was really annoying.
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> xen/arch/arm/domain_build.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 126374f603..33171081ea 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1818,8 +1818,8 @@ static void __init initrd_load(struct kernel_info *kinfo)
> paddr = mod->start;
> len = mod->size;
>
> - printk("Loading dom0 initrd from %"PRIpaddr" to 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
> - paddr, load_addr, load_addr + len);
> + printk("Loading %pd initrd from %"PRIpaddr" to 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
> + kinfo->d, paddr, load_addr, load_addr + len);
>
> /* Fix up linux,initrd-start and linux,initrd-end in /chosen */
> node = fdt_path_offset(kinfo->fdt, "/chosen");
> --
> 2.11.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-02 1:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-15 17:32 [Xen-devel] [PATCH] xen/arm: domain_build: Print the correct domain in initrd_load() Julien Grall
2019-08-16 16:32 ` Volodymyr Babchuk
2019-08-16 16:34 ` Julien Grall
2019-10-02 1:18 ` Stefano Stabellini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.