From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754900AbcFQG1H (ORCPT ); Fri, 17 Jun 2016 02:27:07 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:54448 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbcFQG1E (ORCPT ); Fri, 17 Jun 2016 02:27:04 -0400 X-AuditID: cbfec7f4-f796c6d000001486-90-5763983450ee Subject: Re: [PATCH v3 3/7] max8903: cleans up confusing relationship between dc_valid, dok and dcm. To: Chris Lapa , dwmw2@infradead.org, dbaryshkov@gmail.com, sre@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org References: <1464849897-21527-3-git-send-email-chris@lapa.com.au> <1466139626-51434-1-git-send-email-chris@lapa.com.au> <1466139626-51434-4-git-send-email-chris@lapa.com.au> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org From: Krzysztof Kozlowski Message-id: <57639832.6000201@samsung.com> Date: Fri, 17 Jun 2016 08:26:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1466139626-51434-4-git-send-email-chris@lapa.com.au> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrALMWRmVeSWpSXmKPExsVy+t/xy7omM5LDDR4vkbZ4eMbMYtKT98wW 84+cY7WYuHIys8XrF4YWl3fNYbP43HuE0WLp9YtMFq17j7BbnN5d4sDlsWbeGkaPnbPusnts XqHlsWlVJ5vHsrmbGT36tqxi9Pi8SS6APYrLJiU1J7MstUjfLoEr4+CaZpaCI7wV5+eeYmpg vM3VxcjJISFgItH65hkjhC0mceHeejYQW0hgKaPE6X6mLkYuIPsZo8StE99YQRLCAmkSr94+ ZQRJiAh0Mkp8f7mdEaJqI6PEjDttYO3MAhESnQ8OsYPYbALGEpuXLwGL8wpoSSyffAFsHYuA qsST33OYQGxRoPpZ238wQdQISvyYfI8FxOYUcJLY+6eXuYuRA2imnsT9i1oQ4+UlNq95yzyB UWAWko5ZCFWzkFQtYGRexSiaWppcUJyUnmuoV5yYW1yal66XnJ+7iRESD192MC4+ZnWIUYCD UYmHd4VocrgQa2JZcWXuIUYJDmYlEV7N6UAh3pTEyqrUovz4otKc1OJDjNIcLErivHN3vQ8R EkhPLEnNTk0tSC2CyTJxcEo1MDbXKuYs+LlsYQrzdW/fTRIdYffmrvzpztgjER45ReZq1JKT Fz9/jRM8N1dZ99hjTguOWDPX/WUsSrO+9/UFi98t4wqyszwSw1hqfaO99PCs6tnOVhEcu/et 2GvVd7/Hy0h8f/uMM8Kd39YmRc3If7x9z0X/VyVu2udi005/YPok6PdFojX4mBJLcUaioRZz UXEiAJBFQW+DAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/17/2016 07:00 AM, Chris Lapa wrote: > From: Chris Lapa > > The max8903_charger.h file indicated that dcm and dok were not optional > when dc_valid is set. > > It makes sense to have dok as a compulsory pin when dc_valid is given. > However dcm can be optionally wired to a fixed level especially when the > circuit is configured for dc power exclusively. > > The previous implementation already allowed for this somewhat, however no > error was given if dok wasn't given whilst dc_valid was. > > The new implementation enforces dok presence when dc_valid is given. Whilst > allowing dcm to be optional. > > Signed-off-by: Chris Lapa > --- > drivers/power/max8903_charger.c | 23 ++++++++++------------- > include/linux/power/max8903_charger.h | 6 +++--- > 2 files changed, 13 insertions(+), 16 deletions(-) > > diff --git a/drivers/power/max8903_charger.c b/drivers/power/max8903_charger.c > index 0a5b0e1..dbd911c4 100644 > --- a/drivers/power/max8903_charger.c > +++ b/drivers/power/max8903_charger.c > @@ -211,27 +211,24 @@ static int max8903_probe(struct platform_device *pdev) > } > > if (pdata->dc_valid) { > - if (pdata->dok && gpio_is_valid(pdata->dok) && > - pdata->dcm && gpio_is_valid(pdata->dcm)) { > + if (pdata->dok && gpio_is_valid(pdata->dok)) { > gpio = pdata->dok; /* PULL_UPed Interrupt */ > ta_in = gpio_get_value(gpio) ? 0 : 1; > + } else { > + dev_err(dev, "When DC is wired, DOK should" > + " be wired as well.\n"); Just found one nit. Don't split the strings. dev_err(dev, "When DC is wired, DOK should be wired as well.\n"); Best regards, Krzysztof