From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb1-smtp-cloud3.xs4all.net ([194.109.24.22]:39441 "EHLO lb1-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754936AbcFQIGh (ORCPT ); Fri, 17 Jun 2016 04:06:37 -0400 Subject: Re: [PATCHv16 10/13] cec: adv7842: add cec support To: Mauro Carvalho Chehab References: <1461937948-22936-1-git-send-email-hverkuil@xs4all.nl> <1461937948-22936-11-git-send-email-hverkuil@xs4all.nl> <20160616182228.1bd755d5@recife.lan> Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-input@vger.kernel.org, lars@opdenkamp.eu, linux@arm.linux.org.uk, Hans Verkuil From: Hans Verkuil Message-ID: <5763AF87.2030700@xs4all.nl> Date: Fri, 17 Jun 2016 10:06:31 +0200 MIME-Version: 1.0 In-Reply-To: <20160616182228.1bd755d5@recife.lan> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 06/16/2016 11:22 PM, Mauro Carvalho Chehab wrote: > Em Fri, 29 Apr 2016 15:52:25 +0200 > Hans Verkuil escreveu: > >> From: Hans Verkuil >> >> Add CEC support to the adv7842 driver. >> >> Signed-off-by: Hans Verkuil > > Won't review patches 10-13, as the same reviews I made for patch 9 > very likely applies. > > As this series is causing non-staging drivers to be dependent of a > staging driver, I'll wait for the next version that should be > solving this issue. > > For the new 9-13 patches, please be sure that checkpatch will be > happy. For the staging stuff, the checkpatch issues can be solved > later, as I'll re-check against checkpatch when it moves from staging > to mainstream. I have to make changes anyway so I'll make a new pull request later today fixing all the comments and replacing unsigned with unsigned int (which is a majority of all the checkpatch warnings). Did I mention yet how much I hate this new checkpatch warning? In almost all cases I agree with the checkpatch rules, but this one is just stupid IMHO. Oh well, I'll make the change. Perhaps it will grow on me over time. Regards, Hans From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Subject: Re: [PATCHv16 10/13] cec: adv7842: add cec support Date: Fri, 17 Jun 2016 10:06:31 +0200 Message-ID: <5763AF87.2030700@xs4all.nl> References: <1461937948-22936-1-git-send-email-hverkuil@xs4all.nl> <1461937948-22936-11-git-send-email-hverkuil@xs4all.nl> <20160616182228.1bd755d5@recife.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160616182228.1bd755d5@recife.lan> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mauro Carvalho Chehab Cc: linux-samsung-soc@vger.kernel.org, linux@arm.linux.org.uk, dri-devel@lists.freedesktop.org, lars@opdenkamp.eu, Hans Verkuil , linux-input@vger.kernel.org, linux-media@vger.kernel.org List-Id: linux-input@vger.kernel.org T24gMDYvMTYvMjAxNiAxMToyMiBQTSwgTWF1cm8gQ2FydmFsaG8gQ2hlaGFiIHdyb3RlOgo+IEVt IEZyaSwgMjkgQXByIDIwMTYgMTU6NTI6MjUgKzAyMDAKPiBIYW5zIFZlcmt1aWwgPGh2ZXJrdWls QHhzNGFsbC5ubD4gZXNjcmV2ZXU6Cj4gCj4+IEZyb206IEhhbnMgVmVya3VpbCA8aGFucy52ZXJr dWlsQGNpc2NvLmNvbT4KPj4KPj4gQWRkIENFQyBzdXBwb3J0IHRvIHRoZSBhZHY3ODQyIGRyaXZl ci4KPj4KPj4gU2lnbmVkLW9mZi1ieTogSGFucyBWZXJrdWlsIDxoYW5zLnZlcmt1aWxAY2lzY28u Y29tPgo+IAo+IFdvbid0IHJldmlldyBwYXRjaGVzIDEwLTEzLCBhcyB0aGUgc2FtZSByZXZpZXdz IEkgbWFkZSBmb3IgcGF0Y2ggOQo+IHZlcnkgbGlrZWx5IGFwcGxpZXMuCj4gCj4gQXMgdGhpcyBz ZXJpZXMgaXMgY2F1c2luZyBub24tc3RhZ2luZyBkcml2ZXJzIHRvIGJlIGRlcGVuZGVudCBvZiBh Cj4gc3RhZ2luZyBkcml2ZXIsIEknbGwgd2FpdCBmb3IgdGhlIG5leHQgdmVyc2lvbiB0aGF0IHNo b3VsZCBiZQo+IHNvbHZpbmcgdGhpcyBpc3N1ZS4KPiAKPiBGb3IgdGhlIG5ldyA5LTEzIHBhdGNo ZXMsIHBsZWFzZSBiZSBzdXJlIHRoYXQgY2hlY2twYXRjaCB3aWxsIGJlCj4gaGFwcHkuIEZvciB0 aGUgc3RhZ2luZyBzdHVmZiwgdGhlIGNoZWNrcGF0Y2ggaXNzdWVzIGNhbiBiZSBzb2x2ZWQKPiBs YXRlciwgYXMgSSdsbCByZS1jaGVjayBhZ2FpbnN0IGNoZWNrcGF0Y2ggd2hlbiBpdCBtb3ZlcyBm cm9tIHN0YWdpbmcKPiB0byBtYWluc3RyZWFtLgoKSSBoYXZlIHRvIG1ha2UgY2hhbmdlcyBhbnl3 YXkgc28gSSdsbCBtYWtlIGEgbmV3IHB1bGwgcmVxdWVzdCBsYXRlcgp0b2RheSBmaXhpbmcgYWxs IHRoZSBjb21tZW50cyBhbmQgcmVwbGFjaW5nIHVuc2lnbmVkIHdpdGggdW5zaWduZWQgaW50Cih3 aGljaCBpcyBhIG1ham9yaXR5IG9mIGFsbCB0aGUgY2hlY2twYXRjaCB3YXJuaW5ncykuCgpEaWQg SSBtZW50aW9uIHlldCBob3cgbXVjaCBJIGhhdGUgdGhpcyBuZXcgY2hlY2twYXRjaCB3YXJuaW5n PyBJbiBhbG1vc3QgYWxsCmNhc2VzIEkgYWdyZWUgd2l0aCB0aGUgY2hlY2twYXRjaCBydWxlcywg YnV0IHRoaXMgb25lIGlzIGp1c3Qgc3R1cGlkIElNSE8uCgpPaCB3ZWxsLCBJJ2xsIG1ha2UgdGhl IGNoYW5nZS4gUGVyaGFwcyBpdCB3aWxsIGdyb3cgb24gbWUgb3ZlciB0aW1lLgoKUmVnYXJkcywK CglIYW5zCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=