From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEvCE-0007ku-SB for qemu-devel@nongnu.org; Mon, 20 Jun 2016 05:08:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEvCB-0003C5-Mz for qemu-devel@nongnu.org; Mon, 20 Jun 2016 05:08:42 -0400 References: <1464318298-2456-1-git-send-email-david@gibson.dropbear.id.au> <1464318298-2456-4-git-send-email-david@gibson.dropbear.id.au> <20160615221719.12f246dd@kryten> <20160616051928.GA1642@voom.fritz.box> <2fe8f40e-27ba-23b7-5d11-f75eda95568d@twiddle.net> <20160618002756.780936ac@kryten> <20160618140246.027e6887@kryten> <5767A798.5040105@redhat.com> From: Thomas Huth Message-ID: <5767B291.3090108@redhat.com> Date: Mon, 20 Jun 2016 11:08:33 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Anton Blanchard , Richard Henderson , QEMU Developers , "qemu-ppc@nongnu.org" , Alexander Graf , David Gibson On 20.06.2016 10:56, Peter Maydell wrote: > On 20 June 2016 at 09:21, Thomas Huth wrote: >> Would it maybe make sense to add some tests for this stuff to the >> tests/tcg/ folder to make sure that such regressions do not sneak back >> in in the future? >=20 > Wouldn't help very much, because tests/tcg doesn't get run. > (The underlying problem is "how do you have a good test > framework for all the TCG targets when you can't guarantee > to have the toolchains to build the test code for them?".) Oh, I see ... that's a pity. And I guess storing short binaries in the repository is also something we do not want, do we? ... so maybe, one far day in the future, we should detect potential cross compilers in the configure script, too, and enable those tests if the matching cross-compiler has been found... sounds like a task for cold and long winter nights... ;-) Thomas