From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754120AbcFTNNb (ORCPT ); Mon, 20 Jun 2016 09:13:31 -0400 Received: from arroyo.ext.ti.com ([198.47.19.12]:50369 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752419AbcFTNMs (ORCPT ); Mon, 20 Jun 2016 09:12:48 -0400 Subject: Re: [PATCH 4/4] phy: rockchip-emmc: reindent the register definitions To: Brian Norris References: <1463092986-61777-1-git-send-email-briannorris@chromium.org> <1463092986-61777-4-git-send-email-briannorris@chromium.org> CC: Heiko Stuebner , , , Doug Anderson , Shawn Lin , , Brian Norris From: Kishon Vijay Abraham I Message-ID: <5767EBA8.1060603@ti.com> Date: Mon, 20 Jun 2016 18:42:08 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1463092986-61777-4-git-send-email-briannorris@chromium.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 13 May 2016 04:13 AM, Brian Norris wrote: > Some of the spacing was wrong (spaces instead of tabs), and due to > longer entries added later, the columns weren't aligned. Let's get > everything consistent. > > Signed-off-by: Brian Norris Acked-by: Kishon Vijay Abraham I > --- > drivers/phy/phy-rockchip-emmc.c | 76 ++++++++++++++++++++--------------------- > 1 file changed, 38 insertions(+), 38 deletions(-) > > diff --git a/drivers/phy/phy-rockchip-emmc.c b/drivers/phy/phy-rockchip-emmc.c > index f94d3a6587ed..c27ca2b39dfe 100644 > --- a/drivers/phy/phy-rockchip-emmc.c > +++ b/drivers/phy/phy-rockchip-emmc.c > @@ -31,44 +31,44 @@ > ((val) << (shift) | (mask) << ((shift) + 16)) > > /* Register definition */ > -#define GRF_EMMCPHY_CON0 0x0 > -#define GRF_EMMCPHY_CON1 0x4 > -#define GRF_EMMCPHY_CON2 0x8 > -#define GRF_EMMCPHY_CON3 0xc > -#define GRF_EMMCPHY_CON4 0x10 > -#define GRF_EMMCPHY_CON5 0x14 > -#define GRF_EMMCPHY_CON6 0x18 > -#define GRF_EMMCPHY_STATUS 0x20 > - > -#define PHYCTRL_PDB_MASK 0x1 > -#define PHYCTRL_PDB_SHIFT 0x0 > -#define PHYCTRL_PDB_PWR_ON 0x1 > -#define PHYCTRL_PDB_PWR_OFF 0x0 > -#define PHYCTRL_ENDLL_MASK 0x1 > -#define PHYCTRL_ENDLL_SHIFT 0x1 > -#define PHYCTRL_ENDLL_ENABLE 0x1 > -#define PHYCTRL_ENDLL_DISABLE 0x0 > -#define PHYCTRL_CALDONE_MASK 0x1 > -#define PHYCTRL_CALDONE_SHIFT 0x6 > -#define PHYCTRL_CALDONE_DONE 0x1 > -#define PHYCTRL_CALDONE_GOING 0x0 > -#define PHYCTRL_DLLRDY_MASK 0x1 > -#define PHYCTRL_DLLRDY_SHIFT 0x5 > -#define PHYCTRL_DLLRDY_DONE 0x1 > -#define PHYCTRL_DLLRDY_GOING 0x0 > -#define PHYCTRL_FREQSEL_200M 0x0 > -#define PHYCTRL_FREQSEL_50M 0x1 > -#define PHYCTRL_FREQSEL_100M 0x2 > -#define PHYCTRL_FREQSEL_150M 0x3 > -#define PHYCTRL_FREQSEL_MASK 0x3 > -#define PHYCTRL_FREQSEL_SHIFT 0xc > -#define PHYCTRL_DR_MASK 0x7 > -#define PHYCTRL_DR_SHIFT 0x4 > -#define PHYCTRL_DR_50OHM 0x0 > -#define PHYCTRL_DR_33OHM 0x1 > -#define PHYCTRL_DR_66OHM 0x2 > -#define PHYCTRL_DR_100OHM 0x3 > -#define PHYCTRL_DR_40OHM 0x4 > +#define GRF_EMMCPHY_CON0 0x0 > +#define GRF_EMMCPHY_CON1 0x4 > +#define GRF_EMMCPHY_CON2 0x8 > +#define GRF_EMMCPHY_CON3 0xc > +#define GRF_EMMCPHY_CON4 0x10 > +#define GRF_EMMCPHY_CON5 0x14 > +#define GRF_EMMCPHY_CON6 0x18 > +#define GRF_EMMCPHY_STATUS 0x20 > + > +#define PHYCTRL_PDB_MASK 0x1 > +#define PHYCTRL_PDB_SHIFT 0x0 > +#define PHYCTRL_PDB_PWR_ON 0x1 > +#define PHYCTRL_PDB_PWR_OFF 0x0 > +#define PHYCTRL_ENDLL_MASK 0x1 > +#define PHYCTRL_ENDLL_SHIFT 0x1 > +#define PHYCTRL_ENDLL_ENABLE 0x1 > +#define PHYCTRL_ENDLL_DISABLE 0x0 > +#define PHYCTRL_CALDONE_MASK 0x1 > +#define PHYCTRL_CALDONE_SHIFT 0x6 > +#define PHYCTRL_CALDONE_DONE 0x1 > +#define PHYCTRL_CALDONE_GOING 0x0 > +#define PHYCTRL_DLLRDY_MASK 0x1 > +#define PHYCTRL_DLLRDY_SHIFT 0x5 > +#define PHYCTRL_DLLRDY_DONE 0x1 > +#define PHYCTRL_DLLRDY_GOING 0x0 > +#define PHYCTRL_FREQSEL_200M 0x0 > +#define PHYCTRL_FREQSEL_50M 0x1 > +#define PHYCTRL_FREQSEL_100M 0x2 > +#define PHYCTRL_FREQSEL_150M 0x3 > +#define PHYCTRL_FREQSEL_MASK 0x3 > +#define PHYCTRL_FREQSEL_SHIFT 0xc > +#define PHYCTRL_DR_MASK 0x7 > +#define PHYCTRL_DR_SHIFT 0x4 > +#define PHYCTRL_DR_50OHM 0x0 > +#define PHYCTRL_DR_33OHM 0x1 > +#define PHYCTRL_DR_66OHM 0x2 > +#define PHYCTRL_DR_100OHM 0x3 > +#define PHYCTRL_DR_40OHM 0x4 > #define PHYCTRL_OTAPDLYENA 0x1 > #define PHYCTRL_OTAPDLYENA_MASK 0x1 > #define PHYCTRL_OTAPDLYENA_SHIFT 0xb > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH 4/4] phy: rockchip-emmc: reindent the register definitions Date: Mon, 20 Jun 2016 18:42:08 +0530 Message-ID: <5767EBA8.1060603@ti.com> References: <1463092986-61777-1-git-send-email-briannorris@chromium.org> <1463092986-61777-4-git-send-email-briannorris@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1463092986-61777-4-git-send-email-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Brian Norris Cc: Heiko Stuebner , Shawn Lin , Doug Anderson , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Brian Norris , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rockchip.vger.kernel.org On Friday 13 May 2016 04:13 AM, Brian Norris wrote: > Some of the spacing was wrong (spaces instead of tabs), and due to > longer entries added later, the columns weren't aligned. Let's get > everything consistent. > > Signed-off-by: Brian Norris Acked-by: Kishon Vijay Abraham I > --- > drivers/phy/phy-rockchip-emmc.c | 76 ++++++++++++++++++++--------------------- > 1 file changed, 38 insertions(+), 38 deletions(-) > > diff --git a/drivers/phy/phy-rockchip-emmc.c b/drivers/phy/phy-rockchip-emmc.c > index f94d3a6587ed..c27ca2b39dfe 100644 > --- a/drivers/phy/phy-rockchip-emmc.c > +++ b/drivers/phy/phy-rockchip-emmc.c > @@ -31,44 +31,44 @@ > ((val) << (shift) | (mask) << ((shift) + 16)) > > /* Register definition */ > -#define GRF_EMMCPHY_CON0 0x0 > -#define GRF_EMMCPHY_CON1 0x4 > -#define GRF_EMMCPHY_CON2 0x8 > -#define GRF_EMMCPHY_CON3 0xc > -#define GRF_EMMCPHY_CON4 0x10 > -#define GRF_EMMCPHY_CON5 0x14 > -#define GRF_EMMCPHY_CON6 0x18 > -#define GRF_EMMCPHY_STATUS 0x20 > - > -#define PHYCTRL_PDB_MASK 0x1 > -#define PHYCTRL_PDB_SHIFT 0x0 > -#define PHYCTRL_PDB_PWR_ON 0x1 > -#define PHYCTRL_PDB_PWR_OFF 0x0 > -#define PHYCTRL_ENDLL_MASK 0x1 > -#define PHYCTRL_ENDLL_SHIFT 0x1 > -#define PHYCTRL_ENDLL_ENABLE 0x1 > -#define PHYCTRL_ENDLL_DISABLE 0x0 > -#define PHYCTRL_CALDONE_MASK 0x1 > -#define PHYCTRL_CALDONE_SHIFT 0x6 > -#define PHYCTRL_CALDONE_DONE 0x1 > -#define PHYCTRL_CALDONE_GOING 0x0 > -#define PHYCTRL_DLLRDY_MASK 0x1 > -#define PHYCTRL_DLLRDY_SHIFT 0x5 > -#define PHYCTRL_DLLRDY_DONE 0x1 > -#define PHYCTRL_DLLRDY_GOING 0x0 > -#define PHYCTRL_FREQSEL_200M 0x0 > -#define PHYCTRL_FREQSEL_50M 0x1 > -#define PHYCTRL_FREQSEL_100M 0x2 > -#define PHYCTRL_FREQSEL_150M 0x3 > -#define PHYCTRL_FREQSEL_MASK 0x3 > -#define PHYCTRL_FREQSEL_SHIFT 0xc > -#define PHYCTRL_DR_MASK 0x7 > -#define PHYCTRL_DR_SHIFT 0x4 > -#define PHYCTRL_DR_50OHM 0x0 > -#define PHYCTRL_DR_33OHM 0x1 > -#define PHYCTRL_DR_66OHM 0x2 > -#define PHYCTRL_DR_100OHM 0x3 > -#define PHYCTRL_DR_40OHM 0x4 > +#define GRF_EMMCPHY_CON0 0x0 > +#define GRF_EMMCPHY_CON1 0x4 > +#define GRF_EMMCPHY_CON2 0x8 > +#define GRF_EMMCPHY_CON3 0xc > +#define GRF_EMMCPHY_CON4 0x10 > +#define GRF_EMMCPHY_CON5 0x14 > +#define GRF_EMMCPHY_CON6 0x18 > +#define GRF_EMMCPHY_STATUS 0x20 > + > +#define PHYCTRL_PDB_MASK 0x1 > +#define PHYCTRL_PDB_SHIFT 0x0 > +#define PHYCTRL_PDB_PWR_ON 0x1 > +#define PHYCTRL_PDB_PWR_OFF 0x0 > +#define PHYCTRL_ENDLL_MASK 0x1 > +#define PHYCTRL_ENDLL_SHIFT 0x1 > +#define PHYCTRL_ENDLL_ENABLE 0x1 > +#define PHYCTRL_ENDLL_DISABLE 0x0 > +#define PHYCTRL_CALDONE_MASK 0x1 > +#define PHYCTRL_CALDONE_SHIFT 0x6 > +#define PHYCTRL_CALDONE_DONE 0x1 > +#define PHYCTRL_CALDONE_GOING 0x0 > +#define PHYCTRL_DLLRDY_MASK 0x1 > +#define PHYCTRL_DLLRDY_SHIFT 0x5 > +#define PHYCTRL_DLLRDY_DONE 0x1 > +#define PHYCTRL_DLLRDY_GOING 0x0 > +#define PHYCTRL_FREQSEL_200M 0x0 > +#define PHYCTRL_FREQSEL_50M 0x1 > +#define PHYCTRL_FREQSEL_100M 0x2 > +#define PHYCTRL_FREQSEL_150M 0x3 > +#define PHYCTRL_FREQSEL_MASK 0x3 > +#define PHYCTRL_FREQSEL_SHIFT 0xc > +#define PHYCTRL_DR_MASK 0x7 > +#define PHYCTRL_DR_SHIFT 0x4 > +#define PHYCTRL_DR_50OHM 0x0 > +#define PHYCTRL_DR_33OHM 0x1 > +#define PHYCTRL_DR_66OHM 0x2 > +#define PHYCTRL_DR_100OHM 0x3 > +#define PHYCTRL_DR_40OHM 0x4 > #define PHYCTRL_OTAPDLYENA 0x1 > #define PHYCTRL_OTAPDLYENA_MASK 0x1 > #define PHYCTRL_OTAPDLYENA_SHIFT 0xb > From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (Kishon Vijay Abraham I) Date: Mon, 20 Jun 2016 18:42:08 +0530 Subject: [PATCH 4/4] phy: rockchip-emmc: reindent the register definitions In-Reply-To: <1463092986-61777-4-git-send-email-briannorris@chromium.org> References: <1463092986-61777-1-git-send-email-briannorris@chromium.org> <1463092986-61777-4-git-send-email-briannorris@chromium.org> Message-ID: <5767EBA8.1060603@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 13 May 2016 04:13 AM, Brian Norris wrote: > Some of the spacing was wrong (spaces instead of tabs), and due to > longer entries added later, the columns weren't aligned. Let's get > everything consistent. > > Signed-off-by: Brian Norris Acked-by: Kishon Vijay Abraham I > --- > drivers/phy/phy-rockchip-emmc.c | 76 ++++++++++++++++++++--------------------- > 1 file changed, 38 insertions(+), 38 deletions(-) > > diff --git a/drivers/phy/phy-rockchip-emmc.c b/drivers/phy/phy-rockchip-emmc.c > index f94d3a6587ed..c27ca2b39dfe 100644 > --- a/drivers/phy/phy-rockchip-emmc.c > +++ b/drivers/phy/phy-rockchip-emmc.c > @@ -31,44 +31,44 @@ > ((val) << (shift) | (mask) << ((shift) + 16)) > > /* Register definition */ > -#define GRF_EMMCPHY_CON0 0x0 > -#define GRF_EMMCPHY_CON1 0x4 > -#define GRF_EMMCPHY_CON2 0x8 > -#define GRF_EMMCPHY_CON3 0xc > -#define GRF_EMMCPHY_CON4 0x10 > -#define GRF_EMMCPHY_CON5 0x14 > -#define GRF_EMMCPHY_CON6 0x18 > -#define GRF_EMMCPHY_STATUS 0x20 > - > -#define PHYCTRL_PDB_MASK 0x1 > -#define PHYCTRL_PDB_SHIFT 0x0 > -#define PHYCTRL_PDB_PWR_ON 0x1 > -#define PHYCTRL_PDB_PWR_OFF 0x0 > -#define PHYCTRL_ENDLL_MASK 0x1 > -#define PHYCTRL_ENDLL_SHIFT 0x1 > -#define PHYCTRL_ENDLL_ENABLE 0x1 > -#define PHYCTRL_ENDLL_DISABLE 0x0 > -#define PHYCTRL_CALDONE_MASK 0x1 > -#define PHYCTRL_CALDONE_SHIFT 0x6 > -#define PHYCTRL_CALDONE_DONE 0x1 > -#define PHYCTRL_CALDONE_GOING 0x0 > -#define PHYCTRL_DLLRDY_MASK 0x1 > -#define PHYCTRL_DLLRDY_SHIFT 0x5 > -#define PHYCTRL_DLLRDY_DONE 0x1 > -#define PHYCTRL_DLLRDY_GOING 0x0 > -#define PHYCTRL_FREQSEL_200M 0x0 > -#define PHYCTRL_FREQSEL_50M 0x1 > -#define PHYCTRL_FREQSEL_100M 0x2 > -#define PHYCTRL_FREQSEL_150M 0x3 > -#define PHYCTRL_FREQSEL_MASK 0x3 > -#define PHYCTRL_FREQSEL_SHIFT 0xc > -#define PHYCTRL_DR_MASK 0x7 > -#define PHYCTRL_DR_SHIFT 0x4 > -#define PHYCTRL_DR_50OHM 0x0 > -#define PHYCTRL_DR_33OHM 0x1 > -#define PHYCTRL_DR_66OHM 0x2 > -#define PHYCTRL_DR_100OHM 0x3 > -#define PHYCTRL_DR_40OHM 0x4 > +#define GRF_EMMCPHY_CON0 0x0 > +#define GRF_EMMCPHY_CON1 0x4 > +#define GRF_EMMCPHY_CON2 0x8 > +#define GRF_EMMCPHY_CON3 0xc > +#define GRF_EMMCPHY_CON4 0x10 > +#define GRF_EMMCPHY_CON5 0x14 > +#define GRF_EMMCPHY_CON6 0x18 > +#define GRF_EMMCPHY_STATUS 0x20 > + > +#define PHYCTRL_PDB_MASK 0x1 > +#define PHYCTRL_PDB_SHIFT 0x0 > +#define PHYCTRL_PDB_PWR_ON 0x1 > +#define PHYCTRL_PDB_PWR_OFF 0x0 > +#define PHYCTRL_ENDLL_MASK 0x1 > +#define PHYCTRL_ENDLL_SHIFT 0x1 > +#define PHYCTRL_ENDLL_ENABLE 0x1 > +#define PHYCTRL_ENDLL_DISABLE 0x0 > +#define PHYCTRL_CALDONE_MASK 0x1 > +#define PHYCTRL_CALDONE_SHIFT 0x6 > +#define PHYCTRL_CALDONE_DONE 0x1 > +#define PHYCTRL_CALDONE_GOING 0x0 > +#define PHYCTRL_DLLRDY_MASK 0x1 > +#define PHYCTRL_DLLRDY_SHIFT 0x5 > +#define PHYCTRL_DLLRDY_DONE 0x1 > +#define PHYCTRL_DLLRDY_GOING 0x0 > +#define PHYCTRL_FREQSEL_200M 0x0 > +#define PHYCTRL_FREQSEL_50M 0x1 > +#define PHYCTRL_FREQSEL_100M 0x2 > +#define PHYCTRL_FREQSEL_150M 0x3 > +#define PHYCTRL_FREQSEL_MASK 0x3 > +#define PHYCTRL_FREQSEL_SHIFT 0xc > +#define PHYCTRL_DR_MASK 0x7 > +#define PHYCTRL_DR_SHIFT 0x4 > +#define PHYCTRL_DR_50OHM 0x0 > +#define PHYCTRL_DR_33OHM 0x1 > +#define PHYCTRL_DR_66OHM 0x2 > +#define PHYCTRL_DR_100OHM 0x3 > +#define PHYCTRL_DR_40OHM 0x4 > #define PHYCTRL_OTAPDLYENA 0x1 > #define PHYCTRL_OTAPDLYENA_MASK 0x1 > #define PHYCTRL_OTAPDLYENA_SHIFT 0xb >