From: Hans Verkuil <hverkuil@xs4all.nl>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Subject: Re: [PATCH v2 1/7] v4l: Correct the ordering of LSBs of the 10-bit raw packed formats
Date: Mon, 20 Jun 2016 19:03:21 +0200 [thread overview]
Message-ID: <576821D9.5090303@xs4all.nl> (raw)
In-Reply-To: <1466439608-22890-2-git-send-email-sakari.ailus@linux.intel.com>
On 06/20/2016 06:20 PM, Sakari Ailus wrote:
> The 10-bit packed raw bayer format documented that the data of the first
> pixel of a four-pixel group was found in the first byte and the two
> highest bits of the fifth byte. This was not entirely correct. The two
> bits in the fifth byte are the two lowest bits. The second pixel occupies
> the second byte and third and fourth least significant bits and so on.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
As mentioned, this needs confirmation. I wonder, isn't this specified in the UVC
spec?
Regards,
Hans
> ---
> .../DocBook/media/v4l/pixfmt-srggb10p.xml | 32 +++++++++++-----------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml b/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml
> index a8cc102..747822b 100644
> --- a/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml
> +++ b/Documentation/DocBook/media/v4l/pixfmt-srggb10p.xml
> @@ -47,10 +47,10 @@
> <entry>G<subscript>01high</subscript></entry>
> <entry>B<subscript>02high</subscript></entry>
> <entry>G<subscript>03high</subscript></entry>
> - <entry>B<subscript>00low</subscript>(bits 7--6)
> - G<subscript>01low</subscript>(bits 5--4)
> - B<subscript>02low</subscript>(bits 3--2)
> - G<subscript>03low</subscript>(bits 1--0)
> + <entry>G<subscript>03low</subscript>(bits 7--6)
> + B<subscript>02low</subscript>(bits 5--4)
> + G<subscript>01low</subscript>(bits 3--2)
> + B<subscript>00low</subscript>(bits 1--0)
> </entry>
> </row>
> <row>
> @@ -59,10 +59,10 @@
> <entry>R<subscript>11high</subscript></entry>
> <entry>G<subscript>12high</subscript></entry>
> <entry>R<subscript>13high</subscript></entry>
> - <entry>G<subscript>10low</subscript>(bits 7--6)
> - R<subscript>11low</subscript>(bits 5--4)
> - G<subscript>12low</subscript>(bits 3--2)
> - R<subscript>13low</subscript>(bits 1--0)
> + <entry>R<subscript>13low</subscript>(bits 7--6)
> + G<subscript>12low</subscript>(bits 5--4)
> + R<subscript>11low</subscript>(bits 3--2)
> + G<subscript>10low</subscript>(bits 1--0)
> </entry>
> </row>
> <row>
> @@ -71,10 +71,10 @@
> <entry>G<subscript>21high</subscript></entry>
> <entry>B<subscript>22high</subscript></entry>
> <entry>G<subscript>23high</subscript></entry>
> - <entry>B<subscript>20low</subscript>(bits 7--6)
> - G<subscript>21low</subscript>(bits 5--4)
> - B<subscript>22low</subscript>(bits 3--2)
> - G<subscript>23low</subscript>(bits 1--0)
> + <entry>G<subscript>23low</subscript>(bits 7--6)
> + B<subscript>22low</subscript>(bits 5--4)
> + G<subscript>21low</subscript>(bits 3--2)
> + B<subscript>20low</subscript>(bits 1--0)
> </entry>
> </row>
> <row>
> @@ -83,10 +83,10 @@
> <entry>R<subscript>31high</subscript></entry>
> <entry>G<subscript>32high</subscript></entry>
> <entry>R<subscript>33high</subscript></entry>
> - <entry>G<subscript>30low</subscript>(bits 7--6)
> - R<subscript>31low</subscript>(bits 5--4)
> - G<subscript>32low</subscript>(bits 3--2)
> - R<subscript>33low</subscript>(bits 1--0)
> + <entry>R<subscript>33low</subscript>(bits 7--6)
> + G<subscript>32low</subscript>(bits 5--4)
> + R<subscript>31low</subscript>(bits 3--2)
> + G<subscript>30low</subscript>(bits 1--0)
> </entry>
> </row>
> </tbody>
>
next prev parent reply other threads:[~2016-06-20 17:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 16:20 [PATCH v2 0/7] New raw bayer format definitions, fixes Sakari Ailus
2016-06-20 16:20 ` [PATCH v2 1/7] v4l: Correct the ordering of LSBs of the 10-bit raw packed formats Sakari Ailus
2016-06-20 17:03 ` Hans Verkuil [this message]
2016-06-20 20:38 ` Dave Stevenson
2016-06-21 6:24 ` Hans Verkuil
2016-06-20 16:20 ` [PATCH v2 2/7] v4l: Fix number of zeroed high order bits in 12-bit raw format defs Sakari Ailus
2016-06-20 16:54 ` Hans Verkuil
2016-06-20 16:20 ` [PATCH v2 3/7] v4l: Clean up raw bayer pixel format definitions Sakari Ailus
2016-06-20 16:54 ` Hans Verkuil
2016-06-20 16:20 ` [PATCH v2 4/7] v4l: Add packed Bayer raw12 pixel formats Sakari Ailus
2016-06-20 16:20 ` [PATCH v2 5/7] media: Add 1X14 14-bit raw bayer media bus code definitions Sakari Ailus
2016-06-20 16:20 ` [PATCH v2 6/7] v4l: Add 14-bit raw bayer pixel format definitions Sakari Ailus
2016-06-27 14:45 ` [PATCH v2.1 6/9] " Sakari Ailus
2016-07-08 9:24 ` Hans Verkuil
2016-06-20 16:20 ` [PATCH v2 7/7] v4l: Add packed Bayer raw14 pixel formats Sakari Ailus
2016-06-27 14:57 ` [PATCH v2.1 8/9] media: Add 1X16 16-bit raw bayer media bus code definitions Sakari Ailus
2016-06-27 14:57 ` [PATCH v2.1 9/9] v4l: Add 16-bit raw bayer pixel format definitions Sakari Ailus
2016-07-07 6:48 ` [PATCH v2.2 09/10] v4l: 16-bit BGGR is always 16 bits Sakari Ailus
2016-07-07 6:48 ` [PATCH v2.2 10/10] v4l: Add 16-bit raw bayer pixel format definitions Sakari Ailus
2016-07-13 13:48 ` Lad, Prabhakar
2016-07-13 13:47 ` [PATCH v2.2 09/10] v4l: 16-bit BGGR is always 16 bits Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576821D9.5090303@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.